Re: [PATCH] PR27463 Accept DW_FORM_sdata for DW_AT_decl/call_file

[Mark Wielaard <mark@klomp.org>]

On Fri, Feb 26, 2021 at 05:12:33PM +0100, Jakub Jelinek wrote:
> On Fri, Feb 26, 2021 at 05:05:09PM +0100, Mark Wielaard wrote:
> >  	    case DW_FORM_data8: value = read_64 (ptr); handled = true; break;
> >  	    case DW_FORM_udata:
> >  	      value = read_uleb128 (ptr); handled = true; break;
> > +	    case DW_FORM_sdata:
> > +	      {
> > +		int64_t svalue = read_sleb128 (ptr);
> > +		if (svalue >= 0)
> > +		  {
> > +		    value = svalue; handled = true; break;
> 
> Formatting, can you please put each of the 3 stmts on a separate line
> (several times in the patch)?
> The stmt1; stmt2; break; form is only used directly in switches
> to save vertical space, but nested in {}s etc. it just looks weird.

You are probably right. I did indeed do it to match the switch
statements. But given that we do need brackets anyway to open/close
the if/else blocks it makes sense to just write eacht statement on its
own line. Fixed all 4 places (at least I was consistent :) And pushed.

Thanks,

Mark