From: Jakub Jelinek <jakub@redhat.com>
To: Mark Wielaard <mark@klomp.org>
Cc: dwz@sourceware.org
Subject: Re: [PATCH] PR27463 Accept DW_FORM_sdata for DW_AT_decl/call_file
Date: Fri, 26 Feb 2021 17:12:33 +0100 [thread overview]
Message-ID: <20210226161233.GZ4020736@tucnak> (raw)
In-Reply-To: <1614355509-20606-1-git-send-email-mark@klomp.org>
On Fri, Feb 26, 2021 at 05:05:09PM +0100, Mark Wielaard wrote:
> case DW_FORM_data8: value = read_64 (ptr); handled = true; break;
> case DW_FORM_udata:
> value = read_uleb128 (ptr); handled = true; break;
> + case DW_FORM_sdata:
> + {
> + int64_t svalue = read_sleb128 (ptr);
> + if (svalue >= 0)
> + {
> + value = svalue; handled = true; break;
Formatting, can you please put each of the 3 stmts on a separate line
(several times in the patch)?
The stmt1; stmt2; break; form is only used directly in switches
to save vertical space, but nested in {}s etc. it just looks weird.
Otherwise LGTM.
Jakub
next prev parent reply other threads:[~2021-02-26 16:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-26 16:05 Mark Wielaard
2021-02-26 16:12 ` Jakub Jelinek [this message]
2021-02-26 16:55 ` Mark Wielaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210226161233.GZ4020736@tucnak \
--to=jakub@redhat.com \
--cc=dwz@sourceware.org \
--cc=mark@klomp.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).