public inbox for
 help / color / mirror / Atom feed
From: Tom de Vries <>
Subject: [committed][testsuite] Fix with -gdwarf-5
Date: Fri, 5 Mar 2021 10:41:26 +0100	[thread overview]
Message-ID: <20210305094125.GA2660@delia> (raw)


When running the test-suite like this:
$ make clean; make; make check CC="gcc -gdwarf-5" CXX="g++ -gdwarf-5"
we run into:
FAIL: src/testsuite/dwz.tests/

The test-case calls dwz twice, once without and once with

The first call is there to verify that all DIEs that can be deduplicated
without --devel-ignore-locus are indeed deduplicated, but not more.

The FAIL happens because some DIEs are not deduplicated.  This is a regression
since commit 61c8d81 "Fix DW_AT_decl_file for odr".  This makes sense: the
commit changed partitioning, and now the size heuristics are preventing some

Fix this by ignoring the size heuristics in the first dwz call using

Committed to trunk.

- Tom

[testsuite] Fix with -gdwarf-5

2021-03-05  Tom de Vries  <>

	* testsuite/dwz.tests/ Call dwz first time using

 testsuite/dwz.tests/ | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/testsuite/dwz.tests/ b/testsuite/dwz.tests/
index 4dc8fb3..a8b3318 100644
--- a/testsuite/dwz.tests/
+++ b/testsuite/dwz.tests/
@@ -9,7 +9,7 @@ for name in aaa bbb ccc; do
     [ $cnt -eq 2 ]
-$execs/dwz-for-test --odr 1
+$execs/dwz-for-test --odr 1 --devel-ignore-size 1

                 reply	other threads:[~2021-03-05  9:41 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210305094125.GA2660@delia \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).