From: Tom de Vries <tdevries@suse.de>
To: dwz@sourceware.org, jakub@redhat.com, mark@klomp.org
Subject: [committed][testsuite] Fix odr-loc.sh with -gdwarf-5
Date: Fri, 5 Mar 2021 10:41:26 +0100 [thread overview]
Message-ID: <20210305094125.GA2660@delia> (raw)
Hi,
When running the test-suite like this:
...
$ make clean; make; make check CC="gcc -gdwarf-5" CXX="g++ -gdwarf-5"
...
we run into:
...
FAIL: src/testsuite/dwz.tests/odr-loc.sh
...
The test-case calls dwz twice, once without and once with
--devel-ignore-locus.
The first call is there to verify that all DIEs that can be deduplicated
without --devel-ignore-locus are indeed deduplicated, but not more.
The FAIL happens because some DIEs are not deduplicated. This is a regression
since commit 61c8d81 "Fix DW_AT_decl_file for odr". This makes sense: the
commit changed partitioning, and now the size heuristics are preventing some
deduplication.
Fix this by ignoring the size heuristics in the first dwz call using
--devel-ignore-size.
Committed to trunk.
Thanks,
- Tom
[testsuite] Fix odr-loc.sh with -gdwarf-5
2021-03-05 Tom de Vries <tdevries@suse.de>
* testsuite/dwz.tests/odr-loc.sh: Call dwz first time using
--devel-ignore-size.
---
testsuite/dwz.tests/odr-loc.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/testsuite/dwz.tests/odr-loc.sh b/testsuite/dwz.tests/odr-loc.sh
index 4dc8fb3..a8b3318 100644
--- a/testsuite/dwz.tests/odr-loc.sh
+++ b/testsuite/dwz.tests/odr-loc.sh
@@ -9,7 +9,7 @@ for name in aaa bbb ccc; do
[ $cnt -eq 2 ]
done
-$execs/dwz-for-test --odr 1
+$execs/dwz-for-test --odr 1 --devel-ignore-size
verify-dwarf.sh 1
reply other threads:[~2021-03-05 9:41 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210305094125.GA2660@delia \
--to=tdevries@suse.de \
--cc=dwz@sourceware.org \
--cc=jakub@redhat.com \
--cc=mark@klomp.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).