From: Mark Wielaard <mark@klomp.org>
To: Jakub Jelinek <jakub@redhat.com>, Tom de Vries <tdevries@suse.de>
Cc: dwz@sourceware.org, Mark Wielaard <mark@gcc.gnu.org>
Subject: Re: [committed] Fix error: Unknown DWARF DW_FORM_ref_sig8
Date: Fri, 02 Oct 2020 19:43:16 +0200 [thread overview]
Message-ID: <62b131c1acd1397799117165611020c8d326c8ea.camel@klomp.org> (raw)
In-Reply-To: <20201002171037.GY2176@tucnak>
On Fri, 2020-10-02 at 19:10 +0200, Jakub Jelinek wrote:
> On Fri, Oct 02, 2020 at 07:05:22PM +0200, Tom de Vries wrote:
> > Fix by using this instead:
> > ...
> > && !(form == DW_FORM_ref_sig8
> > || form == DW_FORM_data16
> > || form == DW_FORM_line_strp)))
> > ...
>
> Sorry for not catching it in the review.
Actually you did, you did say the logic was wrong, but then we
remembered that for DWARF4 we had:
[...]
DW_FORM_flag_present = 0x19
DW_FORM_ref_sig8 = 0x20
(haha, someone forgot how to count in hex, should have been 0x1a)
which made the original logic correct. But not what I ended up
writing... doh.
Thanks for catching that Tom.
I have no idea how this got through my testing :{
Cheers,
Mark
prev parent reply other threads:[~2020-10-02 17:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-02 17:05 Tom de Vries
2020-10-02 17:10 ` Jakub Jelinek
2020-10-02 17:43 ` Mark Wielaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62b131c1acd1397799117165611020c8d326c8ea.camel@klomp.org \
--to=mark@klomp.org \
--cc=dwz@sourceware.org \
--cc=jakub@redhat.com \
--cc=mark@gcc.gnu.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).