public inbox for dwz@sourceware.org
 help / color / mirror / Atom feed
From: Mark Wielaard <mark@klomp.org>
To: Jakub Jelinek <jakub@redhat.com>
Cc: dwz@sourceware.org
Subject: Re: [PATCH] Add write_sleb129 and size_of_sleb128 for writing DW_FORM_implicit_const
Date: Tue, 29 Sep 2020 20:19:30 +0200	[thread overview]
Message-ID: <7af37960d85173dc28c4a29cff3f8eb94dc090e2.camel@klomp.org> (raw)
In-Reply-To: <20200929082415.GW2176@tucnak>

Hi Jakub,

On Tue, 2020-09-29 at 10:24 +0200, Jakub Jelinek via Dwz wrote:
> 
> The parens above are unnecessary.
> [...]
> And this has even more unnecessary parens.
> [...]
> Otherwise LGTM.

Thanks simplified those and fixed the commit message.
Haven't pushed this because the DW_FORM_implicit_const support isn't
100% yet. The is the memory issue and I think the hashing/checksum
isn't 100% correct because in DWARF5 mode I still see some odr
failures. I'll get back to that after finishing the DWARF5 .debug_line
support. For now the patches can be found here:
https://code.wildebeest.org/git/user/mjw/dwz/log/?h=dwarf5-forms

Cheers,

Mark

      reply	other threads:[~2020-09-29 18:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-28  7:36 Mark Wielaard
2020-09-29  8:24 ` Jakub Jelinek
2020-09-29 18:19   ` Mark Wielaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7af37960d85173dc28c4a29cff3f8eb94dc090e2.camel@klomp.org \
    --to=mark@klomp.org \
    --cc=dwz@sourceware.org \
    --cc=jakub@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).