public inbox for
 help / color / mirror / Atom feed
From: Tom de Vries <>
To: Jakub Jelinek <>, Mark Wielaard <>
Subject: Re: [PATCH] Handle DW_FORM_implicit_const for DW_AT_decl_line
Date: Mon, 15 Feb 2021 13:54:19 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On 2/14/21 10:27 PM, Tom de Vries wrote:
> On 2/14/21 8:19 PM, Jakub Jelinek wrote:
>> On Sun, Feb 14, 2021 at 08:10:49PM +0100, Mark Wielaard wrote:
>>> Yes, this makes sense. Like you said, we do something like this already
>>> for decl/call_file. I think technically the die_eq_1 part could be put
>>> under the same switch case. But maybe you find it clearer to do it
>>> separately to mirror the checksum_die part?
>> Yeah, I'm wondering if we just shouldn't hash and compare all constant class
>> forms with the same value the same (ok, except DW_FORM_data16 which is too
>> large).  For DW_FORM_data{1,2,4,8} we don't know if it is signed or
>> unsigned, so perhaps just treat values with the msb clear that way?
>> Or sure, if we can put in a list of attributes that always have unsigned
>> or always have signed constants, we can even improve that.
> Make sense to me.

Filed as PR27421 - Improve DW_FORM_implicit_const handling in
checksum_die/die_eq_1 ( ).

- Tom

  reply	other threads:[~2021-02-15 12:54 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-14  8:52 Tom de Vries
2021-02-14 19:10 ` Mark Wielaard
2021-02-14 19:19   ` Jakub Jelinek
2021-02-14 21:27     ` Tom de Vries
2021-02-15 12:54       ` Tom de Vries [this message]
2021-02-14 21:23   ` Tom de Vries

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).