From: Tom de Vries <tdevries@suse.de>
To: Jakub Jelinek <jakub@redhat.com>, Mark Wielaard <mark@klomp.org>
Cc: dwz@sourceware.org
Subject: Re: [PATCH] Handle DW_FORM_implicit_const for DW_AT_decl_line
Date: Sun, 14 Feb 2021 22:27:43 +0100 [thread overview]
Message-ID: <e4ee034f-6ee9-8c10-ce44-cdeefd2fdeba@suse.de> (raw)
In-Reply-To: <20210214191943.GP4020736@tucnak>
On 2/14/21 8:19 PM, Jakub Jelinek wrote:
> On Sun, Feb 14, 2021 at 08:10:49PM +0100, Mark Wielaard wrote:
>> Yes, this makes sense. Like you said, we do something like this already
>> for decl/call_file. I think technically the die_eq_1 part could be put
>> under the same switch case. But maybe you find it clearer to do it
>> separately to mirror the checksum_die part?
>
> Yeah, I'm wondering if we just shouldn't hash and compare all constant class
> forms with the same value the same (ok, except DW_FORM_data16 which is too
> large). For DW_FORM_data{1,2,4,8} we don't know if it is signed or
> unsigned, so perhaps just treat values with the msb clear that way?
> Or sure, if we can put in a list of attributes that always have unsigned
> or always have signed constants, we can even improve that.
Make sense to me.
Thanks,
- Tom
next prev parent reply other threads:[~2021-02-14 21:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-14 8:52 Tom de Vries
2021-02-14 19:10 ` Mark Wielaard
2021-02-14 19:19 ` Jakub Jelinek
2021-02-14 21:27 ` Tom de Vries [this message]
2021-02-15 12:54 ` Tom de Vries
2021-02-14 21:23 ` Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e4ee034f-6ee9-8c10-ce44-cdeefd2fdeba@suse.de \
--to=tdevries@suse.de \
--cc=dwz@sourceware.org \
--cc=jakub@redhat.com \
--cc=mark@klomp.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).