From: "vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: dwz@sourceware.org
Subject: [Bug default/24275] hardlink handling leaves temporary file if not file compressed
Date: Tue, 01 Jan 2019 00:00:00 -0000 [thread overview]
Message-ID: <bug-24275-11298-CyIUUt1QqM@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-24275-11298@http.sourceware.org/bugzilla/>
https://sourceware.org/bugzilla/show_bug.cgi?id=24275
Tom de Vries <vries at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jakub at redhat dot com
--- Comment #1 from Tom de Vries <vries at gcc dot gnu.org> ---
AFAIU, the problem originates from the fact that the dedicated handling for
this case in the dwz function:
...
/* If a hardlink to this has been processed before
and we didn't change it, just assume the same
state. */
if (resa[n].res == 1)
{
close (fd);
res->res = -2;
return 1;
}
...
is not triggered when called with b.out argument because this code at the end
of dwz:
...
free (dso);
if (ret == 0 && !low_mem)
res->res = 0;
return ret;
...
sets resa[n].res to 0 when called with a.out argument, irregardless of whether
a.out was changed or not.
--
You are receiving this mail because:
You are on the CC list for the bug.
next prev parent reply other threads:[~2019-02-27 9:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-01 0:00 [Bug default/24275] New: " vries at gcc dot gnu.org
2019-01-01 0:00 ` vries at gcc dot gnu.org [this message]
2019-01-01 0:00 ` [Bug default/24275] " vries at gcc dot gnu.org
2020-01-01 0:00 ` vries at gcc dot gnu.org
2020-01-01 0:00 ` jakub at redhat dot com
2020-10-01 13:19 ` mark at klomp dot org
2020-10-02 4:09 ` jirislaby at gmail dot com
2020-11-08 22:25 ` mark at klomp dot org
2021-02-13 22:57 ` mark at klomp dot org
2021-03-04 8:07 ` vries at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-24275-11298-CyIUUt1QqM@http.sourceware.org/bugzilla/ \
--to=sourceware-bugzilla@sourceware.org \
--cc=dwz@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).