From: "vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: dwz@sourceware.org
Subject: [Bug default/25276] create_import_tree performance improvements
Date: Tue, 01 Jan 2019 00:00:00 -0000 [thread overview]
Message-ID: <bug-25276-11298-dkff6r84Rl@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-25276-11298@http.sourceware.org/bugzilla/>
https://sourceware.org/bugzilla/show_bug.cgi?id=25276
--- Comment #1 from Tom de Vries <vries at gcc dot gnu.org> ---
(In reply to Tom de Vries from comment #0)
> This is a draft of a short-cut that might prevent going into the hot loop:
> ...
> @@ -7683,6 +7684,26 @@ create_import_tree (void)
> maybe_subset = (e1 == ipu->incoming
> && ipu->incoming_count <=
> ipu2->incoming_count);
> maybe_superset = ipu->incoming_count >= ipu2->incoming_count;
> + if (maybe_superset)
> + {
> + /* If the referrer nodes of ipu are a superset of the
> + referrer nodes of ipu2, then ipu's last referrer node
> + should have index larger or equal to the last referrer
> + node of ipu2. */
> + maybe_superset
> + = (ipu->incoming[ipu->incoming_count - 1].icu->idx
> + >= ipu2->incoming[ipu2->incoming_count - 1].icu->idx);
> + }
> + if (maybe_subset)
> + {
> + /* If the referrer nodes of ipu are a subset of the
> + referrer nodes of ipu2, then ipu's last referrer node
> + should have index smaller or equal to the last referrer
> + node of ipu2. */
> + maybe_subset
> + = (ipu->incoming[ipu->incoming_count - 1].icu->idx
> + <= ipu2->incoming[ipu2->incoming_count -1].icu->idx);
> + }
> e3 = e1;
> e4 = ipu2->incoming;
> intersection = 0;
> ...
> but it doesn't work currently because we cannot access
> ipu->incoming[ipu->incoming_count - 1] at this point. Instead, we need to
> walk
> the next chain. Keeping track of the tail of the edge chain would fix this,
> and might yield speed improvement.
>
Committed here:
https://sourceware.org/git/?p=dwz.git;a=commit;h=83addcc7c2eadeffb4fe27e433695d316101f6d1
--
You are receiving this mail because:
You are on the CC list for the bug.
next prev parent reply other threads:[~2019-12-17 11:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-01 0:00 [Bug default/25276] New: " vries at gcc dot gnu.org
2019-01-01 0:00 ` vries at gcc dot gnu.org [this message]
2019-01-01 0:00 ` [Bug default/25276] " vries at gcc dot gnu.org
2019-01-01 0:00 ` vries at gcc dot gnu.org
2019-01-01 0:00 ` vries at gcc dot gnu.org
2019-01-01 0:00 ` vries at gcc dot gnu.org
2019-01-01 0:00 ` vries at gcc dot gnu.org
2019-01-01 0:00 ` vries at gcc dot gnu.org
2019-01-01 0:00 ` vries at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-25276-11298-dkff6r84Rl@http.sourceware.org/bugzilla/ \
--to=sourceware-bugzilla@sourceware.org \
--cc=dwz@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).