public inbox for dwz@sourceware.org
 help / color / mirror / Atom feed
From: "vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: dwz@sourceware.org
Subject: [Bug default/25276] create_import_tree performance improvements
Date: Tue, 01 Jan 2019 00:00:00 -0000	[thread overview]
Message-ID: <bug-25276-11298-clcdfVhxe6@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-25276-11298@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=25276

--- Comment #3 from Tom de Vries <vries at gcc dot gnu.org> ---
(In reply to Tom de Vries from comment #0)
> Looking at the perf data, we spend 51% of the time in dwz, 

> Furthermore, we spent 28% here:
> ...
>   7,02 │1481:   movb   $0x0,0x2c(%rax)
>        │            for (icu = ipu->next; icu; icu = icu->next)
>  28,04 │        mov    0x18(%rax),%rax
>   0,00 │        test   %rax,%rax
>   0,87 │      ↑ jne    1481
> ...
> which is this loop here:
> ...
>       for (icu = ipu->next; icu; icu = icu->next)
>         icu->seen = false;
> ...
> 

With current master, we now spent 41% of execution time in dwz, and of that 41%
we spent 59% in this loop:
...
  1,39 │2895:┌─→test   %rax,%rax
  0,01 │     │↑ je     1fcd
       │     │        icu->seen = false;
 11,10 │     │  movb   $0x0,0x34(%rax)
       │     │      for (icu = ipu->next; icu; icu = icu->next)
 47,87 │     │  mov    0x20(%rax),%rax
  0,36 │     └──jmp    2895
...

-- 
You are receiving this mail because:
You are on the CC list for the bug.

      parent reply	other threads:[~2019-12-17 12:32 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-01  0:00 [Bug default/25276] New: " vries at gcc dot gnu.org
2019-01-01  0:00 ` [Bug default/25276] " vries at gcc dot gnu.org
2019-01-01  0:00 ` vries at gcc dot gnu.org
2019-01-01  0:00 ` vries at gcc dot gnu.org
2019-01-01  0:00 ` vries at gcc dot gnu.org
2019-01-01  0:00 ` vries at gcc dot gnu.org
2019-01-01  0:00 ` vries at gcc dot gnu.org
2019-01-01  0:00 ` vries at gcc dot gnu.org
2019-01-01  0:00 ` vries at gcc dot gnu.org [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-25276-11298-clcdfVhxe6@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=dwz@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).