From: "vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: dwz@sourceware.org
Subject: [Bug default/25439] namespace DIE added to duplicate chain list (--odr-mode=basic)
Date: Wed, 01 Jan 2020 00:00:00 -0000 [thread overview]
Message-ID: <bug-25439-11298-uWjLIvXF87@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-25439-11298@http.sourceware.org/bugzilla/>
https://sourceware.org/bugzilla/show_bug.cgi?id=25439
--- Comment #2 from Tom de Vries <vries at gcc dot gnu.org> ---
Tentative patch:
...
index 08e3df4..e2a4ec4 100644
--- a/dwz.c
+++ b/dwz.c
@@ -3370,24 +3370,31 @@ checksum_ref_die (dw_cu_ref cu, dw_die_ref top_die,
dw_die_ref die,
}
}
- if (!only_hash_name_p
- && (top_die == NULL || top_die->die_ck_state != CK_BAD))
- for (child = die->die_child; child; child = child->die_sib)
- {
- unsigned int r
- = checksum_ref_die (cu,
- top_die ? top_die
- : child->die_named_namespace
- ? NULL : child, child,
- second_idx, second_hash);
- if (top_die == NULL)
- assert (r == 0 && obstack_object_size (&ob) == 0);
-
- if (ret == 0 || (r && r < ret))
- ret = r;
- if (top_die && top_die->die_ck_state == CK_BAD)
- break;
- }
+ if (top_die == NULL || top_die->die_ck_state != CK_BAD)
+ {
+ hashval_t save_checksum;
+ if (top_die)
+ save_checksum = top_die->u.p1.die_ref_hash;
+ for (child = die->die_child; child; child = child->die_sib)
+ {
+ unsigned int r
+ = checksum_ref_die (cu,
+ top_die ? top_die
+ : child->die_named_namespace
+ ? NULL : child, child,
+ second_idx, second_hash);
+ if (top_die == NULL)
+ assert (r == 0 && obstack_object_size (&ob) == 0);
+
+ if (ret == 0 || (r && r < ret))
+ ret = r;
+ if (top_die && top_die->die_ck_state == CK_BAD)
+ break;
+ }
+ if (top_die
+ && top_die->die_ck_state != CK_BAD && only_hash_name_p)
+ top_die->u.p1.die_ref_hash = save_checksum;
+ }--
if (top_die == die)
{
...
However, that also drops effectiveness to less than 1%:
...
$ rm -f 1; ./dwz -Lnone -lnone -o 1 cc1 --no-odr
$ rm -f 2; ./dwz -Lnone -lnone -o 2 cc1 --odr-mode=basic
$ diff.sh cc1 1
.debug_info red: 44.84% 111527248 61527733
.debug_abbrev red: 40.28% 1722726 1028968
.debug_str red: 0% 6609355 6609355
total red: 42.30% 119859329 69166056
$ diff.sh cc1 2
.debug_info red: 45.44% 111527248 60860046
.debug_abbrev red: 42.87% 1722726 984340
.debug_str red: 0% 6609355 6609355
total red: 42.89% 119859329 68453741
...
--
You are receiving this mail because:
You are on the CC list for the bug.
next prev parent reply other threads:[~2020-01-22 13:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-01 0:00 [Bug default/25439] New: " vries at gcc dot gnu.org
2020-01-01 0:00 ` [Bug default/25439] " vries at gcc dot gnu.org
2020-01-01 0:00 ` vries at gcc dot gnu.org [this message]
2021-02-23 13:11 ` vries at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-25439-11298-uWjLIvXF87@http.sourceware.org/bugzilla/ \
--to=sourceware-bugzilla@sourceware.org \
--cc=dwz@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).