public inbox for dwz@sourceware.org
 help / color / mirror / Atom feed
From: "vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: dwz@sourceware.org
Subject: [Bug default/25439] namespace DIE added to duplicate chain list (--odr-mode=basic)
Date: Wed, 01 Jan 2020 00:00:00 -0000	[thread overview]
Message-ID: <bug-25439-11298-IzMui50TxU@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-25439-11298@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=25439

--- Comment #1 from Tom de Vries <vries at gcc dot gnu.org> ---
(In reply to Tom de Vries from comment #0)
> Starting commit 62e4949 "Fix reference from PU to CU (--odr-mode=basic)", we
> run into an abort in build_abbrevs_for_die with:
> ...
> $ dwz -Lnone -lnone -o 1 Checker.so.debug --odr-mode=basic
> ...
> 
> This is a consequence of calling partition_found_dups with a die where
> die->named_namespace == 1 during mark_singletons, the function added in the
> offending commit.
> 
> This happens because a die:
> ...
>  (gdb) call dump_die (die)
>  4db7a86 O ffe1edf 0  imported_module
> ...
> has a reference to a namespace:
> ...
> (gdb) call dump_die (reft)
>  4c3e954 X 9a045343 0 llvm namespace
> ...

And this again is a consequence of something we can detect earlier:
...
@@ -6343,6 +6350,7 @@ partition_cmp (const void *p, const void *q)
 static void
 partition_found_dups (dw_die_ref die, struct obstack *vec)
 {
+  assert (die->die_ck_state == CK_KNOWN);
   obstack_ptr_grow (vec, die);
   if (unlikely (verify_dups_p))
     verify_dups (die, true);
...

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2020-01-22 12:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-01  0:00 [Bug default/25439] New: " vries at gcc dot gnu.org
2020-01-01  0:00 ` [Bug default/25439] " vries at gcc dot gnu.org
2020-01-01  0:00 ` vries at gcc dot gnu.org [this message]
2021-02-23 13:11 ` vries at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-25439-11298-IzMui50TxU@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=dwz@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).