[Bug default/25439] namespace DIE added to duplicate chain list (--odr-mode=basic)

["vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=25439

--- Comment #1 from Tom de Vries <vries at gcc dot gnu.org> ---
(In reply to Tom de Vries from comment #0)
> Starting commit 62e4949 "Fix reference from PU to CU (--odr-mode=basic)", we
> run into an abort in build_abbrevs_for_die with:
> ...
> $ dwz -Lnone -lnone -o 1 Checker.so.debug --odr-mode=basic
> ...
> 
> This is a consequence of calling partition_found_dups with a die where
> die->named_namespace == 1 during mark_singletons, the function added in the
> offending commit.
> 
> This happens because a die:
> ...
>  (gdb) call dump_die (die)
>  4db7a86 O ffe1edf 0  imported_module
> ...
> has a reference to a namespace:
> ...
> (gdb) call dump_die (reft)
>  4c3e954 X 9a045343 0 llvm namespace
> ...

And this again is a consequence of something we can detect earlier:
...
@@ -6343,6 +6350,7 @@ partition_cmp (const void *p, const void *q)
 static void
 partition_found_dups (dw_die_ref die, struct obstack *vec)
 {
+  assert (die->die_ck_state == CK_KNOWN);
   obstack_ptr_grow (vec, die);
   if (unlikely (verify_dups_p))
     verify_dups (die, true);
...

-- 
You are receiving this mail because:
You are on the CC list for the bug.