public inbox for
 help / color / mirror / Atom feed
From: "vries at gcc dot" <>
Subject: [Bug default/27418] New: DW_FORM_implicit_const handling in checksum_die missing attribute hashing
Date: Sun, 14 Feb 2021 21:33:32 +0000	[thread overview]
Message-ID: <> (raw)

            Bug ID: 27418
           Summary: DW_FORM_implicit_const handling in checksum_die
                    missing attribute hashing
           Product: dwz
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: default
          Assignee: nobody at sourceware dot org
          Reporter: vries at gcc dot
                CC: dwz at sourceware dot org
  Target Milestone: ---

This is something that I don't get:
        case DW_FORM_implicit_const:
          if (!handled && die->die_ck_state != CK_BAD)
              handled = true;
                = iterative_hash_object (t->values[i], die->u.p1.die_hash);

Normally, we have something like:
              s = t->attr[i].attr;
                = iterative_hash_object (s, die->u.p1.die_hash);
                = iterative_hash_object (value, die->u.p1.die_hash);
so we hash in both the attribute tag and the attribute value.

Why don't we hash in the attribute tag for DW_FORM_implicit_const?

This sound like a bug that makes hash collisions more likely.

You are receiving this mail because:
You are on the CC list for the bug.

             reply	other threads:[~2021-02-14 21:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-14 21:33 vries at gcc dot [this message]
2021-02-14 22:30 ` [Bug default/27418] " mark at klomp dot org
2021-02-15 12:24 ` vries at gcc dot
2021-02-15 13:20 ` mark at klomp dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).