From: "mark at klomp dot org" <sourceware-bugzilla@sourceware.org>
To: dwz@sourceware.org
Subject: [Bug default/27418] DW_FORM_implicit_const handling in checksum_die missing attribute hashing
Date: Sun, 14 Feb 2021 22:30:28 +0000 [thread overview]
Message-ID: <bug-27418-11298-BNJAPD6zK8@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-27418-11298@http.sourceware.org/bugzilla/>
https://sourceware.org/bugzilla/show_bug.cgi?id=27418
Mark Wielaard <mark at klomp dot org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mark at klomp dot org
--- Comment #1 from Mark Wielaard <mark at klomp dot org> ---
I think you are right. The bug seems to be the handled = true; That is not
true, we haven't yet handled the attribute completely. We just added the value
to the hash. The code should then continue so it ends up at the block at the
end after the switch statement:
if (!handled && die->die_ck_state != CK_BAD)
{
s = t->attr[i].attr;
die->u.p1.die_hash = iterative_hash_object (s, die->u.p1.die_hash);
die->u.p1.die_hash
= iterative_hash (old_ptr, ptr - old_ptr, die->u.p1.die_hash);
}
--
You are receiving this mail because:
You are on the CC list for the bug.
next prev parent reply other threads:[~2021-02-14 22:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-14 21:33 [Bug default/27418] New: " vries at gcc dot gnu.org
2021-02-14 22:30 ` mark at klomp dot org [this message]
2021-02-15 12:24 ` [Bug default/27418] " vries at gcc dot gnu.org
2021-02-15 13:20 ` mark at klomp dot org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-27418-11298-BNJAPD6zK8@http.sourceware.org/bugzilla/ \
--to=sourceware-bugzilla@sourceware.org \
--cc=dwz@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).