public inbox for
 help / color / mirror / Atom feed
From: "vries at gcc dot" <>
Subject: [Bug default/27438] [dwz, odr, multifile] Multifile after odr not optimal
Date: Fri, 19 Feb 2021 12:08:21 +0000	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

--- Comment #2 from Tom de Vries <vries at gcc dot> ---
The same problem exists for struct bbb, the struct containing member_four.

Looking at the original file:
$ llvm-dwarfdump  ../odr-struct | grep -A3 struct | egrep -v
"^--|DW_AT_byte_size" | sed 's%/home/vries/dwz/dwz.git/testsuite/dwz.tests/%%'
../odr-struct:  file format ELF64-x86-64

.debug_info contents:
0x00000000: Compile Unit: length = 0x0000002a version = 0x0002 abbr_offset =
0x0000 addr_size = 0x08 (next unit at 0x0000002e)
0x000000f4:   DW_TAG_structure_type
                DW_AT_name      ("ccc")
                DW_AT_decl_file ("")
0x00000114:   DW_TAG_structure_type
                DW_AT_name      ("aaa")
                DW_AT_decl_file ("odr.h")
0x00000139:   DW_TAG_structure_type
                DW_AT_name      ("bbb")
                DW_AT_declaration       (true)

0x000001af:   DW_TAG_structure_type
                DW_AT_name      ("bbb")
                DW_AT_decl_file ("")
0x000001cf:   DW_TAG_structure_type
                DW_AT_name      ("aaa")
                DW_AT_decl_file ("odr.h")
0x000001fa:   DW_TAG_structure_type
                DW_AT_name      ("ccc")
                DW_AT_declaration       (true)
it seems that perhaps is the correct file for struct bbb, so the
multifile is correct, and single-file-optimized file 1 is wrong.

In other words, we can reproduce the problem without multifile mode like this:
$ cp ../odr-struct 1; ../dwz 1 --odr
$ llvm-dwarfdump 1 | grep -A3 struct | egrep -v "^--|DW_AT_byte_size" | sed
0x00000019:   DW_TAG_structure_type
                DW_AT_name      ("ccc")
                DW_AT_decl_file ("")
0x0000002f:   DW_TAG_structure_type
                DW_AT_name      ("aaa")
                DW_AT_decl_file ("odr.h")
0x0000004b:   DW_TAG_structure_type
                DW_AT_name      ("bbb")
                DW_AT_decl_file ("")

You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2021-02-19 12:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-19  8:45 [Bug default/27438] New: " vries at gcc dot
2021-02-19 11:50 ` [Bug default/27438] " vries at gcc dot
2021-02-19 12:08 ` vries at gcc dot [this message]
2021-02-19 12:10 ` vries at gcc dot
2021-02-19 12:24 ` vries at gcc dot
2021-02-22  8:25 ` vries at gcc dot
2021-02-22 15:12 ` vries at gcc dot
2021-02-25 14:53 ` vries at gcc dot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).