public inbox for
 help / color / mirror / Atom feed
From: "vries at gcc dot" <>
Subject: [Bug default/27438] [dwz, odr, multifile] Multifile after odr not optimal
Date: Fri, 19 Feb 2021 12:24:30 +0000	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

--- Comment #4 from Tom de Vries <vries at gcc dot> ---
The problem is caused by the fact that the duplicate chain:
duplicate chain:
 139 O 26b2adba(fdca21c2) 26b2adba bbb structure_type
 1af O 26b2adba(d80f5f71) 26b2adba bbb structure_type
starts with a decl in CU1:
 <1><139>: Abbrev Number: 5 (DW_TAG_structure_type)
    <13a>   DW_AT_name        : bbb
    <13e>   DW_AT_declaration : 1
and then has a def in CU2:
 <1><1af>: Abbrev Number: 2 (DW_TAG_structure_type)
    <1b0>   DW_AT_name        : bbb
    <1b4>   DW_AT_byte_size   : 4
    <1b5>   DW_AT_decl_file   : 1
    <1b6>   DW_AT_decl_line   : 4
    <1b7>   DW_AT_sibling     : <0x1c8>

This is a problem for writing out the dies, since there we count on accessing
the attributes and children of the first die in the duplicate chain.

This problem is fixed by reorder_dups, which switches order of def and decl.

However, consequently the DW_AT_decl_file with value 1, referring to
in CU2 will be interpreted using the file table of CU1, and ends up referring
to instead.  This is the root cause.

You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2021-02-19 12:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-19  8:45 [Bug default/27438] New: " vries at gcc dot
2021-02-19 11:50 ` [Bug default/27438] " vries at gcc dot
2021-02-19 12:08 ` vries at gcc dot
2021-02-19 12:10 ` vries at gcc dot
2021-02-19 12:24 ` vries at gcc dot [this message]
2021-02-22  8:25 ` vries at gcc dot
2021-02-22 15:12 ` vries at gcc dot
2021-02-25 14:53 ` vries at gcc dot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).