public inbox for dwz@sourceware.org
 help / color / mirror / Atom feed
* [Bug default/27572] New: Multifile drops DW_TAG_namespace::DW_AT_export_symbols
@ 2021-03-12 17:13 jan.kratochvil at redhat dot com
  2021-03-12 18:02 ` [Bug default/27572] " mark at klomp dot org
  2021-03-12 19:02 ` mark at klomp dot org
  0 siblings, 2 replies; 3+ messages in thread
From: jan.kratochvil at redhat dot com @ 2021-03-12 17:13 UTC (permalink / raw)
  To: dwz

https://sourceware.org/bugzilla/show_bug.cgi?id=27572

            Bug ID: 27572
           Summary: Multifile drops DW_TAG_namespace::DW_AT_export_symbols
           Product: dwz
           Version: unspecified
            Status: NEW
          Severity: critical
          Priority: P2
         Component: default
          Assignee: nobody at sourceware dot org
          Reporter: jan.kratochvil at redhat dot com
                CC: dwz at sourceware dot org
  Target Milestone: ---

echo 'inline namespace A { enum E { X0,X1,X2,X3,X4,X5 }; } int main() { return
X0; }'|g++ -Wall -g -x c++ -;cp -p a.out a.out.dup;dwz -m a.out.dwz a.out
a.out.dup;readelf -wi a.out.dwz|grep DW_AT_export_symbols

Actual:
(nothing)

Expected:
    <XX>   DW_AT_export_symbols: 1

Context:
a.out:
 <0><b>: Abbrev Number: 1 (DW_TAG_compile_unit)
...
 <1><22>: Abbrev Number: 5 (DW_TAG_imported_unit)
    <23>   DW_AT_import      : <alt 0xb>
 <1><27>: Abbrev Number: 4 (DW_TAG_namespace)
    <28>   DW_AT_name        : A
...
    <2d>   DW_AT_export_symbols: 1
 <2><2e>: Abbrev Number: 0

a.out.dwz:
 <0><b>: Abbrev Number: 4 (DW_TAG_partial_unit)
...
 <1><14>: Abbrev Number: 2 (DW_TAG_namespace)
    <15>   DW_AT_name        : A
...
 <2><18>: Abbrev Number: 6 (DW_TAG_enumeration_type)

This breaks libc++ which is using namespace 'std::__1::' -> 'std::'

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Bug default/27572] Multifile drops DW_TAG_namespace::DW_AT_export_symbols
  2021-03-12 17:13 [Bug default/27572] New: Multifile drops DW_TAG_namespace::DW_AT_export_symbols jan.kratochvil at redhat dot com
@ 2021-03-12 18:02 ` mark at klomp dot org
  2021-03-12 19:02 ` mark at klomp dot org
  1 sibling, 0 replies; 3+ messages in thread
From: mark at klomp dot org @ 2021-03-12 18:02 UTC (permalink / raw)
  To: dwz

https://sourceware.org/bugzilla/show_bug.cgi?id=27572

Mark Wielaard <mark at klomp dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mark at klomp dot org

--- Comment #1 from Mark Wielaard <mark at klomp dot org> ---
Yes, the code assumes the only relevant attribute of a DW_TAG_namespace is the
DW_AT_name. This is both in the build_abbrevs_for_die, write_die and
partition_dups_1 functions. It only allows for an optional DW_AT_sibling
attribute. It should carry over the DW_AT_export_symbols (which is new in
DWARF5).

-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Bug default/27572] Multifile drops DW_TAG_namespace::DW_AT_export_symbols
  2021-03-12 17:13 [Bug default/27572] New: Multifile drops DW_TAG_namespace::DW_AT_export_symbols jan.kratochvil at redhat dot com
  2021-03-12 18:02 ` [Bug default/27572] " mark at klomp dot org
@ 2021-03-12 19:02 ` mark at klomp dot org
  1 sibling, 0 replies; 3+ messages in thread
From: mark at klomp dot org @ 2021-03-12 19:02 UTC (permalink / raw)
  To: dwz

https://sourceware.org/bugzilla/show_bug.cgi?id=27572

Mark Wielaard <mark at klomp dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24726


Referenced Bugs:

https://sourceware.org/bugzilla/show_bug.cgi?id=24726
[Bug 24726] [dwz] Support DWARF5
-- 
You are receiving this mail because:
You are on the CC list for the bug.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-03-12 19:02 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-12 17:13 [Bug default/27572] New: Multifile drops DW_TAG_namespace::DW_AT_export_symbols jan.kratochvil at redhat dot com
2021-03-12 18:02 ` [Bug default/27572] " mark at klomp dot org
2021-03-12 19:02 ` mark at klomp dot org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).