From: Mark Wielaard <mark@klomp.org>
To: Jakub Jelinek <jakub@redhat.com>
Cc: dwz@sourceware.org
Subject: Re: [PATCH 2/4] Handle DW_FORM_data16.
Date: Fri, 25 Sep 2020 18:42:23 +0200 [thread overview]
Message-ID: <c026637049d5466c49e947d6ecc6dfb2b51aae3c.camel@klomp.org> (raw)
In-Reply-To: <20200924194333.GP2176@tucnak>
Hi,
On Thu, 2020-09-24 at 21:43 +0200, Jakub Jelinek wrote:
> On Thu, Sep 24, 2020 at 06:25:55PM +0200, Mark Wielaard wrote:
> > @@ -1709,6 +1710,9 @@ skip_attr_no_dw_form_indirect (unsigned int
> > cu_version, uint32_t form,
> > case DW_FORM_ref_sig8:
> > ptr += 8;
> > break;
> > + case DW_FORM_data16:
> > + ptr += 16;
> > + break;
> > case DW_FORM_sdata:
> > case DW_FORM_ref_udata:
> > case DW_FORM_udata:
> > @@ -2975,6 +2979,9 @@ checksum_die (DSO *dso, dw_cu_ref cu,
> > dw_die_ref top_die, dw_die_ref die)
> > die->die_no_multifile = 1;
> > ptr += 8;
> > break;
> > + case DW_FORM_data16:
> > + ptr += 16;
> > + break;
>
> Also, wonder if DW_FORM_ref_sig8 has a separate case from DW_FORM_data8, if
> it wouldn't be more readable to stick DW_FORM_data16 case below the
> DW_FORM_data8 one. When both are the same case, that isn't possible of course.
In the case of skip_attr_no_dw_form_indirect DW_FORM_ref8,
DW_FORM_data8 and DW_FORM_ref_sig8 are the same case (and
DW_FORM_data16 immediately follows that case), but in the case of
checksym_die they are different cases. I moved DW_FORM_data16 right
after DW_FORM_data8 in that case.
> Otherwise LGTM.
Thanks,
Mark
next prev parent reply other threads:[~2020-09-25 16:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-24 16:25 Read and write DWARF5 units and forms Mark Wielaard
2020-09-24 16:25 ` [PATCH 1/4] Calculate size and write correct DWARF5 header Mark Wielaard
2020-09-24 19:39 ` Jakub Jelinek
2020-09-25 16:35 ` Mark Wielaard
2020-09-25 16:39 ` Jakub Jelinek
2020-09-24 16:25 ` [PATCH 2/4] Handle DW_FORM_data16 Mark Wielaard
2020-09-24 19:43 ` Jakub Jelinek
2020-09-24 21:53 ` Jakub Jelinek
2020-09-25 16:42 ` Mark Wielaard [this message]
2020-09-24 16:25 ` [PATCH 3/4] Handle DW_FORM_line_strp by not moving DIE Mark Wielaard
2020-09-24 19:45 ` Jakub Jelinek
2020-09-24 16:25 ` [PATCH 4/4] Handle DW_FORM_implicit_const [experiment] Mark Wielaard
2020-09-24 19:57 ` Jakub Jelinek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c026637049d5466c49e947d6ecc6dfb2b51aae3c.camel@klomp.org \
--to=mark@klomp.org \
--cc=dwz@sourceware.org \
--cc=jakub@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).