public inbox for
 help / color / mirror / Atom feed
From: Jakub Jelinek <>
To: Mark Wielaard <>
Subject: Re: [PATCH 3/4] Handle DW_FORM_line_strp by not moving DIE.
Date: Thu, 24 Sep 2020 21:45:30 +0200	[thread overview]
Message-ID: <20200924194530.GQ2176@tucnak> (raw)
In-Reply-To: <>

On Thu, Sep 24, 2020 at 06:25:56PM +0200, Mark Wielaard wrote:
> DW_FORM_line_strp points into a new string table .debug_line_str.
> There is no supplemental .debug_line_str, so DIEs having a line_strp
> form attribute cannot be moved. This isn't really a problem because
> normally DW_FORM_line_strp is only used for file paths used in top-level
> DW_AT_name and DW_AT_comp_dir, which wouldn't be moved anyway.
> When we add support for DWARF5 line tables we might revise the decision
> to keep the DW_FORM_line_strp as is since it might be advantaguous move
> the dir table and file table strings into the supplemental file .debug_str
> section.
> 	* dwz.c (read_abbrev): Accept DW_FORM_line_strp.
> 	(skip_attr_no_dw_form_indirect): Handle DW_FORM_line_strp.
> 	(get_AT_string): Return string from DEBUG_LINE_STR for
> 	DW_FORM_line_strp.
> 	(checksum_die): Make DIE CK_BAD for DW_FORM_line_strp to prevent
> 	moving.
> 	(die_eq_1): Handle DW_FORM_line_strp.
> 	(mark_refs): Likewise.
> 	(read_debug_info): Likewise. Don't note string.
> 	(build_abbrevs_for_die): Handle DW_FORM_line_strp. Keep form as is.
> 	(write_unit_die): Write out DW_FORM_line_strp data.
> 	(write_die): Likewise.



  reply	other threads:[~2020-09-24 19:45 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-24 16:25 Read and write DWARF5 units and forms Mark Wielaard
2020-09-24 16:25 ` [PATCH 1/4] Calculate size and write correct DWARF5 header Mark Wielaard
2020-09-24 19:39   ` Jakub Jelinek
2020-09-25 16:35     ` Mark Wielaard
2020-09-25 16:39       ` Jakub Jelinek
2020-09-24 16:25 ` [PATCH 2/4] Handle DW_FORM_data16 Mark Wielaard
2020-09-24 19:43   ` Jakub Jelinek
2020-09-24 21:53     ` Jakub Jelinek
2020-09-25 16:42     ` Mark Wielaard
2020-09-24 16:25 ` [PATCH 3/4] Handle DW_FORM_line_strp by not moving DIE Mark Wielaard
2020-09-24 19:45   ` Jakub Jelinek [this message]
2020-09-24 16:25 ` [PATCH 4/4] Handle DW_FORM_implicit_const [experiment] Mark Wielaard
2020-09-24 19:57   ` Jakub Jelinek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200924194530.GQ2176@tucnak \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).