Re: [PATCH] Use xxHash hashing algorithm.

[Mark Wielaard <mark@klomp.org>]

Hi Martin,

On Mon, 2022-07-04 at 15:31 +0200, Martin Liška wrote:
> > Please take a look at the updated patch.
> > 
> > I read it again and it looks good to me.
> 
> Fine. Can I install the patch now or should we wait for a follow up
> patch that will come up with a proper configuration?

I think we can do the configure stuff later. We also should add a check
for libelf.

One last check. In theory dwz is arch independent, the result of
running dwz on a file should be the same whether it is done on a 32/64
bit or big/little-endian machine. To keep things reproducible the hash
should be the same across arches.

The xxhash documentation states: "hashes are identical across all
platforms (little / big endian)".

I assume the above holds, even on 32bit arches (we always use XXH64).

So unless you know that there are cases where the hash produces
different values on some arches then I'll say it is fine to install.

Thanks,

Mark