[Bug 1000701] New: Error building vectors.S for Thumb on ARM7TDMI targets

[Bug 1000701] New: Error building vectors.S for Thumb on ARM7TDMI targets

[bugzilla-daemon]

http://bugs.ecos.sourceware.org/show_bug.cgi?id=1000701

           Summary: Error building vectors.S for Thumb on ARM7TDMI targets
           Product: eCos
           Version: 3.0beta1
          Platform: Other (please specify)
        OS/Version: ARM
            Status: NEW
          Severity: major
          Priority: normal
         Component: HAL
        AssignedTo: jifl@ecoscentric.com
        ReportedBy: john@dallaway.org.uk
         QAContact: ecos-bugs@ecos.sourceware.org
             Class: ---



John Dallaway <john@dallaway.org.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |Blocking_3.0+


Attempting to build eCos for ARM7TDMI targets (eg eb40a) with CYGHWR_THUMB
enabled yields build errors in vectors.S:

make[1]: Entering directory `/var/tmp/eb40a-thumb/hal/arm/arch/v3_0b1'
arm-eabi-gcc -Wp,-MD,vectors.tmp  -I/var/tmp/eb40a-thumb/install/include
-I/opt/ecos/ecos-3.0b1/packages/hal/arm/arch/v3_0b1
-I/opt/ecos/ecos-3.0b1/packages/hal/arm/arch/v3_0b1/src
-I/opt/ecos/ecos-3.0b1/packages/hal/arm/arch/v3_0b1/tests -I.
-finline-limit=7000 -Wall -Wpointer-arith -Wstrict-prototypes -Wundef 
-Wno-write-strings -mthumb -mthumb-interwork -mcpu=arm7tdmi -g -O2
-ffunction-sections -fdata-sections  -fno-exceptions -c -o
/var/tmp/eb40a-thumb/install/lib/vectors.o
/opt/ecos/ecos-3.0b1/packages/hal/arm/arch/v3_0b1/src/vectors.S
/opt/ecos/ecos-3.0b1/packages/hal/arm/arch/v3_0b1/src/vectors.S: Assembler
messages:
/opt/ecos/ecos-3.0b1/packages/hal/arm/arch/v3_0b1/src/vectors.S:462: Error:
invalid immediate: 983040 is out of range
/opt/ecos/ecos-3.0b1/packages/hal/arm/arch/v3_0b1/src/vectors.S:462: Error:
value of 983040 too large for field of 2 bytes at 374
/opt/ecos/ecos-3.0b1/packages/hal/arm/arch/v3_0b1/src/vectors.S:462: Error:
invalid immediate: 196608 is out of range
/opt/ecos/ecos-3.0b1/packages/hal/arm/arch/v3_0b1/src/vectors.S:462: Error:
value of 196608 too large for field of 2 bytes at 378
/opt/ecos/ecos-3.0b1/packages/hal/arm/arch/v3_0b1/src/vectors.S:492: Error:
invalid immediate: 983040 is out of range
/opt/ecos/ecos-3.0b1/packages/hal/arm/arch/v3_0b1/src/vectors.S:492: Error:
value of 983040 too large for field of 2 bytes at 392
/opt/ecos/ecos-3.0b1/packages/hal/arm/arch/v3_0b1/src/vectors.S:492: Error:
invalid immediate: 131072 is out of range
/opt/ecos/ecos-3.0b1/packages/hal/arm/arch/v3_0b1/src/vectors.S:492: Error:
value of 131072 too large for field of 2 bytes at 396
/opt/ecos/ecos-3.0b1/packages/hal/arm/arch/v3_0b1/src/vectors.S:497: Error:
invalid immediate: 983040 is out of range
/opt/ecos/ecos-3.0b1/packages/hal/arm/arch/v3_0b1/src/vectors.S:497: Error:
value of 983040 too large for field of 2 bytes at 406
/opt/ecos/ecos-3.0b1/packages/hal/arm/arch/v3_0b1/src/vectors.S:497: Error:
invalid immediate: 65536 is out of range
/opt/ecos/ecos-3.0b1/packages/hal/arm/arch/v3_0b1/src/vectors.S:497: Error:
value of 65536 too large for field of 2 bytes at 410
make[1]: *** [/var/tmp/eb40a-thumb/install/lib/vectors.o] Error 1
make[1]: Leaving directory `/var/tmp/eb40a-thumb/hal/arm/arch/v3_0b1'
make: *** [build] Error 2

Thumb support is important for small memory targets so I've marked this as
blocking for eCos 3.0 on the assumption that the effort to fix is not huge.


-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.

[Bug 1000701] Error building vectors.S for Thumb on AT91 targets

[bugzilla-daemon]

http://bugs.ecos.sourceware.org/show_bug.cgi?id=1000701


John Dallaway <john@dallaway.org.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Error building vectors.S for|Error building vectors.S for
                   |Thumb on ARM7TDMI targets   |Thumb on AT91 targets




--- Comment #1 from John Dallaway <john@dallaway.org.uk>  2009-03-19 15:09:34 ---
Jifl advises that this issue affects AT91 targets only but is, nevertheless,
important to fix. I am updating the summary field accordingly.


-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.

[Bug 1000701] Error building vectors.S for Thumb on AT91 targets

[bugzilla-daemon]

http://bugs.ecos.sourceware.org/show_bug.cgi?id=1000701





--- Comment #2 from John Dallaway <john@dallaway.org.uk>  2009-03-23 13:09:27 ---
In fact, only the AT91EB4x platforms appear to be affected. I have very little
experience of ARM assembler but it would appear that we can simply replace (for
example):

   mov r1,#0x000F0000

with:

   ldr r1,=0x000F0000

which should work for both ARM and Thumb builds. Correct?


-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.

[Issue 1000701] Error building vectors.S for Thumb on AT91 targets

[bugzilla-daemon]

http://bugs.ecos.sourceware.org/show_bug.cgi?id=1000701


Nick Garnett <nickg@ecoscentric.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nickg@ecoscentric.com




--- Comment #3 from Nick Garnett <nickg@ecoscentric.com>  2009-03-23 14:10:06 ---
For eCosPro we converted all those mov's to use the following macro:

        .macro  ldrc reg,val
#ifdef __thumb__
        ldr     \reg,=\val
#else
        mov     \reg,#\val
#endif
        .endm

However, I believe that the assembler will convert an ldr into an equivalent
mov if it can, so in theory just using ldr should be OK.


Note that other changes may be needed to get thumb working on some of the older
targets where thumb support was never fully tested.


-- 
Configure issuemail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the issue.

[Bug 1000701] Error building vectors.S for Thumb on AT91 targets

[bugzilla-daemon]

http://bugs.ecos.sourceware.org/show_bug.cgi?id=1000701


John Dallaway <john@dallaway.org.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|jifl@ecoscentric.com        |john@dallaway.org.uk




--- Comment #4 from John Dallaway <john@dallaway.org.uk>  2009-03-23 15:51:05 ---
(In reply to comment #3)

> For eCosPro we converted all those mov's to use the following macro:
> 
>         .macro  ldrc reg,val
> #ifdef __thumb__
>         ldr     \reg,=\val
> #else
>         mov     \reg,#\val
> #endif
>         .endm

Thanks for the info, Nick.

> However, I believe that the assembler will convert an ldr into an equivalent
> mov if it can, so in theory just using ldr should be OK.

Yes, that was my understanding from the documentation I found. I will perform
the substitution in the AT91EBxx LED macros as described in comment #2.


-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.

[Bug 1000701] Error building vectors.S for Thumb on AT91 targets

[bugzilla-daemon]

http://bugs.ecos.sourceware.org/show_bug.cgi?id=1000701





--- Comment #5 from John Dallaway <john@dallaway.org.uk>  2009-03-23 17:17:18 ---
Created an attachment (id=681)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=681)
ebxx-led-090323.patch

Accommodate building of eb40a, eb42 and eb55 LED manipulation routines for
Thumb


-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.

[Bug 1000701] Error building vectors.S for Thumb on AT91 targets

[bugzilla-daemon]

http://bugs.ecos.sourceware.org/show_bug.cgi?id=1000701


John Dallaway <john@dallaway.org.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |CURRENTRELEASE




--- Comment #6 from John Dallaway <john@dallaway.org.uk>  2009-03-23 17:22:09 ---
Patch checked in on repository trunk and eCos 3.0 branch.


-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.