[Bug 1000717] New: lwIP TCP/IP drops incoming IP packets on SLIP interface

[Bug 1000717] New: lwIP TCP/IP drops incoming IP packets on SLIP interface

[bugzilla-daemon]

http://bugs.ecos.sourceware.org/show_bug.cgi?id=1000717

           Summary: lwIP TCP/IP drops incoming IP packets on SLIP interface
           Product: eCos
           Version: 3.0beta1
          Platform: Other (please specify)
        OS/Version: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: normal
         Component: TCP/IP
        AssignedTo: gary@mlbassoc.com
        ReportedBy: sergei.gavrikov@gmail.com
         QAContact: ecos-bugs@ecos.sourceware.org
             Class: ---


Created an attachment (id=670)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=670)
slipif.c patch

Today I tried 'lwip_ppp' template (ecos.ecc was tuned to handle SLIP interface)
and I found that slipif_init() cleared netif->flags (reset NETIF_FLAG_UP),
perhaps, this is normal for PPP mode, but when I ran lwip_tcpip tests on SLIP
interface I got on every right incoming IP input the LWIP debug message:

ip_input: packet not for us.

The check

    if ((netif_is_up(netif)) && (!ip_addr_isany(&(netif->ip_addr))))

found no UP interface, because NETIF_FLAG_UP has been already cleaned by
slipif_init()...

With a 1-line tweak (see the patch) all tests become to work just fine.

FYI: I referred with latest lwIP sources (1.3) and found no any wrap in the
place for the SLIP mode.

Can anybody confirm the issue?

Thanks,

Sergei


-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.

[Bug 1000717] lwIP TCP/IP drops incoming IP packets on SLIP interface

[bugzilla-daemon]

http://bugs.ecos.sourceware.org/show_bug.cgi?id=1000717





--- Comment #1 from Sergei Gavrikov <sergei.gavrikov@gmail.com>  2009-03-12 14:08:31 ---
Created an attachment (id=671)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=671)
minimal ECM to make lwIP SLIP interface to spin

For a reference I add ECM file which shows the 'user settings'. I worked with
lpc2xxx target and test lwIP stack in GDB on UART0. SLIP interface had been set
up for LPC2214 UART1 serial port. 


-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.

[Bug 1000717] lwIP TCP/IP drops incoming IP packets on SLIP interface

[bugzilla-daemon]

http://bugs.ecos.sourceware.org/show_bug.cgi?id=1000717


Sergei Gavrikov <sergei.gavrikov@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #670 is|0                           |1
           obsolete|                            |




--- Comment #2 from Sergei Gavrikov <sergei.gavrikov@gmail.com>  2009-03-12 15:20:11 ---
Created an attachment (id=672)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=672)
slipif.c patch

Ups. At the first, the patch was a really one line tweak. An entered the 'ifdef
LWIP_SLIP' was an extra an odd check. The LWIP_SLIP is not defined there.
Please, use this patch.


-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.

[Bug 1000717] lwIP TCP/IP drops incoming IP packets on SLIP interface

[bugzilla-daemon]

http://bugs.ecos.sourceware.org/show_bug.cgi?id=1000717





--- Comment #3 from Sergei Gavrikov <sergei.gavrikov@gmail.com>  2009-03-14 14:31:30 ---
Created an attachment (id=674)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=674)
To up lwIP SLIP on eCos serial device are configured for a non-blocking mode

I forgot to mention that lwip's ecos/sio.c is broken. It open a serial device
in non-blocking mode. Well, it's a good idea. But, unfortunately, sio_write(),
sio_read(), sio_send() and sio_recv() are implemented to work in the blocking
mode only. U.T.S.L. All functions do not care about EAGAIN. All routines are
just the producers of a garbage. SLIP interface does not/will not work.

I tweaked those sio functions to make them work in the non-blocking mode (see a
patch).

I tested SLIP on Ubuntu with olpce2294 using 'slattach' at 115200 bps. eCos
tests: 'tcpecho' and 'httpd' are built using 'lwip_template' work smoothly over
serial interface. I not used RTSCTS flow control (stty -crtscts ...).

The below is just a demo from GNU screen session ('echo' and 'pinging' are
invoked simultaneously at sl0).

~$ while [ 1 ];do echo `date +%s`|socat - tcp4:192.168.1.222:7;sleep 1;done
1237039723
1237039724
1237039725
1237039726
1237039727
1237039728
1237039729
----------------------------------------------------------
~$ ping -A 192.168.1.222
PING 192.168.1.222 (192.168.1.222) 56(84) bytes of data.
64 bytes from 192.168.1.222: icmp_seq=1 ttl=64 time=68.6 ms
64 bytes from 192.168.1.222: icmp_seq=2 ttl=64 time=35.9 ms
64 bytes from 192.168.1.222: icmp_seq=3 ttl=64 time=35.9 ms
64 bytes from 192.168.1.222: icmp_seq=4 ttl=64 time=39.9 ms
64 bytes from 192.168.1.222: icmp_seq=5 ttl=64 time=35.9 ms
64 bytes from 192.168.1.222: icmp_seq=6 ttl=64 time=35.9 ms

Sergei


-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.

[Bug 1000717] lwIP TCP/IP drops incoming IP packets on SLIP interface

[bugzilla-daemon]

http://bugs.ecos.sourceware.org/show_bug.cgi?id=1000717


John Dallaway <john@dallaway.org.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |CURRENTRELEASE




--- Comment #4 from John Dallaway <john@dallaway.org.uk>  2009-03-25 08:43:19 ---
Thank your for the patch. Now checked in to the repository trunk and eCos 3.0
branch.


-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.