[Bug 1000766] New: Error compiling if_lancepci.c on i386 PC target (vmWare)

[Bug 1000766] New: Error compiling if_lancepci.c on i386 PC target (vmWare)

[bugzilla-daemon]

http://bugs.ecos.sourceware.org/show_bug.cgi?id=1000766

           Summary: Error compiling if_lancepci.c on i386 PC target (vmWare)
           Product: eCos
           Version: 3.0
          Platform: Other (please specify)
        OS/Version: HostOS: Win NT/2k/XP
            Status: UNCONFIRMED
          Severity: normal
          Priority: normal
         Component: RedBoot
        AssignedTo: gary@mlbassoc.com
        ReportedBy: bd1es@hotmail.com
         QAContact: ecos-bugs@ecos.sourceware.org
             Class: ---


Created an attachment (id=721)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=721)
Error compiling if_lancepci.c

Overview:
File if_lancepci.c cannot be compiled correctly while building redboot form
template i386 PC target (vmWare).

Steps to Reproduce:
1. Open configtool.exe
2. From menu Build->Templates to select: Hardware=i386 PC target (vmWare),
Packages=redboot
3. From menu File->Import to select:
C:\cygwin\opt\ecos\ecos-3.0\packages\hal\i386\pc\v3_0\misc\redboot_FLOPPY.ecm
4. Uncheck in Configuration tree: Redboot ROM Monitor/Build Redboot ROM ELF
image/Allow RedBoot to support disks. (This step is not necessory)
5. Save the configuration file redboot.ecc, start image building.
6. Will get the error message when if_lancepci.c is going to be compiled, and
the redboot image cannot be generated.

Actual Results:
The error messages are:
make -r -C devs/eth/amd/lancepci/v3_0 build
make[1]: Entering directory
`/cygdrive/c/U94/untitled_build/devs/eth/amd/lancepci/v3_0'
i386-elf-gcc -c  -I/cygdrive/c/U94/untitled_install/include
-I/opt/ecos/ecos-3.0/packages/devs/eth/amd/lancepci/v3_0
-I/opt/ecos/ecos-3.0/packages/devs/eth/amd/lancepci/v3_0/src
-I/opt/ecos/ecos-3.0/packages/devs/eth/amd/lancepci/v3_0/tests -I.
-I/opt/ecos/ecos-3.0/packages/devs/eth/amd/lancepci/v3_0/src/
-finline-limit=7000 -Wall -Wpointer-arith -Wstrict-prototypes -Wundef 
-Wno-write-strings -g -O2 -ffunction-sections -fdata-sections  -fno-exceptions
-D_KERNEL -D__ECOS -Wp,-MD,src/if_lancepci.tmp -o
src/devs_eth_amd_lancepci_if_lancepci.o
/opt/ecos/ecos-3.0/packages/devs/eth/amd/lancepci/v3_0/src/if_lancepci.c
make[1]: Leaving directory
`/cygdrive/c/U94/untitled_build/devs/eth/amd/lancepci/v3_0'
In file included from
/opt/ecos/ecos-3.0/packages/devs/eth/amd/lancepci/v3_0/src/if_lancepci.c:117:
make: Leaving directory `/cygdrive/c/U94/untitled_build'
/cygdrive/c/U94/untitled_install/include/cyg/io/devs_eth_i386_pc_lancepci.inl:94:
error: expected '}' before numeric constant
/opt/ecos/ecos-3.0/packages/devs/eth/amd/lancepci/v3_0/src/if_lancepci.c: In
function 'pci_init_find_lancepci':
/opt/ecos/ecos-3.0/packages/devs/eth/amd/lancepci/v3_0/src/if_lancepci.c:338:
warning: pointer targets in passing argument 2 of 'cyg_pci_translate_interrupt'
differ in signedness
/opt/ecos/ecos-3.0/packages/devs/eth/amd/lancepci/v3_0/src/if_lancepci.c: In
function 'amd_lancepci_init':
/opt/ecos/ecos-3.0/packages/devs/eth/amd/lancepci/v3_0/src/if_lancepci.c:528:
error: lvalue required as left operand of assignment
/opt/ecos/ecos-3.0/packages/devs/eth/amd/lancepci/v3_0/src/if_lancepci.c:541:
error: lvalue required as left operand of assignment
/opt/ecos/ecos-3.0/packages/devs/eth/amd/lancepci/v3_0/src/if_lancepci.c:556:
error: lvalue required as left operand of assignment
/opt/ecos/ecos-3.0/packages/devs/eth/amd/lancepci/v3_0/src/if_lancepci.c:559:
error: lvalue required as left operand of assignment
/opt/ecos/ecos-3.0/packages/devs/eth/amd/lancepci/v3_0/src/if_lancepci.c:589:
error: lvalue required as left operand of assignment
/opt/ecos/ecos-3.0/packages/devs/eth/amd/lancepci/v3_0/src/if_lancepci.c: In
function 'lancepci_start':
/opt/ecos/ecos-3.0/packages/devs/eth/amd/lancepci/v3_0/src/if_lancepci.c:733:
error: lvalue required as left operand of assignment
/opt/ecos/ecos-3.0/packages/devs/eth/amd/lancepci/v3_0/src/if_lancepci.c: In
function 'lancepci_send':
/opt/ecos/ecos-3.0/packages/devs/eth/amd/lancepci/v3_0/src/if_lancepci.c:969:
error: lvalue required as left operand of assignment
make[1]: *** [src/if_lancepci.o.d] Error 1
make: *** [build] Error 2

Additional Information:
This error can be reproduced in each time when selecting AMD ether net adapter
on PC platform. It seems the definition of macro HAL_PCI_CPU_TO_BUS had some
problem, or the include file devs_eth_i386_pc_lancepci.inl was not generated
correctly.


-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.

[Bug 1000766] Error compiling if_lancepci.c on i386 PC target (vmWare)

[bugzilla-daemon]

http://bugs.ecos.sourceware.org/show_bug.cgi?id=1000766


Stanislav Meduna <stano@meduna.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |stano@meduna.org




--- Comment #1 from Stanislav Meduna <stano@meduna.org>  2009-05-24 13:07:20 ---
Seen here too. Removing the casts of the second HAL_PCI_CPU_TO_BUS argument
turns the errors into warnings and the compiled application works.


-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.

[Bug 1000766] Error compiling if_lancepci.c on i386 PC target (vmWare)

[bugzilla-daemon]

http://bugs.ecos.sourceware.org/show_bug.cgi?id=1000766


John Dallaway <john@dallaway.org.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|gary@mlbassoc.com           |john@dallaway.org.uk




--- Comment #2 from John Dallaway <john@dallaway.org.uk>  2009-05-25 20:23:02 ---
Thank you for the bug report.

Compare with devs/eth/via/rhine/v3_0/src/if_rhine.c where the first parameter
of each call to HAL_PCI_CPU_TO_BUS() is cast to a cyg_uint32.

I will fix this.


-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.

[Bug 1000766] Error compiling if_lancepci.c on i386 PC target (vmWare)

[bugzilla-daemon]

http://bugs.ecos.sourceware.org/show_bug.cgi?id=1000766





--- Comment #3 from John Dallaway <john@dallaway.org.uk>  2009-05-25 20:34:54 ---
Created an attachment (id=743)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=743)
bugzilla-1000766.patch

Fix for reported build error.


-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.

[Bug 1000766] Error compiling if_lancepci.c on i386 PC target (vmWare)

[bugzilla-daemon]

http://bugs.ecos.sourceware.org/show_bug.cgi?id=1000766


John Dallaway <john@dallaway.org.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |CURRENTRELEASE




--- Comment #4 from John Dallaway <john@dallaway.org.uk>  2009-05-25 20:37:06 ---
Patch checked-in.


-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.