public inbox for ecos-bugs@sourceware.org
help / color / mirror / Atom feed
From: bugzilla-daemon@bugs.ecos.sourceware.org
To: ecos-bugs@ecos.sourceware.org
Subject: [Bug 1001068] Bug in serial driver when using Parity (Even or Odd)
Date: Mon, 22 Nov 2010 09:43:00 -0000 [thread overview]
Message-ID: <20101122093500.8F8E32F78008@mail.ecoscentric.com> (raw)
In-Reply-To: <bug-1001068-13@http.bugs.ecos.sourceware.org/>
Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001068
John Dallaway <john@dallaway.org.uk> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |NEEDINFO
CC| |john@dallaway.org.uk
AssignedTo|unassigned@bugs.ecos.source |john@dallaway.org.uk
|ware.org |
Ever Confirmed|0 |1
--- Comment #1 from John Dallaway <john@dallaway.org.uk> 2010-11-22 09:34:58 GMT ---
Phil, thank you for the bug report. Your proposed fix does not accommodate the
STM32 7 data bits + parity bit mode (where the M bit should be clear).
In effect, STM32 requires the word length to be specified inclusive of the
parity bit. Since the word length is represented by a single bit only, I
suggest we abandon the select_word_length array and calculate word_length in
stm32_serial_config_port() as follows:
cyg_uint32 word_length =
((new_config->word_length == CYGNUM_SERIAL_WORD_LENGTH_8) &&
(new_config->parity != CYGNUM_SERIAL_PARITY_NONE)) ?
CYGHWR_HAL_STM32_UART_CR1_M_9 : CYGHWR_HAL_STM32_UART_CR1_M_8;
Do you concur?
--
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
next prev parent reply other threads:[~2010-11-22 9:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-04 20:51 [Bug 1001068] New: " bugzilla-daemon
2010-11-22 9:43 ` bugzilla-daemon [this message]
2010-12-21 19:38 ` [Bug 1001068] " bugzilla-daemon
2010-12-31 9:40 ` bugzilla-daemon
2013-02-02 20:43 ` bugzilla-daemon
-- strict thread matches above, loose matches on Subject: below --
2010-11-04 20:51 [Bug 1001068] New: " bugzilla-daemon
2010-11-22 9:35 ` [Bug 1001068] " bugzilla-daemon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101122093500.8F8E32F78008@mail.ecoscentric.com \
--to=bugzilla-daemon@bugs.ecos.sourceware.org \
--cc=ecos-bugs@ecos.sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).