public inbox for ecos-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug 1001117] New: Cortex-M architecture fixes.
@ 2011-01-15 20:42 bugzilla-daemon
  2011-01-16  8:54 ` [Bug 1001117] " bugzilla-daemon
                   ` (8 more replies)
  0 siblings, 9 replies; 15+ messages in thread
From: bugzilla-daemon @ 2011-01-15 20:42 UTC (permalink / raw)
  To: unassigned

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001117

           Summary: Cortex-M architecture fixes.
           Product: eCos
           Version: CVS
          Platform: Other (please specify)
        OS/Version: Cortex-M
            Status: UNCONFIRMED
          Severity: enhancement
          Priority: low
         Component: HAL
        AssignedTo: unassigned@bugs.ecos.sourceware.org
        ReportedBy: ilijak@siva.com.mk
                CC: ecos-bugs@ecos.sourceware.org
             Class: Advice Request


Created an attachment (id=1083)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1083)
VTOR and SysTick fixes for override.

In current Cortex-M architecture port some macros are defined in architecture
headers without possibility for overriding by variant and/or platform.

1. Vector Table Offset Register - VTOR

CYGARC_REG_NVIC_VTOR_TBLBASE_SRAM places VTOR at beginning of SRAM 0x20000000
following ARM guides. However, already there are devices with no memoru at this
address such as LPC17XX BUG #1001114

Solution: Conditional define of CYGARC_REG_NVIC_VTOR_TBLBASE_SRAM that allows
for override.

2. SysTick

SysTick setting uses exclusively external clock. Definition ext. vs int. seem
to be the chip vendor/designer "prerogative" so we need flexibility.
Also the definitions of CYGARC_REG_SYSTICK_CSR_CLK_EXT and
CYGARC_REG_SYSTICK_CSR_CLK_INT seem too complicated.

Solution: New macro CYGARC_REG_SYSTICK_CSR_CLK_SRC and CDL for SysTick clock
source selection. CYGARC_REG_SYSTICK_CSR_CLK_EXT and
CYGARC_REG_SYSTICK_CSR_CLK_INT defines made explicit.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


^ permalink raw reply	[flat|nested] 15+ messages in thread
* [Bug 1001117] Cortex-M architecture fixes.
  2011-01-15 20:42 [Bug 1001117] New: Cortex-M architecture fixes bugzilla-daemon
@ 2011-01-16  8:54 ` bugzilla-daemon
  2011-01-16 10:21 ` bugzilla-daemon
                   ` (7 subsequent siblings)
  8 siblings, 0 replies; 15+ messages in thread
From: bugzilla-daemon @ 2011-01-16  8:54 UTC (permalink / raw)
  To: unassigned

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001117

John Dallaway <john@dallaway.org.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ecos-patches@ecos.sourcewar
                   |                            |e.org, john@dallaway.org.uk
          Component|HAL                         |Patches and contributions

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


^ permalink raw reply	[flat|nested] 15+ messages in thread
* [Bug 1001117] Cortex-M architecture fixes.
  2011-01-15 20:42 [Bug 1001117] New: Cortex-M architecture fixes bugzilla-daemon
  2011-01-16  8:54 ` [Bug 1001117] " bugzilla-daemon
@ 2011-01-16 10:21 ` bugzilla-daemon
  2011-01-16 14:06 ` bugzilla-daemon
                   ` (6 subsequent siblings)
  8 siblings, 0 replies; 15+ messages in thread
From: bugzilla-daemon @ 2011-01-16 10:21 UTC (permalink / raw)
  To: unassigned

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001117

Christophe Coutand <ecos@hotmail.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ecos@hotmail.co.uk

--- Comment #1 from Christophe Coutand <ecos@hotmail.co.uk> 2011-01-16 10:21:01 GMT ---
Hi Ilija,

I made a patch for the system tick clock source some time ago: Bug 1001090 .

Your patch seems to change the default behavior of the cortex M HAL:

#1 CSR is initialised with CYGARC_REG_SYSTICK_CSR_TICKINT so you are enabling
the interrupt.

#2 Definition of CYGARC_REG_SYSTICK_CSR_CLK_EXT and
CYGARC_REG_SYSTICK_CSR_CLK_INT was originally correct, your new definition is
more difficult to understand. When CYGARC_REG_SYSTICK_CSR_CLK_SRC is not
defined in CDLs, the clock source equal CYGARC_REG_SYSTICK_CSR_CLK_INT which
actually makes the processor use external clock while by reading the code one
might think that the processor should use internal clock.

+#if !defined CYGARC_REG_SYSTICK_CSR_CLK_SRC
+#define CYGARC_REG_SYSTICK_CSR_CLK_SRC CYGARC_REG_SYSTICK_CSR_CLK_INT
+#endif

Christophe

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


^ permalink raw reply	[flat|nested] 15+ messages in thread
* [Bug 1001117] Cortex-M architecture fixes.
  2011-01-15 20:42 [Bug 1001117] New: Cortex-M architecture fixes bugzilla-daemon
  2011-01-16  8:54 ` [Bug 1001117] " bugzilla-daemon
  2011-01-16 10:21 ` bugzilla-daemon
@ 2011-01-16 14:06 ` bugzilla-daemon
  2011-01-16 14:15 ` bugzilla-daemon
                   ` (5 subsequent siblings)
  8 siblings, 0 replies; 15+ messages in thread
From: bugzilla-daemon @ 2011-01-16 14:06 UTC (permalink / raw)
  To: unassigned

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001117

--- Comment #2 from Ilija Kocho <ilijak@siva.com.mk> 2011-01-16 14:06:08 GMT ---
Hi Christophe

You seem to be right on both points. #1 should not be here and #2 is simply
swapped sources, shame on me :( .

Since you already have the Bug 1001090 let's continue discussion on SysTick
there. Also, considering that you are working on a yet another platform,
Stellaris,we could share some info on eventual similar Cortex-M architecture
issues and try to synchronize action.

Regarding this bug, I am going to put a patch that covers VTOR only.

Ilija

(In reply to comment #1)
> Hi Ilija,
> 
> I made a patch for the system tick clock source some time ago: Bug 1001090 .
> 
> Your patch seems to change the default behavior of the cortex M HAL:
> 
> #1 CSR is initialised with CYGARC_REG_SYSTICK_CSR_TICKINT so you are enabling
> the interrupt.
> 
> #2 Definition of CYGARC_REG_SYSTICK_CSR_CLK_EXT and
> CYGARC_REG_SYSTICK_CSR_CLK_INT was originally correct, your new definition is
> more difficult to understand. When CYGARC_REG_SYSTICK_CSR_CLK_SRC is not
> defined in CDLs, the clock source equal CYGARC_REG_SYSTICK_CSR_CLK_INT which
> actually makes the processor use external clock while by reading the code one
> might think that the processor should use internal clock.
> 
> +#if !defined CYGARC_REG_SYSTICK_CSR_CLK_SRC
> +#define CYGARC_REG_SYSTICK_CSR_CLK_SRC CYGARC_REG_SYSTICK_CSR_CLK_INT
> +#endif
> 
> Christophe

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


^ permalink raw reply	[flat|nested] 15+ messages in thread
* [Bug 1001117] Cortex-M architecture fixes.
  2011-01-15 20:42 [Bug 1001117] New: Cortex-M architecture fixes bugzilla-daemon
                   ` (2 preceding siblings ...)
  2011-01-16 14:06 ` bugzilla-daemon
@ 2011-01-16 14:15 ` bugzilla-daemon
  2011-01-17  8:30 ` [Bug 1001117] Cortex-M arch. Provision for overriding of VTOR setting bugzilla-daemon
                   ` (4 subsequent siblings)
  8 siblings, 0 replies; 15+ messages in thread
From: bugzilla-daemon @ 2011-01-16 14:15 UTC (permalink / raw)
  To: unassigned

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001117

Ilija Kocho <ilijak@siva.com.mk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1083|0                           |1
        is obsolete|                            |

--- Comment #3 from Ilija Kocho <ilijak@siva.com.mk> 2011-01-16 14:15:16 GMT ---
Created an attachment (id=1085)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1085)
VTOR option for overriding of Vector Table Offset.

This patch addresses Cristophe's comment. Removed SysTick entries, now only
covers VTOR issue.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


^ permalink raw reply	[flat|nested] 15+ messages in thread
* [Bug 1001117] Cortex-M arch. Provision for overriding of VTOR setting.
  2011-01-15 20:42 [Bug 1001117] New: Cortex-M architecture fixes bugzilla-daemon
                   ` (3 preceding siblings ...)
  2011-01-16 14:15 ` bugzilla-daemon
@ 2011-01-17  8:30 ` bugzilla-daemon
  2011-01-17 21:32 ` bugzilla-daemon
                   ` (3 subsequent siblings)
  8 siblings, 0 replies; 15+ messages in thread
From: bugzilla-daemon @ 2011-01-17  8:30 UTC (permalink / raw)
  To: unassigned

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001117

Ilija Kocho <ilijak@siva.com.mk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Cortex-M architecture       |Cortex-M arch. Provision
                   |fixes.                      |for overriding of VTOR
                   |                            |setting.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


^ permalink raw reply	[flat|nested] 15+ messages in thread
* [Bug 1001117] Cortex-M arch. Provision for overriding of VTOR setting.
  2011-01-15 20:42 [Bug 1001117] New: Cortex-M architecture fixes bugzilla-daemon
                   ` (4 preceding siblings ...)
  2011-01-17  8:30 ` [Bug 1001117] Cortex-M arch. Provision for overriding of VTOR setting bugzilla-daemon
@ 2011-01-17 21:32 ` bugzilla-daemon
  2011-01-18  2:00 ` bugzilla-daemon
                   ` (2 subsequent siblings)
  8 siblings, 0 replies; 15+ messages in thread
From: bugzilla-daemon @ 2011-01-17 21:32 UTC (permalink / raw)
  To: unassigned

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001117

Sergei Gavrikov <sergei.gavrikov@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sergei.gavrikov@gmail.com

--- Comment #4 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2011-01-17 21:32:30 GMT ---
Ilija, your argument about protection the VTOR placement is clear. The patch
looks good for me. If nobody have doubts I plan to apply it.

[OFF-TOPIC]

Iljia, I noticed that you stick on the 'defined' operator
http://gcc.gnu.org/onlinedocs/cpp/Defined.html#Defined
It is curious why do not use ifdef/ifndef in proper places?

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


^ permalink raw reply	[flat|nested] 15+ messages in thread
* [Bug 1001117] Cortex-M arch. Provision for overriding of VTOR setting.
  2011-01-15 20:42 [Bug 1001117] New: Cortex-M architecture fixes bugzilla-daemon
                   ` (5 preceding siblings ...)
  2011-01-17 21:32 ` bugzilla-daemon
@ 2011-01-18  2:00 ` bugzilla-daemon
  2011-01-19 19:00 ` bugzilla-daemon
  2011-01-19 19:02 ` bugzilla-daemon
  8 siblings, 0 replies; 15+ messages in thread
From: bugzilla-daemon @ 2011-01-18  2:00 UTC (permalink / raw)
  To: unassigned

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001117

Ilija Kocho <ilijak@siva.com.mk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |1001114

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


^ permalink raw reply	[flat|nested] 15+ messages in thread
* [Bug 1001117] Cortex-M arch. Provision for overriding of VTOR setting.
  2011-01-15 20:42 [Bug 1001117] New: Cortex-M architecture fixes bugzilla-daemon
                   ` (6 preceding siblings ...)
  2011-01-18  2:00 ` bugzilla-daemon
@ 2011-01-19 19:00 ` bugzilla-daemon
  2011-01-19 19:02 ` bugzilla-daemon
  8 siblings, 0 replies; 15+ messages in thread
From: bugzilla-daemon @ 2011-01-19 19:00 UTC (permalink / raw)
  To: unassigned

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001117

--- Comment #5 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2011-01-19 19:00:26 GMT ---
Checked-in. Ilija, Christophe, thanks you both.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


^ permalink raw reply	[flat|nested] 15+ messages in thread
* [Bug 1001117] Cortex-M arch. Provision for overriding of VTOR setting.
  2011-01-15 20:42 [Bug 1001117] New: Cortex-M architecture fixes bugzilla-daemon
                   ` (7 preceding siblings ...)
  2011-01-19 19:00 ` bugzilla-daemon
@ 2011-01-19 19:02 ` bugzilla-daemon
  8 siblings, 0 replies; 15+ messages in thread
From: bugzilla-daemon @ 2011-01-19 19:02 UTC (permalink / raw)
  To: unassigned

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001117

Sergei Gavrikov <sergei.gavrikov@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |CURRENTRELEASE

--- Comment #6 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2011-01-19 19:02:04 GMT ---
Mark as RESOLVED.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


^ permalink raw reply	[flat|nested] 15+ messages in thread
* [Bug 1001117] Cortex-M arch. Provision for overriding of VTOR setting.
  2011-01-15 20:42 [Bug 1001117] New: Cortex-M architecture fixes bugzilla-daemon
                   ` (3 preceding siblings ...)
  2011-01-19 19:00 ` bugzilla-daemon
@ 2011-01-19 19:02 ` bugzilla-daemon
  4 siblings, 0 replies; 15+ messages in thread
From: bugzilla-daemon @ 2011-01-19 19:02 UTC (permalink / raw)
  To: ecos-bugs

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001117

Sergei Gavrikov <sergei.gavrikov@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |CURRENTRELEASE

--- Comment #6 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2011-01-19 19:02:04 GMT ---
Mark as RESOLVED.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.


^ permalink raw reply	[flat|nested] 15+ messages in thread
* [Bug 1001117] Cortex-M arch. Provision for overriding of VTOR setting.
  2011-01-15 20:42 [Bug 1001117] New: Cortex-M architecture fixes bugzilla-daemon
                   ` (2 preceding siblings ...)
  2011-01-18  2:31 ` bugzilla-daemon
@ 2011-01-19 19:00 ` bugzilla-daemon
  2011-01-19 19:02 ` bugzilla-daemon
  4 siblings, 0 replies; 15+ messages in thread
From: bugzilla-daemon @ 2011-01-19 19:00 UTC (permalink / raw)
  To: ecos-bugs

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001117

--- Comment #5 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2011-01-19 19:00:26 GMT ---
Checked-in. Ilija, Christophe, thanks you both.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.


^ permalink raw reply	[flat|nested] 15+ messages in thread
* [Bug 1001117] Cortex-M arch. Provision for overriding of VTOR setting.
  2011-01-15 20:42 [Bug 1001117] New: Cortex-M architecture fixes bugzilla-daemon
  2011-01-17  8:29 ` [Bug 1001117] Cortex-M arch. Provision for overriding of VTOR setting bugzilla-daemon
  2011-01-17 21:32 ` bugzilla-daemon
@ 2011-01-18  2:31 ` bugzilla-daemon
  2011-01-19 19:00 ` bugzilla-daemon
  2011-01-19 19:02 ` bugzilla-daemon
  4 siblings, 0 replies; 15+ messages in thread
From: bugzilla-daemon @ 2011-01-18  2:31 UTC (permalink / raw)
  To: ecos-bugs

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001117

Ilija Kocho <ilijak@siva.com.mk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |1001114

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.


^ permalink raw reply	[flat|nested] 15+ messages in thread
* [Bug 1001117] Cortex-M arch. Provision for overriding of VTOR setting.
  2011-01-15 20:42 [Bug 1001117] New: Cortex-M architecture fixes bugzilla-daemon
  2011-01-17  8:29 ` [Bug 1001117] Cortex-M arch. Provision for overriding of VTOR setting bugzilla-daemon
@ 2011-01-17 21:32 ` bugzilla-daemon
  2011-01-18  2:31 ` bugzilla-daemon
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 15+ messages in thread
From: bugzilla-daemon @ 2011-01-17 21:32 UTC (permalink / raw)
  To: ecos-bugs

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001117

Sergei Gavrikov <sergei.gavrikov@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sergei.gavrikov@gmail.com

--- Comment #4 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2011-01-17 21:32:30 GMT ---
Ilija, your argument about protection the VTOR placement is clear. The patch
looks good for me. If nobody have doubts I plan to apply it.

[OFF-TOPIC]

Iljia, I noticed that you stick on the 'defined' operator
http://gcc.gnu.org/onlinedocs/cpp/Defined.html#Defined
It is curious why do not use ifdef/ifndef in proper places?

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.


^ permalink raw reply	[flat|nested] 15+ messages in thread
* [Bug 1001117] Cortex-M arch. Provision for overriding of VTOR setting.
  2011-01-15 20:42 [Bug 1001117] New: Cortex-M architecture fixes bugzilla-daemon
@ 2011-01-17  8:29 ` bugzilla-daemon
  2011-01-17 21:32 ` bugzilla-daemon
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 15+ messages in thread
From: bugzilla-daemon @ 2011-01-17  8:29 UTC (permalink / raw)
  To: ecos-bugs

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001117

Ilija Kocho <ilijak@siva.com.mk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Cortex-M architecture       |Cortex-M arch. Provision
                   |fixes.                      |for overriding of VTOR
                   |                            |setting.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.


^ permalink raw reply	[flat|nested] 15+ messages in thread
end of thread, other threads:[~2011-01-19 19:02 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-01-15 20:42 [Bug 1001117] New: Cortex-M architecture fixes bugzilla-daemon
2011-01-16  8:54 ` [Bug 1001117] " bugzilla-daemon
2011-01-16 10:21 ` bugzilla-daemon
2011-01-16 14:06 ` bugzilla-daemon
2011-01-16 14:15 ` bugzilla-daemon
2011-01-17  8:30 ` [Bug 1001117] Cortex-M arch. Provision for overriding of VTOR setting bugzilla-daemon
2011-01-17 21:32 ` bugzilla-daemon
2011-01-18  2:00 ` bugzilla-daemon
2011-01-19 19:00 ` bugzilla-daemon
2011-01-19 19:02 ` bugzilla-daemon
2011-01-15 20:42 [Bug 1001117] New: Cortex-M architecture fixes bugzilla-daemon
2011-01-17  8:29 ` [Bug 1001117] Cortex-M arch. Provision for overriding of VTOR setting bugzilla-daemon
2011-01-17 21:32 ` bugzilla-daemon
2011-01-18  2:31 ` bugzilla-daemon
2011-01-19 19:00 ` bugzilla-daemon
2011-01-19 19:02 ` bugzilla-daemon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).