[Bug 1001159] New: Fixes from FreeBSD IP Stack CVS

[Bug 1001159] New: Fixes from FreeBSD IP Stack CVS

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001159

           Summary: Fixes from FreeBSD IP Stack CVS
           Product: eCos
           Version: CVS
          Platform: All
        OS/Version: Other
            Status: UNCONFIRMED
          Severity: enhancement
          Priority: low
         Component: TCP/IP
        AssignedTo: unassigned@bugs.ecos.sourceware.org
        ReportedBy: kelvinl@users.sf.net
                CC: ecos-bugs@ecos.sourceware.org
             Class: Advice Request


Created an attachment (id=1145)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1145)
FreeBSD CVS patch

Attached two IP stack fixes from FreeBSD CVS which have not yet made it into
the eCos tree. Both of them are useful for limiting the potential usage of
network buffers under certain circumstances.

The ARP patch prevents the creation of reciprocal ARP cache entries if the
peer's source address is not on a local subnet. These reciprocal ARP cache
entries are created whenever a device on the local link makes contact via ARP,
and each entry uses up network buffers in the routing table. Prior to this fix
in the FreeBSD stack (and in eCos) it did not check the source IP address was
on the local subnet and added the route anyway. This change from FreeBSD's CVS
(r1.108) only adds reciprocal entries for devices with IP addresses on the
local subnet.

The TCP patch provides a configurable upper limit on the number of segments
which can be in the TCP reassembly queue. Without the patch it is possible for
all network buffers to be consumed by TCP reassembly queues when one or more
TCP segments is missing. The basic function of the patch is to set a threshold
over which further TCP reassembly segments will be dropped. This will prevent
further communication where reassembly is necessary (which will be the case
anyway when network buffers have run out), but still allow through packets
where reassembly is not required.  As long as the threshold is lower than the
number of network buffers, then the TCP reassembly queues will not be able to
consume the full pool of network buffers.

The patch adds a new option to the FreeBSD CDL (CYGPKG_NET_TCP_REASS_LIMIT)
which enables or disables the reassembly threshold feature. This defaults off
because the new behaviour might be unexpected to those synchronising with the
public repo. Once enabled you can use the CDL option
CYGPKG_NET_TCP_REASS_DIVISOR to set the maximum portion of network buffers
which can be consumed by the TCP reassembly queue. The limit is calculated as
"nmbclusters / CYGPKG_NET_TCP_REASS_DIVISOR", which defaults to 1/16th of the
available nmbclusters. This was the portion used in the original FreeBSD
change, but might be a little small for some embedded systems with very limited
packet buffer space.

Thanks,
Kelvin Lawson.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 1001159] Fixes from FreeBSD IP Stack CVS

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001159

Kelvin Lawson <kelvinl@users.sf.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ecos-patches@ecos.sourcewar
                   |                            |e.org
          Component|TCP/IP                      |Patches and contributions

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 1001159] Fixes from FreeBSD IP Stack CVS

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001159

Jonathan Larmour <jifl@ecoscentric.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
                 CC|                            |jifl@ecoscentric.com
         AssignedTo|unassigned@bugs.ecos.source |jifl@ecoscentric.com
                   |ware.org                    |
     Ever Confirmed|0                           |1
               Flag|                            |Patch_or_Contribution+

--- Comment #1 from Jonathan Larmour <jifl@ecoscentric.com> 2011-02-22 04:34:07 GMT ---
Hi Kelvin,

Thanks for the patch! This looks good, although I think there should be two
minor changes:
- make CYGPKG_NET_TCP_REASS_DIVISOR be of "booldata" type, which means we can
eliminate CYGPKG_NET_TCP_REASS_LIMIT.
- make all the added queue limit stuff depend on this option being set.
Otherwise we're adding code (albeit small) which can never be used.

I'll attach the patch I'm committing now.

For the record, the bulk of these patches originate from FreeBSD, so there is
no need for a copyright assignment for the trivial stuff left over.

Jifl

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 1001159] Fixes from FreeBSD IP Stack CVS

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001159

Jonathan Larmour <jifl@ecoscentric.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |NEXTRELEASE

--- Comment #3 from Jonathan Larmour <jifl@ecoscentric.com> 2011-02-22 04:36:53 GMT ---
Marking resolved as I've committed the patch.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001159] Fixes from FreeBSD IP Stack CVS

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001159

Jonathan Larmour <jifl@ecoscentric.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1145|0                           |1
        is obsolete|                            |
   Attachment #1146|                            |assignment+, review+
               Flag|                            |

--- Comment #2 from Jonathan Larmour <jifl@ecoscentric.com> 2011-02-22 04:35:35 GMT ---
Created an attachment (id=1146)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1146)
Updated version of patch as per my review comments

I'm checking this patch in.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001159] Fixes from FreeBSD IP Stack CVS

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001159

Jonathan Larmour <jifl@ecoscentric.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
                 CC|                            |jifl@ecoscentric.com
         AssignedTo|unassigned@bugs.ecos.source |jifl@ecoscentric.com
                   |ware.org                    |
     Ever Confirmed|0                           |1
               Flag|                            |Patch_or_Contribution+

--- Comment #1 from Jonathan Larmour <jifl@ecoscentric.com> 2011-02-22 04:34:07 GMT ---
Hi Kelvin,

Thanks for the patch! This looks good, although I think there should be two
minor changes:
- make CYGPKG_NET_TCP_REASS_DIVISOR be of "booldata" type, which means we can
eliminate CYGPKG_NET_TCP_REASS_LIMIT.
- make all the added queue limit stuff depend on this option being set.
Otherwise we're adding code (albeit small) which can never be used.

I'll attach the patch I'm committing now.

For the record, the bulk of these patches originate from FreeBSD, so there is
no need for a copyright assignment for the trivial stuff left over.

Jifl

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001159] Fixes from FreeBSD IP Stack CVS

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001159

Kelvin Lawson <kelvinl@users.sf.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ecos-patches@ecos.sourcewar
                   |                            |e.org
          Component|TCP/IP                      |Patches and contributions

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.