[Bug 1001456] HAL misses Interrupt Clear-Pending Registers handling: wasted processing power

[bugzilla-daemon@bugs.ecos.sourceware.org]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001456

--- Comment #1 from Bernard Fouché <bernard.fouche@kuantic.com> 2012-01-16 16:28:46 GMT ---
Confirmed with ser_16x5x.c. 

Test config: 2 uarts used, one at 115200, the other at 9600, very light serial
traffic. HW flow control activated on uart at 115200, no flow control on uart
at 9600. (did not checked yet if HW flow control is really operational yet)

I've added a counter of DSR calls, a counter of RX/TX chars and a counter of
DSR calls that do nothing:

1st run:

(gdb) print ser_dsr_dbg_rx
$1 = 1230
(gdb) print ser_dsr_dbg_tx
$2 = 49
(gdb) print ser_dsr_dbg_calls
$3 = 3483
(gdb) print ser_dsr_dbg_spurious
$4 = 2228

2nd run, hal_interrupt_clear_pending() called before reading Interrupt
Identification Register (two reads in my version of the DSR):

(gdb) print ser_dsr_dbg_rx
$1 = 1230
(gdb) print ser_dsr_dbg_tx
$2 = 49
(gdb) print ser_dsr_dbg_calls
$3 = 1867
(gdb) print ser_dsr_dbg_spurious
$4 = 668
(gdb)

Much better but still a gremlin to find and kill, counter of spurious ints must
be zero. Anyway the numbers speak by themselves.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
>From ecos-bugs-return-8684-listarch-ecos-bugs=sources.redhat.com@sourceware.org Mon Jan 16 16:29:10 2012
Return-Path: <ecos-bugs-return-8684-listarch-ecos-bugs=sources.redhat.com@sourceware.org>
Delivered-To: listarch-ecos-bugs@sources.redhat.com
Received: (qmail 28570 invoked by alias); 16 Jan 2012 16:29:07 -0000
Received: (qmail 28561 invoked by uid 22791); 16 Jan 2012 16:29:04 -0000
X-SWARE-Spam-Status: No, hits=-1.9 required=5.0
	tests=AWL,BAYES_00,TW_DB,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from hagrid.ecoscentric.com (HELO mail.ecoscentric.com) (212.13.207.197)
    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 16 Jan 2012 16:28:52 +0000
Received: by mail.ecoscentric.com (Postfix, from userid 48)
	id AC3F22F7800F; Mon, 16 Jan 2012 16:28:50 +0000 (GMT)
X-Original-To: unassigned@bugs.ecos.sourceware.org
Delivered-To: unassigned@bugs.ecos.sourceware.org
From: bugzilla-daemon@bugs.ecos.sourceware.org
To: unassigned@bugs.ecos.sourceware.org
Subject: [Bug 1001456] HAL misses Interrupt Clear-Pending Registers handling:
 wasted processing power
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: eCos
X-Bugzilla-Component: HAL
X-Bugzilla-Keywords:
X-Bugzilla-Severity: major
X-Bugzilla-Who: bernard.fouche@kuantic.com
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: low
X-Bugzilla-Assigned-To: unassigned@bugs.ecos.sourceware.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Changed-Fields:
In-Reply-To: <bug-1001456-777@http.bugs.ecos.sourceware.org/>
References: <bug-1001456-777@http.bugs.ecos.sourceware.org/>
X-Bugzilla-URL: http://bugs.ecos.sourceware.org/
Auto-Submitted: auto-generated
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Date: Mon, 16 Jan 2012 16:29:00 -0000
Message-Id: <20120116162849.2FA1F2F78005@mail.ecoscentric.com>
Mailing-List: contact ecos-bugs-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <ecos-bugs.sourceware.org>
List-Subscribe: <mailto:ecos-bugs-subscribe@sourceware.org>
List-Post: <mailto:ecos-bugs@sourceware.org>
List-Help: <mailto:ecos-bugs-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: ecos-bugs-owner@sourceware.org
Delivered-To: mailing list ecos-bugs@sourceware.org
X-SW-Source: 2012/txt/msg00113.txt.bz2
Content-length: 1382

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001456

--- Comment #1 from Bernard Fouché <bernard.fouche@kuantic.com> 2012-01-16 16:28:46 GMT ---
Confirmed with ser_16x5x.c. 

Test config: 2 uarts used, one at 115200, the other at 9600, very light serial
traffic. HW flow control activated on uart at 115200, no flow control on uart
at 9600. (did not checked yet if HW flow control is really operational yet)

I've added a counter of DSR calls, a counter of RX/TX chars and a counter of
DSR calls that do nothing:

1st run:

(gdb) print ser_dsr_dbg_rx
$1 = 1230
(gdb) print ser_dsr_dbg_tx
$2 = 49
(gdb) print ser_dsr_dbg_calls
$3 = 3483
(gdb) print ser_dsr_dbg_spurious
$4 = 2228

2nd run, hal_interrupt_clear_pending() called before reading Interrupt
Identification Register (two reads in my version of the DSR):

(gdb) print ser_dsr_dbg_rx
$1 = 1230
(gdb) print ser_dsr_dbg_tx
$2 = 49
(gdb) print ser_dsr_dbg_calls
$3 = 1867
(gdb) print ser_dsr_dbg_spurious
$4 = 668
(gdb)

Much better but still a gremlin to find and kill, counter of spurious ints must
be zero. Anyway the numbers speak by themselves.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
>From ecos-bugs-return-8686-listarch-ecos-bugs=sources.redhat.com@sourceware.org Tue Jan 17 17:49:40 2012
Return-Path: <ecos-bugs-return-8686-listarch-ecos-bugs=sources.redhat.com@sourceware.org>
Delivered-To: listarch-ecos-bugs@sources.redhat.com
Received: (qmail 16116 invoked by alias); 17 Jan 2012 17:49:34 -0000
Received: (qmail 16096 invoked by uid 22791); 17 Jan 2012 17:49:32 -0000
X-SWARE-Spam-Status: No, hits=-1.9 required=5.0
	tests=AWL,BAYES_00,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from hagrid.ecoscentric.com (HELO mail.ecoscentric.com) (212.13.207.197)
    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 17 Jan 2012 17:49:18 +0000
Received: by mail.ecoscentric.com (Postfix, from userid 48)
	id E9F6B2FB085B; Tue, 17 Jan 2012 17:49:16 +0000 (GMT)
X-Original-To: unassigned@bugs.ecos.sourceware.org
Delivered-To: unassigned@bugs.ecos.sourceware.org
From: bugzilla-daemon@bugs.ecos.sourceware.org
To: unassigned@bugs.ecos.sourceware.org
Subject: [Bug 1001269] Via Rhine Ethernet driver is reading the MAC
 incorrectly
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: eCos
X-Bugzilla-Component: Ethernet
X-Bugzilla-Keywords:
X-Bugzilla-Severity: major
X-Bugzilla-Who: stephen@centtech.com
X-Bugzilla-Status: RESOLVED
X-Bugzilla-Priority: low
X-Bugzilla-Assigned-To: unassigned@bugs.ecos.sourceware.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Changed-Fields: Status Resolution
In-Reply-To: <bug-1001269-777@http.bugs.ecos.sourceware.org/>
References: <bug-1001269-777@http.bugs.ecos.sourceware.org/>
X-Bugzilla-URL: http://bugs.ecos.sourceware.org/
Auto-Submitted: auto-generated
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Date: Tue, 17 Jan 2012 17:49:00 -0000
Message-Id: <20120117174915.53A6B2FF0027@mail.ecoscentric.com>
Mailing-List: contact ecos-bugs-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <ecos-bugs.sourceware.org>
List-Subscribe: <mailto:ecos-bugs-subscribe@sourceware.org>
List-Post: <mailto:ecos-bugs@sourceware.org>
List-Help: <mailto:ecos-bugs-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: ecos-bugs-owner@sourceware.org
Delivered-To: mailing list ecos-bugs@sourceware.org
X-SW-Source: 2012/txt/msg00115.txt.bz2
Content-length: 1487

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id\x1001269

stephen@centtech.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |CURRENTRELEASE

--- Comment #7 from stephen@centtech.com 2012-01-17 17:49:11 GMT ---
(In reply to comment #5)
> (In reply to comment #4)
>
> > Yes, I will test the patch out.  I have the hardware in my office.
> > I will email you when the testing is done.
>
> Stephen, could you test the patch? We appreciate any feedback.
>
> Sergei

Hello Sergei.  I am sorry for the delay.  My boss had me working on
other stuff until recently.  I applied your patch to the latest ecos
build tree. I have verified that your patch [attachment 1356]
fixes the bug in the VIA Rhine driver.

I built the VIA Rhine driver for the pc redboot package.  This
is a new package that I will be uploading to ECOS very shortly.
I was successful in loading and running hello.c via GDB network debugging
using a D-Link DFE-530TX Rev-A3-1 PCI card.

Please commit your changes to the ECOS tree at your earliest convenience.

Thanks,

Stephen

--
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.