[Bug 1001504] New: Fix CYG_REFERENCE_OBJECT macro, add CYGBLD_ATTRIB_UNUSED macro

[Bug 1001504] New: Fix CYG_REFERENCE_OBJECT macro, add CYGBLD_ATTRIB_UNUSED macro

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001504

           Summary: Fix CYG_REFERENCE_OBJECT macro, add
                    CYGBLD_ATTRIB_UNUSED macro
           Product: eCos
           Version: CVS
          Platform: All
        OS/Version: Other
            Status: NEW
          Severity: enhancement
          Priority: low
         Component: Other
        AssignedTo: unassigned@bugs.ecos.sourceware.org
        ReportedBy: grant.b.edwards@gmail.com
                CC: ecos-bugs@ecos.sourceware.org
             Class: Advice Request


With gcc 4.6, the "used" attribute only applies to functions, so to
fix compiler warnings conditionally remove it from the
CYG_REFERENCE_OBJECT() macro for gcc >= 4.6.

Define a new CYGBLD_ATTRIB_UNUSED attribute macro that we can use to
tell the compiler that we already know that certain variables may be
unused or set but never referenced (generally when asserts or debugging
are turned off at build-time).

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001504] Fix CYG_REFERENCE_OBJECT macro, add CYGBLD_ATTRIB_UNUSED macro

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001504

Jonathan Larmour <jifl@ecoscentric.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jifl@ecoscentric.com

--- Comment #1 from Jonathan Larmour <jifl@ecoscentric.com> 2012-03-03 04:30:53 GMT ---
No patch attached....

The CYGBLD_ATTRIB_UNUSED attribute addition is fine (and obviously you'll need
to add that before the other patches I approved tonight).

However I just want to check about the CYG_REFERENCE_OBJECT change, as far as I
can tell the "used" attribute still applies to variables. e.g. here:
http://gcc.gnu.org/onlinedocs/gcc/Variable-Attributes.html

and more specifically here:
http://gcc.gnu.org/viewcvs/branches/gcc-4_6-branch/gcc/doc/extend.texi?content-type=text%2Fplain&view=co

and there's no mention of it being removed here:
http://gcc.gnu.org/gcc-4.6/changes.html

Unless, of course, they failed to keep their docs in line with reality, but it
seems unlikely. Is there some alternative explanation for why you were having
trouble with it in CYG_REFERENCE_OBJECT?

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001504] Fix CYG_REFERENCE_OBJECT macro, add CYGBLD_ATTRIB_UNUSED macro

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001504

Jonathan Larmour <jifl@ecoscentric.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |NEEDINFO
         AssignedTo|unassigned@bugs.ecos.source |jifl@ecoscentric.com
                   |ware.org                    |

--- Comment #2 from Jonathan Larmour <jifl@ecoscentric.com> 2012-03-03 04:31:25 GMT ---
Assigning to me...

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001504] Fix CYG_REFERENCE_OBJECT macro, add CYGBLD_ATTRIB_UNUSED macro

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001504

--- Comment #3 from Grant Edwards <grant.b.edwards@gmail.com> 2012-03-03 18:06:47 GMT ---
Where the CYG_REFERENCE_OBJECT() macro was being used, I was getting a compiler
warning about the "used" attribute being ignore.  Somewhere in the gcc docs, I
found two tables of attributes -- one table for functions and one for
variables.
The "used" attribute was in the function table but not the variable table. 
I'll
try to find those tables again.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001504] Fix CYG_REFERENCE_OBJECT macro, add CYGBLD_ATTRIB_UNUSED macro

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001504

--- Comment #4 from Grant Edwards <grant.b.edwards@gmail.com> 2012-03-03 18:18:24 GMT ---
The 4.6.3 manual certainly shows "used" being a valid attribute for a variable.

Can we split this up and commit the CYGBLD_ATTRIB_UNUSED definition now so that 
I can go ahead with the other patches that depend on it?  What's the "right"
way to split a bug into two?

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001504] Fix CYG_REFERENCE_OBJECT macro, add CYGBLD_ATTRIB_UNUSED macro

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001504

Ilija Kocho <ilijak@siva.com.mk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ilijak@siva.com.mk

--- Comment #5 from Ilija Kocho <ilijak@siva.com.mk> 2012-03-03 18:40:54 GMT ---
(In reply to comment #4)
> The 4.6.3 manual certainly shows "used" being a valid attribute for a variable.
> 
> Can we split this up and commit the CYGBLD_ATTRIB_UNUSED definition now so that 
> I can go ahead with the other patches that depend on it?  What's the "right"
> way to split a bug into two?

Perhaps you don't need to split the bug, just split the patch in two
attachments.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001504] Fix CYG_REFERENCE_OBJECT macro, add CYGBLD_ATTRIB_UNUSED macro

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001504

--- Comment #6 from Jonathan Larmour <jifl@ecoscentric.com> 2012-03-04 00:07:34 GMT ---
I don't think we even need to be as formal as that between maintainers, not
with a change this small anyway - no need to attach an updated patch to this
bug for just the CYGBLD_ATTRIB_USED portion; just go ahead and commit that bit
by itself, although with a ChangeLog still.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001504] Fix CYG_REFERENCE_OBJECT macro, add CYGBLD_ATTRIB_UNUSED macro

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001504

--- Comment #7 from Grant Edwards <grant.b.edwards@gmail.com> 2012-03-06 18:39:12 GMT ---
Created an attachment (id=1615)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1615)
Patch to add CYGBLD_ATTRIB_UNUSED, change CYG_REFERENCE_OBJECT

FWIW, here's the original patch that I didn't get attached.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001504] Fix CYG_REFERENCE_OBJECT macro, add CYGBLD_ATTRIB_UNUSED macro

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001504

--- Comment #8 from Grant Edwards <grant.b.edwards@gmail.com> 2012-03-06 18:46:21 GMT ---
Commited change to add CYGBLD_ATTRIB_UNUSED.  Did not make any changes
to CYG_REFERENCE_OBJECT.

/cvs/ecos/ecos/packages/infra/current/ChangeLog,v  <--  ChangeLog
new revision: 1.71; previous revision: 1.70

/cvs/ecos/ecos/packages/infra/current/include/cyg_type.h,v  <--  cyg_type.h
new revision: 1.29; previous revision: 1.28

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001504] Fix CYG_REFERENCE_OBJECT macro, add CYGBLD_ATTRIB_UNUSED macro

[bugzilla-daemon]

Please do not reply to this email, use the link below.

http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001504

Mike Jones <mjones@linear.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mjones@linear.com

--- Comment #9 from Mike Jones <mjones@linear.com> ---
Has anyone come up with a solution to CYG_REFERENCE_OBJECT? It does not work
with gcc 4.6.3 or 4.7.3.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 1001504] New: Fix CYG_REFERENCE_OBJECT macro, add CYGBLD_ATTRIB_UNUSED macro

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001504

           Summary: Fix CYG_REFERENCE_OBJECT macro, add
                    CYGBLD_ATTRIB_UNUSED macro
           Product: eCos
           Version: CVS
          Platform: All
        OS/Version: Other
            Status: NEW
          Severity: enhancement
          Priority: low
         Component: Other
        AssignedTo: unassigned@bugs.ecos.sourceware.org
        ReportedBy: grant.b.edwards@gmail.com
                CC: ecos-bugs@ecos.sourceware.org
             Class: Advice Request


With gcc 4.6, the "used" attribute only applies to functions, so to
fix compiler warnings conditionally remove it from the
CYG_REFERENCE_OBJECT() macro for gcc >= 4.6.

Define a new CYGBLD_ATTRIB_UNUSED attribute macro that we can use to
tell the compiler that we already know that certain variables may be
unused or set but never referenced (generally when asserts or debugging
are turned off at build-time).

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 1001504] Fix CYG_REFERENCE_OBJECT macro, add CYGBLD_ATTRIB_UNUSED macro

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001504

Jonathan Larmour <jifl@ecoscentric.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jifl@ecoscentric.com

--- Comment #1 from Jonathan Larmour <jifl@ecoscentric.com> 2012-03-03 04:30:53 GMT ---
No patch attached....

The CYGBLD_ATTRIB_UNUSED attribute addition is fine (and obviously you'll need
to add that before the other patches I approved tonight).

However I just want to check about the CYG_REFERENCE_OBJECT change, as far as I
can tell the "used" attribute still applies to variables. e.g. here:
http://gcc.gnu.org/onlinedocs/gcc/Variable-Attributes.html

and more specifically here:
http://gcc.gnu.org/viewcvs/branches/gcc-4_6-branch/gcc/doc/extend.texi?content-type=text%2Fplain&view=co

and there's no mention of it being removed here:
http://gcc.gnu.org/gcc-4.6/changes.html

Unless, of course, they failed to keep their docs in line with reality, but it
seems unlikely. Is there some alternative explanation for why you were having
trouble with it in CYG_REFERENCE_OBJECT?

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 1001504] Fix CYG_REFERENCE_OBJECT macro, add CYGBLD_ATTRIB_UNUSED macro

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001504

Jonathan Larmour <jifl@ecoscentric.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |NEEDINFO
         AssignedTo|unassigned@bugs.ecos.source |jifl@ecoscentric.com
                   |ware.org                    |

--- Comment #2 from Jonathan Larmour <jifl@ecoscentric.com> 2012-03-03 04:31:25 GMT ---
Assigning to me...

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.