[Bug 1001180] New: TTY CDL to accommodate more than 4 serial ports.

[Bug 1001180] New: TTY CDL to accommodate more than 4 serial ports.

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001180

           Summary: TTY CDL to accommodate more than 4 serial ports.
           Product: eCos
           Version: 3.0
          Platform: All
        OS/Version: All
            Status: UNCONFIRMED
          Severity: enhancement
          Priority: low
         Component: Serial
        AssignedTo: unassigned@bugs.ecos.sourceware.org
        ReportedBy: ilijak@siva.com.mk
                CC: ecos-bugs@ecos.sourceware.org
             Class: Advice Request


Hello colleagues

We need to extend tty.cdl (and respective C code) in order to accommodate more
than 4 serial ports, currently we need 6.
Similar case is with termios.

Dilemma: We can simply add 2 TTY port entries or we can produce a generic
solution.

This discussion has started and some solutions discussed on ecos-devel mailing
list. Here is the reference:

http://ecos.sourceware.org/ml/ecos-devel/2011-03/msg00023.html

Please advise.

Regards
Ilija

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001180] TTY driver to accommodate more than 4 serial ports.

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001180

Ilija Kocho <ilijak@siva.com.mk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|TTY CDL to accommodate more |TTY driver to accommodate
                   |than 4 serial ports.        |more than 4 serial ports.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001180] TTY driver to accommodate more than 4 serial ports.

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001180

--- Comment #1 from Ilija Kocho <ilijak@siva.com.mk> 2011-03-28 19:38:45 BST ---
Created an attachment (id=1185)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1185)
Enable users to include TTY devtab entries in src/common/tty.c

This patch provides inclusion of additional devtab entries in TTY driver.
Typically devtab entries can be provided by serial device driver. Devtab
entries should be accompanied by corresponding CDL entries. See example
attached below.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001180] TTY driver to accommodate more than 4 serial ports.

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001180

--- Comment #2 from Ilija Kocho <ilijak@siva.com.mk> 2011-03-28 19:46:43 BST ---
Created an attachment (id=1186)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1186)
Sample devtab entries file. Should be placed in serial driver's include
directory.

This sample .inl file adds two TTY ports. File should be placed in serial
driver include directory, for example:
/devs/serial/your_device/current/include/

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001180] TTY driver to accommodate more than 4 serial ports.

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001180

--- Comment #3 from Ilija Kocho <ilijak@siva.com.mk> 2011-03-28 19:53:26 BST ---
Created an attachment (id=1187)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1187)
Sample CDL snippet. Should be inserted in device driver's CDL.

This sample corresponds to Attachment 1186. Adds two respective TTY's and
provides CYGPKG_IO_SERIAL_TTY_ADD macro for inclusion of Attachment 1184 at
place pointed by Attachment 1185.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001180] TTY driver to accommodate more than 4 serial ports.

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001180

--- Comment #4 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2011-03-28 22:18:06 BST ---
Thank you for the patch and usage snippets. I take this opportunity and
also entered the same conditional include in termiostty.c. Also it
seemed to me that CYGDAT_IO_SERIAL_TTY_INLINE is more conventional name
for this case. I mean that then you define "hooked-to" serial/io config,
say a component CYGPKG_IO_SERIAL_TTY_EXTRA which will contain such a
cdl_option to define a file name. Why *_INLINE. In fact that is not a
header as such, and an included C source code. I'll attach a bit updated
patch.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001180] TTY driver to accommodate more than 4 serial ports.

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001180

Sergei Gavrikov <sergei.gavrikov@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1185|0                           |1
        is obsolete|                            |

--- Comment #5 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2011-03-28 22:21:17 BST ---
Created an attachment (id=1188)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1188)
io:serial: Give a chance to define more termios/tty DEVTAB entries

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001180] TTY driver to accommodate more than 4 serial ports.

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001180

--- Comment #6 from Ilija Kocho <ilijak@siva.com.mk> 2011-03-29 09:20:46 BST ---
(In reply to comment #4)
> Thank you for the patch and usage snippets. I take this opportunity and
> also entered the same conditional include in termiostty.c. Also it
> seemed to me that CYGDAT_IO_SERIAL_TTY_INLINE is more conventional name
> for this case. I mean that then you define "hooked-to" serial/io config,
> say a component CYGPKG_IO_SERIAL_TTY_EXTRA which will contain such a
> cdl_option to define a file name. Why *_INLINE. In fact that is not a
> header as such, and an included C source code. I'll attach a bit updated
> patch.

Thank you for termios patch.

The idea with my naming is to continue macro sequence present already in tty.c
CYGPKG_IO_SERIAL_TTY_TTY0 .. CYGPKG_IO_SERIAL_TTY_TTY3 then
CYGPKG_IO_SERIAL_TTY_ADD. Maybe it could be CYGPKG_IO_SERIAL_TTY_PLUS or, to
emphasis that it is an inline: CYGPKG_IO_SERIAL_TTY_PLUS_INL (.inl is also
extension for included file).

Also we could add some comment in front of the macro:

// CYGPKG_IO_SERIAL_TTY_PLUS_INL macro provides for user inclusion of
additional
// TTY devices. Included file should be typically placed in serial device
include
// directory. It should be accompanied by a cdl_component that shall define the
// macro as well provide as TTY device configuration, as a part of serial
device // cdl file.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001180] TTY driver to accommodate more than 4 serial ports.

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001180

--- Comment #7 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2011-03-29 10:29:19 BST ---
(In reply to comment #6)
> The idea with my naming is to continue macro sequence present already
> in tty.c CYGPKG_IO_SERIAL_TTY_TTY0 .. CYGPKG_IO_SERIAL_TTY_TTY3 then
> CYGPKG_IO_SERIAL_TTY_ADD. Maybe it could be CYGPKG_IO_SERIAL_TTY_PLUS
> or, to emphasis that it is an inline: CYGPKG_IO_SERIAL_TTY_PLUS_INL
> (.inl is also extension for included file).

> Also we could add some comment in front of the macro:
> 
> // CYGPKG_IO_SERIAL_TTY_PLUS_INL macro provides for user inclusion of additional
> // TTY devices. Included file should be typically placed in serial device
> include
> // directory. It should be accompanied by a cdl_component that shall define the
> // macro as well provide as TTY device configuration, as a part of serial device
> // cdl file.

Thank you for the comment lines. But, I would prefer to use CYGDAT
prefix (!CYGPKG), e.g.  CYGDAT_IO_SERIAL_TTY_ADD_INL. Usually CDL
options using 'flavor data' are prefixed with CYGDAT. IMO a line

#include <CYGDAT_IO_SERIAL_TTY_ADD_INL>

looks more preferable than

#include <CYGPKG_IO_SERIAL_TTY_ADD_INL>

If you agree with my point I would update the patch (options names)
(CYGDAT_IO_SERIAL_TTY_ADD_INL, CYGDAT_IO_SERIAL_TERMIOS_ADD_INL) and
expand comment lines there.

Sergei

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001180] TTY driver to accommodate more than 4 serial ports.

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001180

--- Comment #8 from Ilija Kocho <ilijak@siva.com.mk> 2011-03-29 11:18:25 BST ---
(In reply to comment #7)
> (In reply to comment #6)
> > The idea with my naming is to continue macro sequence present already
> > in tty.c CYGPKG_IO_SERIAL_TTY_TTY0 .. CYGPKG_IO_SERIAL_TTY_TTY3 then
> > CYGPKG_IO_SERIAL_TTY_ADD. Maybe it could be CYGPKG_IO_SERIAL_TTY_PLUS
> > or, to emphasis that it is an inline: CYGPKG_IO_SERIAL_TTY_PLUS_INL
> > (.inl is also extension for included file).
> 
> > Also we could add some comment in front of the macro:
> > 
> > // CYGPKG_IO_SERIAL_TTY_PLUS_INL macro provides for user inclusion of additional
> > // TTY devices. Included file should be typically placed in serial device
> > include
> > // directory. It should be accompanied by a cdl_component that shall define the
> > // macro as well provide as TTY device configuration, as a part of serial device
> > // cdl file.
> 
> Thank you for the comment lines. But, I would prefer to use CYGDAT
> prefix (!CYGPKG), e.g.  CYGDAT_IO_SERIAL_TTY_ADD_INL. Usually CDL
> options using 'flavor data' are prefixed with CYGDAT. IMO a line
> 
> #include <CYGDAT_IO_SERIAL_TTY_ADD_INL>
> 
> looks more preferable than
> 
> #include <CYGPKG_IO_SERIAL_TTY_ADD_INL>
> 
> If you agree with my point I would update the patch (options names)
> (CYGDAT_IO_SERIAL_TTY_ADD_INL, CYGDAT_IO_SERIAL_TERMIOS_ADD_INL) and
> expand comment lines there.

OK.
Ilija

> 
> Sergei

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001180] TTY driver to accommodate more than 4 serial ports.

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001180

Sergei Gavrikov <sergei.gavrikov@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1188|0                           |1
        is obsolete|                            |

--- Comment #9 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2011-03-29 18:57:16 BST ---
Created an attachment (id=1190)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1190)
io:serial: possibility to define a few additional termios/tty devtab entries

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001180] TTY driver to accommodate more than 4 serial ports.

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001180

--- Comment #10 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2011-03-29 19:07:23 BST ---
(In reply to comment #7)
> (In reply to comment #6)
...
> > If you agree with my point I would update the patch (options names)
> > (CYGDAT_IO_SERIAL_TTY_ADD_INL, CYGDAT_IO_SERIAL_TERMIOS_ADD_INL) and
> > expand comment lines there.
> 
> OK.
> Ilija

Done [ Attachment 1190 ]

Ilija, I would avoid to paste CDL guide in comments. In my opinion the
code is self-documented (it is used a proper place, and simple idea
about what the code do).

Sergei

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001180] TTY driver to accommodate more than 4 serial ports.

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001180

--- Comment #11 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2011-03-29 19:11:27 BST ---
(In reply to comment #10)

> Done [ Attachment 1190 ]

If no one has any doubt, I plan to commit the patch.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001180] TTY driver to accommodate more than 4 serial ports.

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001180

--- Comment #12 from Ilija Kocho <ilijak@siva.com.mk> 2011-03-29 19:49:15 BST ---
(In reply to comment #11)
> (In reply to comment #10)
> 
> > Done [ Attachment 1190 [details] ]
> 
> If no one has any doubt, I plan to commit the patch.

OK for both and Comment 10.

Ilija

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001180] TTY driver to accommodate more than 4 serial ports.

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001180

--- Comment #13 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2011-03-30 17:43:51 BST ---
(In reply to comment #12)
> > (In reply to comment #11)
> > If no one has any doubt, I plan to commit the patch.
> 
> OK for both and Comment 10.
> 
> Ilija

Checked-in.

Ilija, thank you for your contribution.

Sergei

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001180] TTY driver to accommodate more than 4 serial ports.

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001180

--- Comment #14 from Ilija Kocho <ilijak@siva.com.mk> 2011-03-30 17:57:42 BST ---
(In reply to comment #13)
> (In reply to comment #12)
> > > (In reply to comment #11)
> > > If no one has any doubt, I plan to commit the patch.
> > 
> > OK for both and Comment 10.
> > 
> > Ilija
> 
> Checked-in.
> 
> Ilija, thank you for your contribution.
> 
> Sergei

Many thanks Sergei.
Ilija

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001180] TTY driver to accommodate more than 4 serial ports.

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001180

Ilija Kocho <ilijak@siva.com.mk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |CURRENTRELEASE

--- Comment #15 from Ilija Kocho <ilijak@siva.com.mk> 2011-04-02 13:28:33 BST ---
(In reply to comment #13)
> (In reply to comment #12)
> > > (In reply to comment #11)
> > > If no one has any doubt, I plan to commit the patch.
> > 
> > OK for both and Comment 10.
> > 
> > Ilija
> 
> Checked-in.
> 
> Ilija, thank you for your contribution.
> 
> Sergei

Since it's committed.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001180] New: TTY CDL to accommodate more than 4 serial ports.

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001180

           Summary: TTY CDL to accommodate more than 4 serial ports.
           Product: eCos
           Version: 3.0
          Platform: All
        OS/Version: All
            Status: UNCONFIRMED
          Severity: enhancement
          Priority: low
         Component: Serial
        AssignedTo: unassigned@bugs.ecos.sourceware.org
        ReportedBy: ilijak@siva.com.mk
                CC: ecos-bugs@ecos.sourceware.org
             Class: Advice Request


Hello colleagues

We need to extend tty.cdl (and respective C code) in order to accommodate more
than 4 serial ports, currently we need 6.
Similar case is with termios.

Dilemma: We can simply add 2 TTY port entries or we can produce a generic
solution.

This discussion has started and some solutions discussed on ecos-devel mailing
list. Here is the reference:

http://ecos.sourceware.org/ml/ecos-devel/2011-03/msg00023.html

Please advise.

Regards
Ilija

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.