public inbox for ecos-bugs@sourceware.org
help / color / mirror / Atom feed
From: bugzilla-daemon@bugs.ecos.sourceware.org
To: unassigned@bugs.ecos.sourceware.org
Subject: [Bug 1001858] CAN driver return code patch
Date: Wed, 05 Jun 2013 21:24:00 -0000 [thread overview]
Message-ID: <bug-1001858-777-mOUFLWvI92@http.bugs.ecos.sourceware.org/> (raw)
In-Reply-To: <bug-1001858-777@http.bugs.ecos.sourceware.org/>
Please do not reply to this email, use the link below.
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001858
--- Comment #2 from Sergei Gavrikov <sergei.gavrikov@gmail.com> ---
(In reply to comment #0)
...
> The function shall return -ENOSPC to indicate that there are no filters
> available. At the moment the only implementation that uses these keys
> (LPC2xxx CAN driver) returns -EPERM. But -EPERM is also returned if it is
> not possible to configure filters because message filterings is deactivated
> (CYGNUM_CAN_MSGBUF_RX_FILTER_ALL). So with the new return code it is
> possible for the application to identify the exact reason why message filter
> configuration failed.
I share your view. Thanks for the patch.
FYI: there were 2 jade errors on VARNAME usage:
... document type does not allow element "VARNAME" here; missing one of
"COMMENT", "SYNOPSIS", "LITERALLAYOUT", "PROGRAMLISTING", "SCREEN", "PARA",
"SIMPARA", "BRIDGEHEAD" start-tag
So, I put your doc-strings in separate PARA blocks (see attachment #2249).
If no one has any objections I plan to commit the changes.
--
You are receiving this mail because:
You are the assignee for the bug.
next prev parent reply other threads:[~2013-06-05 21:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-05 11:36 [Bug 1001858] New: " bugzilla-daemon
2013-06-05 21:02 ` [Bug 1001858] " bugzilla-daemon
2013-06-05 21:24 ` bugzilla-daemon [this message]
2013-06-06 5:27 ` bugzilla-daemon
2013-06-06 20:36 ` bugzilla-daemon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-1001858-777-mOUFLWvI92@http.bugs.ecos.sourceware.org/ \
--to=bugzilla-daemon@bugs.ecos.sourceware.org \
--cc=unassigned@bugs.ecos.sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).