public inbox for ecos-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug 1001858] New: CAN driver return code patch
@ 2013-06-05 11:36 bugzilla-daemon
2013-06-05 21:02 ` [Bug 1001858] " bugzilla-daemon
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: bugzilla-daemon @ 2013-06-05 11:36 UTC (permalink / raw)
To: unassigned
Please do not reply to this email, use the link below.
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001858
Bug ID: 1001858
Summary: CAN driver return code patch
Product: eCos
Version: CVS
Target: All
Architecture/Host Other
OS:
Status: UNCONFIRMED
Severity: enhancement
Priority: low
Component: Patches and contributions
Assignee: unassigned@bugs.ecos.sourceware.org
Reporter: uwe_kindler@web.de
CC: ecos-patches@ecos.sourceware.org
Created attachment 2248
--> http://bugs.ecos.sourceware.org/attachment.cgi?id=2248&action=edit
CAN driver retuirn code patch
The following patch defines the error code to be returned by
cyg_io_set_config() for the config keys CYG_IO_SET_CONFIG_CAN_RANGE_FILTER and
CYG_IO_SET_CONFIG_CAN_MASK_FILTER if no buffers or filters are available
anymore.
The function shall return -ENOSPC to indicate that there are no filters
available. At the moment the only implementation that uses these keys (LPC2xxx
CAN driver) returns -EPERM. But -EPERM is also returned if it is not possible
to configure filters because message filterings is deactivated
(CYGNUM_CAN_MSGBUF_RX_FILTER_ALL). So with the new return code it is possible
for the application to identify the exact reason why message filter
configuration failed.
--
You are receiving this mail because:
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug 1001858] CAN driver return code patch
2013-06-05 11:36 [Bug 1001858] New: CAN driver return code patch bugzilla-daemon
@ 2013-06-05 21:02 ` bugzilla-daemon
2013-06-05 21:24 ` bugzilla-daemon
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: bugzilla-daemon @ 2013-06-05 21:02 UTC (permalink / raw)
To: unassigned
Please do not reply to this email, use the link below.
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001858
Sergei Gavrikov <sergei.gavrikov@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #2248|0 |1
is obsolete| |
--- Comment #1 from Sergei Gavrikov <sergei.gavrikov@gmail.com> ---
Created attachment 2249
--> http://bugs.ecos.sourceware.org/attachment.cgi?id=2249&action=edit
lpc2xxx can: changed a few return values
This patch is cleaned-up version of attachment #2248 (no CRs/WS; SGML usage).
--
You are receiving this mail because:
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug 1001858] CAN driver return code patch
2013-06-05 11:36 [Bug 1001858] New: CAN driver return code patch bugzilla-daemon
2013-06-05 21:02 ` [Bug 1001858] " bugzilla-daemon
@ 2013-06-05 21:24 ` bugzilla-daemon
2013-06-06 5:27 ` bugzilla-daemon
2013-06-06 20:36 ` bugzilla-daemon
3 siblings, 0 replies; 5+ messages in thread
From: bugzilla-daemon @ 2013-06-05 21:24 UTC (permalink / raw)
To: unassigned
Please do not reply to this email, use the link below.
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001858
--- Comment #2 from Sergei Gavrikov <sergei.gavrikov@gmail.com> ---
(In reply to comment #0)
...
> The function shall return -ENOSPC to indicate that there are no filters
> available. At the moment the only implementation that uses these keys
> (LPC2xxx CAN driver) returns -EPERM. But -EPERM is also returned if it is
> not possible to configure filters because message filterings is deactivated
> (CYGNUM_CAN_MSGBUF_RX_FILTER_ALL). So with the new return code it is
> possible for the application to identify the exact reason why message filter
> configuration failed.
I share your view. Thanks for the patch.
FYI: there were 2 jade errors on VARNAME usage:
... document type does not allow element "VARNAME" here; missing one of
"COMMENT", "SYNOPSIS", "LITERALLAYOUT", "PROGRAMLISTING", "SCREEN", "PARA",
"SIMPARA", "BRIDGEHEAD" start-tag
So, I put your doc-strings in separate PARA blocks (see attachment #2249).
If no one has any objections I plan to commit the changes.
--
You are receiving this mail because:
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug 1001858] CAN driver return code patch
2013-06-05 11:36 [Bug 1001858] New: CAN driver return code patch bugzilla-daemon
2013-06-05 21:02 ` [Bug 1001858] " bugzilla-daemon
2013-06-05 21:24 ` bugzilla-daemon
@ 2013-06-06 5:27 ` bugzilla-daemon
2013-06-06 20:36 ` bugzilla-daemon
3 siblings, 0 replies; 5+ messages in thread
From: bugzilla-daemon @ 2013-06-06 5:27 UTC (permalink / raw)
To: unassigned
Please do not reply to this email, use the link below.
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001858
--- Comment #3 from Uwe Kindler <uwe_kindler@web.de> ---
Thank you - I have no working docbook environment on windows, so I could not
test the doc changes. Thank you for fixing this.
--
You are receiving this mail because:
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug 1001858] CAN driver return code patch
2013-06-05 11:36 [Bug 1001858] New: CAN driver return code patch bugzilla-daemon
` (2 preceding siblings ...)
2013-06-06 5:27 ` bugzilla-daemon
@ 2013-06-06 20:36 ` bugzilla-daemon
3 siblings, 0 replies; 5+ messages in thread
From: bugzilla-daemon @ 2013-06-06 20:36 UTC (permalink / raw)
To: unassigned
Please do not reply to this email, use the link below.
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001858
Sergei Gavrikov <sergei.gavrikov@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |RESOLVED
Resolution|--- |CURRENTRELEASE
--- Comment #4 from Sergei Gavrikov <sergei.gavrikov@gmail.com> ---
Checked-in. Thank you for contributing to eCos.
--
You are receiving this mail because:
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-06-06 20:36 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-06-05 11:36 [Bug 1001858] New: CAN driver return code patch bugzilla-daemon
2013-06-05 21:02 ` [Bug 1001858] " bugzilla-daemon
2013-06-05 21:24 ` bugzilla-daemon
2013-06-06 5:27 ` bugzilla-daemon
2013-06-06 20:36 ` bugzilla-daemon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).