From: Simon Kallweit <simon.kallweit@intefo.ch>
To: John Dallaway <john@dallaway.org.uk>
Cc: ecos-devel@ecos.sourceware.org
Subject: Re: lwip 1.3.1 testing
Date: Tue, 27 Oct 2009 13:06:00 -0000 [thread overview]
Message-ID: <4AE6F04B.3060505@intefo.ch> (raw)
In-Reply-To: <4AE5D8B7.9070809@dallaway.org.uk>
John Dallaway wrote:
> I would recommend a "radio button" approach for mutually exclusive modes
> which have associated source files. Something like:
>
> cdl_interface CYGINT_LWIP_MODES {
> display "Enabled lwIP modes"
> no_define
> requires 1 == CYGINT_LWIP_MODES
> description "This interface is used to force mutually exclusive
> selection of the available lwIP modes."
> }
> cdl_option CYGFUN_LWIP_MODE_SIMPLE {
> display "Simple mode"
> implements CYGINT_LWIP_MODES
> compile ecos/simple.c
> }
> cdl_option CYGFUN_LWIP_MODE_SEQUENTIAL {
> display "Sequential mode"
> implements CYGINT_LWIP_MODES
> compile ecos/sequential.c
> }
>
>> The same applies to sio. I can add a new package CYGPKG_LWIP_SIO which
>> is required by both PPPoS and SLIPIF. I think the best place would be
>> the "APIs" section as the SIO may be also used for other purposes than
>> lwIP's internal. So a user could enable sio without using SLIPIF or PPPoS.
>
> It would be best to use another CDL interface to enable compilation of
> this code. Something like:
>
> cdl_interface CYGINT_LWIP_SIO_REQUIRED {
> no_define
> display "Items requiring lwIP serial operations"
> description "Items requiring use of the lwIP serial operations code
> should implement this interface."
> }
> cdl_option CYGFUN_LWIP_SIO {
> display "Serial operations support"
> calculated { CYGINT_LWIP_SIO_REQUIRED > 0 }
> compile ecos/sio.c
> }
> cdl_component CYGPKG_LWIP_SLIP {
> implements CYGINT_LWIP_SIO_REQUIRED
> compile ...
> ...
> }
> cdl_component CYGPKG_LWIP_PPP {
> implements CYGINT_LWIP_SIO_REQUIRED
> compile ...
> ...
> }
>
> This is a little more complicated than a simple "requires
> CYGFUN_LWIP_SIO" but ensures that CYGFUN_LWIP_SIO becomes disabled when
> the number of components requiring it falls to zero.
I have adapted to CDL to reflect your recommendations. The new version
can be fetched from
http://download.westlicht.ch/lwip-20091027.tar.gz
> I thought we had concluded that we should treat lwIP PPP as a separate
> project which would require liaison with the upstream lwIP
> maintainer(s). Is there anyone else in the eCos community who is able
> and willing to work on this?
True. I just wanted to point out that in it's current state PPP can only
be used with simple mode.
>>> One minor point: It would be very useful for the stack to report its own
>>> IP address on the diagnostic channel.
>> I'll try to implement this. I guess you're mainly talking about DHCP IPs
>> right?
>
> Yes, although it might sometimes also be helpful to confirm a static IP
> address.
I have implemented reporting of the netif configuration for both static
configuration and DHCP on the interfaces loopif, slipif and eth. This is
configurable by CYGFUN_LWIP_SHOW_NETIF_CONFIG which is now enabled by
default.
Simon
next prev parent reply other threads:[~2009-10-27 13:06 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-21 7:11 Simon Kallweit
2009-08-21 7:43 ` John Dallaway
2009-08-21 9:12 ` Edgar Grimberg
2009-08-21 18:43 ` Sergei Gavrikov
2009-08-24 20:18 ` Sergei Gavrikov
2009-08-25 6:09 ` Simon Kallweit
2009-08-25 7:41 ` Simon Kallweit
2009-08-25 12:08 ` Sergei Gavrikov
2009-08-25 20:33 ` Sergei Gavrikov
2009-08-26 6:38 ` Simon Kallweit
2009-08-26 8:43 ` Sergei Gavrikov
2009-08-26 20:46 ` Sergei Gavrikov
2009-08-27 7:17 ` Simon Kallweit
2009-08-27 8:03 ` Sergei Gavrikov
2009-10-25 16:46 ` John Dallaway
2009-10-26 13:00 ` Simon Kallweit
2009-10-26 13:54 ` John Dallaway
2009-10-26 14:29 ` Simon Kallweit
2009-10-26 17:13 ` John Dallaway
2009-10-27 13:06 ` Simon Kallweit [this message]
2009-11-20 10:24 ` John Dallaway
2009-12-07 13:41 ` Simon Kallweit
2009-12-17 10:45 ` John Dallaway
2010-01-19 12:07 ` John Dallaway
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AE6F04B.3060505@intefo.ch \
--to=simon.kallweit@intefo.ch \
--cc=ecos-devel@ecos.sourceware.org \
--cc=john@dallaway.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).