Re: lwip 1.3.2 port

[John Dallaway <john@dallaway.org.uk>]

Hi Simon

Simon Kallweit wrote:

> Ok, I merged the 1.3.2 stable code and did a few quick tests (the
> changes are not huge). The tarball is at
> http://download.westlicht.ch/lwip-20100122.tar.gz

Some initial comments based mainly on diffs against the upstream lwIP
1.3.2 sources and the eCos lwIP 1.1.1 port:

a) On the whole, the upstream sources have very little modification.
That's good news for future updates. Is it strictly necessary to move
the include/ipv4/ headers into include/ as part of the eCos port? This
seems like unnecessary effort and will also make it more difficult to
support IPv6 in the future.

b) Closure of the extern "C" block seems to be missing in network.h.

c) There are a lot of small changes under src/netif/ppp/ including
function renaming. I understand that you have your own PPP requirements
to consider but I think we should stick closer to the master sources for
the CVS check-in. Unless your changes have already been accepted upstream?

I hope to look at the CDL and run up some tests over the weekend.

John Dallaway
eCos maintainer