From: John Dallaway <john@dallaway.org.uk>
To: Simon Kallweit <simon.kallweit@intefo.ch>
Cc: eCos developers <ecos-devel@ecos.sourceware.org>
Subject: Re: lwip 1.3.2 port
Date: Fri, 22 Jan 2010 18:51:00 -0000 [thread overview]
Message-ID: <4B59F3BB.3000800@dallaway.org.uk> (raw)
In-Reply-To: <4B59B98F.5010106@intefo.ch>
Hi Simon
Simon Kallweit wrote:
> Ok, I merged the 1.3.2 stable code and did a few quick tests (the
> changes are not huge). The tarball is at
> http://download.westlicht.ch/lwip-20100122.tar.gz
Some initial comments based mainly on diffs against the upstream lwIP
1.3.2 sources and the eCos lwIP 1.1.1 port:
a) On the whole, the upstream sources have very little modification.
That's good news for future updates. Is it strictly necessary to move
the include/ipv4/ headers into include/ as part of the eCos port? This
seems like unnecessary effort and will also make it more difficult to
support IPv6 in the future.
b) Closure of the extern "C" block seems to be missing in network.h.
c) There are a lot of small changes under src/netif/ppp/ including
function renaming. I understand that you have your own PPP requirements
to consider but I think we should stick closer to the master sources for
the CVS check-in. Unless your changes have already been accepted upstream?
I hope to look at the CDL and run up some tests over the weekend.
John Dallaway
eCos maintainer
next prev parent reply other threads:[~2010-01-22 18:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <73f9997f0907192203h77494e62u58b44ccfc7a738f4@mail.gmail.com>
[not found] ` <4A65B8AE.8090204@martinlaabs.de>
[not found] ` <73f9997f0907212153i743cfc7as86d2a1205c5dc7ab@mail.gmail.com>
[not found] ` <73f9997f0907220421y145a62c3lb2728a132474c900@mail.gmail.com>
[not found] ` <4A66F7E0.4050703@intefo.ch>
[not found] ` <73f9997f1001220342h7bc1c79cl7180a184bee867f3@mail.gmail.com>
2010-01-22 12:54 ` Simon Kallweit
2010-01-22 13:31 ` John Dallaway
2010-01-22 14:43 ` Simon Kallweit
2010-01-22 18:51 ` John Dallaway [this message]
2010-01-23 11:57 ` Simon Kallweit
2010-01-23 14:04 ` John Dallaway
2010-01-23 15:46 ` Simon Kallweit
2010-01-25 11:44 ` John Dallaway
2010-01-25 16:35 ` Simon Kallweit
2011-05-08 8:11 ` lwIP 1.4.0 port planning [ was Re: lwip 1.3.2 port ] John Dallaway
2011-06-07 20:28 ` Ilija Kocho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B59F3BB.3000800@dallaway.org.uk \
--to=john@dallaway.org.uk \
--cc=ecos-devel@ecos.sourceware.org \
--cc=simon.kallweit@intefo.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).