From: John Dallaway <john@dallaway.org.uk>
To: Simon Kallweit <simon.kallweit@intefo.ch>
Cc: eCos developers <ecos-devel@ecos.sourceware.org>
Subject: Re: lwip 1.3.2 port
Date: Sat, 23 Jan 2010 14:04:00 -0000 [thread overview]
Message-ID: <4B5B01F5.6060207@dallaway.org.uk> (raw)
In-Reply-To: <4B5AE3FF.4010708@intefo.ch>
Hi Simon
Simon Kallweit wrote:
> John Dallaway schrieb:
>> Hi Simon
>>
>> Simon Kallweit wrote:
>>
>>> Ok, I merged the 1.3.2 stable code and did a few quick tests (the
>>> changes are not huge). The tarball is at
>>> http://download.westlicht.ch/lwip-20100122.tar.gz
>>>
>>
>> Some initial comments based mainly on diffs against the upstream lwIP
>> 1.3.2 sources and the eCos lwIP 1.1.1 port:
>>
>> a) On the whole, the upstream sources have very little modification.
>> That's good news for future updates. Is it strictly necessary to move
>> the include/ipv4/ headers into include/ as part of the eCos port? This
>> seems like unnecessary effort and will also make it more difficult to
>> support IPv6 in the future.
>
> I'll see if we can change that.
Looking at this in more detail, it appears that the only way to preserve
the upstream directory layout would be to add "-I$(PREFIX)/include/ipv4"
to CYGBLD_GLOBAL_CFLAGS. Otherwise, other eCos packages will not find
the IPv4-specific headers when #including netif.h (for example). Perhaps
it is better to move the IPv4 header files as you have done already. We
can think again for a future lwIP import if the IPv6 support moves
beyond "experimental" status.
>> c) There are a lot of small changes under src/netif/ppp/ including
>> function renaming. I understand that you have your own PPP requirements
>> to consider but I think we should stick closer to the master sources for
>> the CVS check-in. Unless your changes have already been accepted
>> upstream?
>
> Well, yesterday night I have checked the lwip HEAD, and it looks like
> there has been lots of work done in the ppp departement. It now supports
> polling and multi-threaded support out of the box. So it might be
> considerable to directly use the current HEAD for inclusion into eCos
> and keep it updated with the lwip repository until we hit the next
> stable release. Backporting the ppp changes to the 1.3.2 codebase is a
> bit troublesome as the internal timeout framework has changed a bit and
> we would have to backport this too. I would pledge for the use of the
> 1.4.0 development tree. What do you think about this?
We always seem to be waiting for the next version of lwIP. :-)
At this stage, I would favour an initial check-in of something close to
lwIP 1.3.2 followed by an update of the PPP code from the lwIP HEAD as
time permits.
John Dallaway
next prev parent reply other threads:[~2010-01-23 14:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <73f9997f0907192203h77494e62u58b44ccfc7a738f4@mail.gmail.com>
[not found] ` <4A65B8AE.8090204@martinlaabs.de>
[not found] ` <73f9997f0907212153i743cfc7as86d2a1205c5dc7ab@mail.gmail.com>
[not found] ` <73f9997f0907220421y145a62c3lb2728a132474c900@mail.gmail.com>
[not found] ` <4A66F7E0.4050703@intefo.ch>
[not found] ` <73f9997f1001220342h7bc1c79cl7180a184bee867f3@mail.gmail.com>
2010-01-22 12:54 ` Simon Kallweit
2010-01-22 13:31 ` John Dallaway
2010-01-22 14:43 ` Simon Kallweit
2010-01-22 18:51 ` John Dallaway
2010-01-23 11:57 ` Simon Kallweit
2010-01-23 14:04 ` John Dallaway [this message]
2010-01-23 15:46 ` Simon Kallweit
2010-01-25 11:44 ` John Dallaway
2010-01-25 16:35 ` Simon Kallweit
2011-05-08 8:11 ` lwIP 1.4.0 port planning [ was Re: lwip 1.3.2 port ] John Dallaway
2011-06-07 20:28 ` Ilija Kocho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B5B01F5.6060207@dallaway.org.uk \
--to=john@dallaway.org.uk \
--cc=ecos-devel@ecos.sourceware.org \
--cc=simon.kallweit@intefo.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).