From: Gary Thomas <gary@mlbassoc.com>
To: Leandro Fanzone <leandro@hasar.com>
Cc: eCos Discussion <ecos-discuss@ecos.sourceware.org>
Subject: Re: [ECOS] HAL_*_STRING
Date: Wed, 15 Jun 2005 14:45:00 -0000 [thread overview]
Message-ID: <1118846730.13965.122.camel@hermes> (raw)
In-Reply-To: <42B03AFD.8040106@hasar.com>
On Wed, 2005-06-15 at 11:28 -0300, Leandro Fanzone wrote:
> Hello,
> I'm using ecos 2.0 under x86, and tried to use the HAL_*_STRING
> macros, both for reading and writing. They don't work properly; the
> assembly output shows that they lack the rep instruction preceding the
> insb/outsb instructions. So the macros would be:
>
> #define HAL_READ_UINT8_STRING( _register_, _buf_, _count_) \
> CYG_MACRO_START \
> asm volatile ( "rep insb" \
> : \
> : "c" (_count_), "d"(_register_), "D"(_buf_) \
> ); \
> CYG_MACRO_END
>
> #define HAL_WRITE_UINT8_STRING( _register_, _buf_, _count_) \
> CYG_MACRO_START \
> asm volatile ( "rep outsb" \
> : \
> : "c" (_count_), "d"(_register_), "S"(_buf_) \
> ); \
> CYG_MACRO_END
>
> The same thing for the 16 bit and 32 bit versions.
> Regards,
These macros are only defined as a matter of reference (and then only
by a few HALs since they are not used by the kernel). In any case,
it makes sense to correct them.
Could you send a proper patch for this to ecos-patches@sourceware.org,
please? Include the changes for all versions (8/16/32).
Thanks
--
------------------------------------------------------------
Gary Thomas | Consulting for the
MLB Associates | Embedded world
------------------------------------------------------------
--
Before posting, please read the FAQ: http://ecos.sourceware.org/fom/ecos
and search the list archive: http://ecos.sourceware.org/ml/ecos-discuss
prev parent reply other threads:[~2005-06-15 14:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-15 14:32 Leandro Fanzone
2005-06-15 14:45 ` Gary Thomas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1118846730.13965.122.camel@hermes \
--to=gary@mlbassoc.com \
--cc=ecos-discuss@ecos.sourceware.org \
--cc=leandro@hasar.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).