From: Andrew Lunn <andrew@lunn.ch>
To: Hans Rosenfeld <rosenfeld@grumpf.hope-2000.org>
Cc: Andrew Lunn <andrew@lunn.ch>, ecos-discuss@ecos.sourceware.org
Subject: Re: [ECOS] Re: LPC2xxx patch for support of vectored interrupt controller
Date: Wed, 22 Aug 2007 11:12:00 -0000 [thread overview]
Message-ID: <20070822111216.GL31057@lunn.ch> (raw)
In-Reply-To: <20070822105132.GF2126@grumpf.hope-2000.org>
On Wed, Aug 22, 2007 at 12:51:32PM +0200, Hans Rosenfeld wrote:
> On Wed, Aug 22, 2007 at 12:06:26PM +0200, Andrew Lunn wrote:
> > I wanted to avoid _0 and _1 because it may make reader of the code
> > think they have the value of 0 and 1! If a reading is interested in
> > the value, using A and B makes the reader go looking for the actual
> > value, rather than assume they are 0 and 1.
>
> Yes, that was bad style on my part.
>
> > In the code i would replace 0 with CYGNUM_KERNEL_INTR_TEST_PRIO_A and
> > 1 with CYGNUM_KERNEL_INTR_TEST_PRIO_B, since the defaults set them to
> > these values.
>
> Maybe we should have CYGNUM_KERNEL_INTR_TEST_PRIO_C, too. The tests
> create three interrupts.
O.K.
Could your produce a patch which contains all these changes and a
ChangeLog entry in both the Kernel package and the HAL.
Thanks
Andrew
--
Before posting, please read the FAQ: http://ecos.sourceware.org/fom/ecos
and search the list archive: http://ecos.sourceware.org/ml/ecos-discuss
next prev parent reply other threads:[~2007-08-22 11:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <21907044.603801184047861289.JavaMail.servlet@kundenserver>
[not found] ` <20070817140209.GA26081@grumpf.hope-2000.org>
[not found] ` <20070817171322.GB26081@grumpf.hope-2000.org>
[not found] ` <20070820151336.GA1125@grumpf.hope-2000.org>
[not found] ` <20070822082451.GF31057@lunn.ch>
[not found] ` <20070822084026.GA2126@grumpf.hope-2000.org>
2007-08-22 9:18 ` Andrew Lunn
2007-08-22 9:53 ` Hans Rosenfeld
2007-08-22 10:06 ` Andrew Lunn
2007-08-22 10:52 ` Hans Rosenfeld
2007-08-22 11:12 ` Andrew Lunn [this message]
2007-08-22 13:47 ` Hans Rosenfeld
2007-08-22 18:14 ` [ECOS] Getting started with ecos Scott Moore
2007-08-22 18:23 ` Andrew Lunn
2007-08-22 18:49 ` Scott Moore
2007-08-22 19:32 ` Andrew Lunn
2007-08-22 19:41 ` Scott Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070822111216.GL31057@lunn.ch \
--to=andrew@lunn.ch \
--cc=ecos-discuss@ecos.sourceware.org \
--cc=rosenfeld@grumpf.hope-2000.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).