From: Andrew Lunn <andrew@lunn.ch>
To: ?yvind Harboe <oyvind.harboe@zylin.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
eCos Disuss <ecos-discuss@ecos.sourceware.org>
Subject: [ECOS] Re: Check for illegal address range in io/flash
Date: Tue, 11 Dec 2007 13:51:00 -0000 [thread overview]
Message-ID: <20071211135137.GG30586@lunn.ch> (raw)
In-Reply-To: <c09652430712110209t7fd2cab9va31087a52c7d2895@mail.gmail.com>
On Tue, Dec 11, 2007 at 11:09:40AM +0100, ?yvind Harboe wrote:
> On Dec 11, 2007 11:03 AM, Andrew Lunn <andrew@lunn.ch> wrote:
> >
> > > I mainly want the busted check in flash_erase() to be removed.
> > > ASSERT's are probably fine.
> >
What is actually wrong with this check?
I think it is trying to deal with flash which are placed at the very
top of memory. The last valid byte is 0xffffffff. However is you try
to erase 0xffff0000 with length 0x10000, which is valid, end_addr
becomes 0x0 and things probably go wrong. This code i think it trying
to spot this and set end_addr to 0xffffffff.
I don't want to remove this until i fully understand what is causing
your problem and how this code is wrong. Please could you explain what
you are seeing.
Thanks
Andrew
--
Before posting, please read the FAQ: http://ecos.sourceware.org/fom/ecos
and search the list archive: http://ecos.sourceware.org/ml/ecos-discuss
next parent reply other threads:[~2007-12-11 13:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <c09652430712110102x684bcd2apd276cb0ff287caac@mail.gmail.com>
[not found] ` <20071211094252.GD30586@lunn.ch>
[not found] ` <c09652430712110149t4e157058r3a1a579c4330ac@mail.gmail.com>
[not found] ` <20071211100356.GF30586@lunn.ch>
[not found] ` <c09652430712110209t7fd2cab9va31087a52c7d2895@mail.gmail.com>
2007-12-11 13:51 ` Andrew Lunn [this message]
2007-12-11 14:13 ` Øyvind Harboe
2007-12-11 14:28 ` Gary Thomas
2007-12-11 14:38 ` Øyvind Harboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071211135137.GG30586@lunn.ch \
--to=andrew@lunn.ch \
--cc=ecos-discuss@ecos.sourceware.org \
--cc=oyvind.harboe@zylin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).