[ECOS] small bug in aeb_serial driver

[ECOS] small bug in aeb_serial driver

[Dave Airlie]

Hi,
	I spotted a bug in 1.2.1 arm AEB serial driver that is still in
CVS... the patch below fixes it... the isr symbol is a #define in
serial.h, so like is done for lsr earlier in the file I've put the _
before the real one...

all small letter #defines are not nice things 

this bug doesn't break anything but it does confuse things  when reading
the code..

Dave.

Index: aeb_serial.c
===================================================================
RCS file: /cvs/ecos/ecos/packages/io/serial/current/src/arm/aeb_serial.c,v
retrieving revision 1.5
diff -r1.5 aeb_serial.c
309,311c309,311
<     unsigned char isr;
<     isr = port->isr & 0x0E;
<     if (isr == ISR_Tx) {
---
>     unsigned char _isr;
>     _isr = port->isr & 0x0E;
>     if (_isr == ISR_Tx) {
313c313
<     } else if (isr == ISR_Rx) {
---
>     } else if (_isr == ISR_Rx) {



-- 
		David Airlie, Software Engineer
Drua Technologies Ltd, Innovation Centre, National Tech Park, Limerick.
   t: +353-61-503075 / f: +353-61-338065 / David.Airlie@drua.ie

Re: [ECOS] small bug in aeb_serial driver

[Jonathan Larmour]

Dave Airlie wrote:
> 
> Hi,
>         I spotted a bug in 1.2.1 arm AEB serial driver that is still in
> CVS... the patch below fixes it... the isr symbol is a #define in
> serial.h, so like is done for lsr earlier in the file I've put the _
> before the real one...
> 
> all small letter #defines are not nice things
> 
> this bug doesn't break anything but it does confuse things  when reading
> the code..

Thanks for the patch, if you don't mind I think I will fix the real problem
instead - the lower-case #defines in aeb_serial.h.

I'd be grateful if someone else could submit a patch for the other drivers
in a similar way (see anon CVS).

Jifl
-- 
Red Hat, 35 Cambridge Place, Cambridge, UK. CB2 1NS  Tel: +44 (1223) 728762
"Plan to be spontaneous tomorrow."  ||  These opinions are all my own fault