RE: [ECOS] pc_serial fifo + hanging fixes

RE: [ECOS] pc_serial fifo + hanging fixes

[Fabrice Gautier]

> -----Original Message-----
> From: Rolf Manderscheid [ mailto:rvm@yottayotta.com ]
> Subject: [ECOS] pc_serial fifo + hanging fixes
> 
>    I think the declaration ought to be:
> 	cyg_uint8 pc_inb(int port);

Agreed, seems logical... and if we really want to read a signed value the
compiler should warn us if we don't have the correct transtyping

-- 
Fabrice Gautier
fabrice_gautier@sdesigns.com 

[ECOS] kernel tests memvar1 and kmemvar1

[Chris Morrow]

Both of the kernel tests memvar1 and kmemvar1 have a routine

static void check_in_mp0(cyg_uint8 *p, cyg_int32 size)
{
    CYG_TEST_CHECK(NULL != p,
                   "Allocation failed");
    CYG_TEST_CHECK(mem[0] <= p && p+size < mem[1],
                   "Block outside memory pool");
}

I believe the second test should be

CYG_TEST_CHECK(mem[0] <= p && p+size <= mem[1],
                   "Block outside memory pool");

The upper bound should allow the equal case, or
perhaps even better

CYG_TEST_CHECK(mem[0] <= p && p[size - 1] < mem[1],
                   "Block outside memory pool");

-- 
Chris Morrow	YottaYotta Inc.
email:		cmorrow@yottayotta.com
phone:		(780) 439 9000 ext 227
web:		http://www.yottayotta.com

Re: [ECOS] kernel tests memvar1 and kmemvar1

[Chris Morrow]

 Doh!.

This should be

CYG_TEST_CHECK(mem[0] <= p && &p[size - 1] < mem[1],
                    "Block outside memory pool");


Chris Morrow wrote:
> 
> CYG_TEST_CHECK(mem[0] <= p && p[size - 1] < mem[1],
>                    "Block outside memory pool");
> 

-- 
Chris Morrow	YottaYotta Inc.
email:		cmorrow@yottayotta.com
phone:		(780) 439 9000 ext 227
web:		http://www.yottayotta.com