From: Jonathan Larmour <jlarmour@redhat.com>
To: Grant Edwards <grante@visi.com>
Cc: ecos-discuss@sources.redhat.com, Gary Thomas <gthomas@redhat.com>
Subject: Re: [ECOS] MS_TICKS() revisited
Date: Fri, 09 Feb 2001 12:03:00 -0000 [thread overview]
Message-ID: <3A844D11.4C910A3D@redhat.com> (raw)
In-Reply-To: <20010209140122.A4898@visi.com>
Grant Edwards wrote:
>
> On Fri, Feb 09, 2001 at 07:50:04PM +0000, Jonathan Larmour wrote:
>
> > Thanks for the patch. One query before I apply it:
> >
> > +#if !defined(CYGPKG_REDBOOT_NETWORKING)
> > +#define MS_TICKS_DELAY() hal_delay_us(1000)
> > +#endif
> > +
> >
> > Any reason this isn't do_ms_tick() ?
>
> IIRC, I was thinking at the time that do_ms_tick() was part of
> the networking package. It isn't, so it probably should be
> do_ms_tick(). Now that I think of it, it might be a better
> idea to move the definitions for MS_TICKS() and
> MS_TICKS_DELAY() from net.h into a more general spot like
> redboot.h. Then we don't need that chunk at all.
I think that would be fine. If Gary T also agrees (CC'd) could you resubmit
your patch with that change?
Thanks!
Jifl
--
Red Hat, Rustat House, Clifton Road, Cambridge, UK. Tel: +44 (1223) 271062
Maybe this world is another planet's Hell -Aldous Huxley || Opinions==mine
next prev parent reply other threads:[~2001-02-09 12:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-02-09 11:14 Grant Edwards
2001-02-09 11:50 ` Jonathan Larmour
2001-02-09 11:57 ` Grant Edwards
2001-02-09 12:03 ` Jonathan Larmour [this message]
2001-02-09 12:12 ` Grant Edwards
2001-02-09 14:03 ` Jonathan Larmour
2001-02-09 14:04 ` Grant Edwards
2001-02-11 12:18 ` Gary Thomas
2001-02-12 7:30 ` [ECOS] " Grant Edwards
2001-02-12 7:33 ` Gary Thomas
2001-02-12 9:55 ` Jonathan Larmour
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3A844D11.4C910A3D@redhat.com \
--to=jlarmour@redhat.com \
--cc=ecos-discuss@sources.redhat.com \
--cc=grante@visi.com \
--cc=gthomas@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).