public inbox for ecos-discuss@sourceware.org
 help / color / mirror / Atom feed
* [ECOS] dl_edb7xxx patch for cygwin
@ 2001-03-26  9:32 Lewin A.R.W. Edwards
  2001-03-27  7:05 ` Jonathan Larmour
  0 siblings, 1 reply; 4+ messages in thread
From: Lewin A.R.W. Edwards @ 2001-03-26  9:32 UTC (permalink / raw)
  To: ecos-discuss

I located the problem, it was a dumb mistake on my part. With the "flush" 
code commented out, dl_edb7xxx works OK in cygwin, albeit with some 
erroneous count values (however I seem to remember these counts being wrong 
under Linux as well, so that's just a downloader bug).

Is this worth submitting as a patch? I can't see any significant loss of 
amenity from these patches.
=== Lewin A.R.W. Edwards (Embedded Engineer)
Work: http://www.digi-frame.com/
Personal: http://www.zws.com/ and http://www.larwe.com/

"Und setzet ihr nicht das Leben ein,
Nie wird euch das Leben gewonnen sein."

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [ECOS] dl_edb7xxx patch for cygwin
  2001-03-26  9:32 [ECOS] dl_edb7xxx patch for cygwin Lewin A.R.W. Edwards
@ 2001-03-27  7:05 ` Jonathan Larmour
  2001-03-27 16:09   ` Lewin A.R.W. Edwards
  0 siblings, 1 reply; 4+ messages in thread
From: Jonathan Larmour @ 2001-03-27  7:05 UTC (permalink / raw)
  To: Lewin A.R.W. Edwards; +Cc: ecos-discuss

"Lewin A.R.W. Edwards" wrote:
> 
> I located the problem, it was a dumb mistake on my part. With the "flush"
> code commented out, dl_edb7xxx works OK in cygwin, albeit with some
> erroneous count values (however I seem to remember these counts being wrong
> under Linux as well, so that's just a downloader bug).
> 
> Is this worth submitting as a patch? I can't see any significant loss of
> amenity from these patches.

If you wrap the changes in #ifdef __CYGWIN__ I'll certainly be happy to
apply them.

Jifl
-- 
Red Hat, Rustat House, Clifton Road, Cambridge, UK. Tel: +44 (1223) 271062
Maybe this world is another planet's Hell -Aldous Huxley || Opinions==mine

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [ECOS] dl_edb7xxx patch for cygwin
  2001-03-27  7:05 ` Jonathan Larmour
@ 2001-03-27 16:09   ` Lewin A.R.W. Edwards
  2001-03-27 16:41     ` Jonathan Larmour
  0 siblings, 1 reply; 4+ messages in thread
From: Lewin A.R.W. Edwards @ 2001-03-27 16:09 UTC (permalink / raw)
  To: Jonathan Larmour; +Cc: ecos-discuss

Hi Jonathan,

> > Is this worth submitting as a patch? I can't see any significant loss of
> > amenity from these patches.
>
>If you wrap the changes in #ifdef __CYGWIN__ I'll certainly be happy to
>apply them.

OK, how do I prepare and submit the patches? I may as well look at a couple 
of other little things while I'm in there.

=== Lewin A.R.W. Edwards (Embedded Engineer)
Work: http://www.digi-frame.com/
Personal: http://www.zws.com/ and http://www.larwe.com/

"Und setzet ihr nicht das Leben ein,
Nie wird euch das Leben gewonnen sein."

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [ECOS] dl_edb7xxx patch for cygwin
  2001-03-27 16:09   ` Lewin A.R.W. Edwards
@ 2001-03-27 16:41     ` Jonathan Larmour
  0 siblings, 0 replies; 4+ messages in thread
From: Jonathan Larmour @ 2001-03-27 16:41 UTC (permalink / raw)
  To: Lewin A.R.W. Edwards; +Cc: ecos-discuss

"Lewin A.R.W. Edwards" wrote:
> 
> Hi Jonathan,
> 
> > > Is this worth submitting as a patch? I can't see any significant loss of
> > > amenity from these patches.
> >
> >If you wrap the changes in #ifdef __CYGWIN__ I'll certainly be happy to
> >apply them.
> 
> OK, how do I prepare and submit the patches? I may as well look at a couple
> of other little things while I'm in there.

I'm not quite sure what you mean. But doing a "cvs diff -u -p" against
current cvs is the way to generate them. Include a ChangeLog entry as well,
but just include that as text, not as part of the diff.

I should warn you that if changes are large we'll need a copyright
assignment.

Jifl
-- 
Red Hat, Rustat House, Clifton Road, Cambridge, UK. Tel: +44 (1223) 271062
Maybe this world is another planet's Hell -Aldous Huxley || Opinions==mine

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2001-03-27 16:41 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2001-03-26  9:32 [ECOS] dl_edb7xxx patch for cygwin Lewin A.R.W. Edwards
2001-03-27  7:05 ` Jonathan Larmour
2001-03-27 16:09   ` Lewin A.R.W. Edwards
2001-03-27 16:41     ` Jonathan Larmour

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).