* [ECOS] Confirmed error in eth_drv.c
@ 2001-08-20 9:47 Trenton D. Adams
2001-08-20 9:56 ` Gary Thomas
2001-08-20 9:59 ` Jonathan Larmour
0 siblings, 2 replies; 7+ messages in thread
From: Trenton D. Adams @ 2001-08-20 9:47 UTC (permalink / raw)
To: 'eCos Discussion'
I get the following output from the config tool v2.04
/cygdrive/C/MyDocuments/eCosRepository/ecos/packages/io/eth/current/src/
net/eth_drv.c
/cygdrive/C/MyDocuments/eCosRepository/ecos/packages/io/eth/current/src/
net/eth_drv.c: In function `eth_drv_send':
/cygdrive/C/MyDocuments/eCosRepository/ecos/packages/io/eth/current/src/
net/eth_drv.c:617: parse error before `static'
make[1]: Leaving directory
`/c/MyDocuments/eCosBuilds/RAMSupport_build/io/eth/current'
/cygdrive/C/MyDocuments/eCosRepository/ecos/packages/io/eth/current/src/
net/eth_drv.c:629: `mbuf_key' undeclared (first use in this function)
make: Leaving directory `/c/MyDocuments/eCosBuilds/RAMSupport_build'
/cygdrive/C/MyDocuments/eCosRepository/ecos/packages/io/eth/current/src/
net/eth_drv.c:629: (Each undeclared identifier is reported only once
/cygdrive/C/MyDocuments/eCosRepository/ecos/packages/io/eth/current/src/
net/eth_drv.c:629: for each function it appears in.)
/cygdrive/C/MyDocuments/eCosRepository/ecos/packages/io/eth/current/src/
net/eth_drv.c:504: warning: `m0' might be used uninitialized in this
function
/cygdrive/C/MyDocuments/eCosRepository/ecos/packages/io/eth/current/src/
net/eth_drv.c: At top level:
/cygdrive/C/MyDocuments/eCosRepository/ecos/packages/io/eth/current/src/
net/eth_drv.c:284: warning: `eth_drv_tx_done' used but never defined
make[1]: *** [src/net/eth_drv.o.d] Error 1
It would appear that the #ifdef _LOCK_WITH_ROM_MONITOR begins before the
end of the while loop and ends after the while loop. So, this would
naturally cause a parse error!
It appears to have been done on 2001-08-14 which is probably why I never
seen it before.
So, just move the "#endif // _LOCK_WITH_ROM_MONITOR" and "#undef
_LOCK_WITH_ROM_MONITOR" up above the end of the while loop.
Works for me now! :)
#ifdef _LOCK_WITH_ROM_MONITOR
// Unlock the driver & hardware. It can once again be safely
shared.
if (need_lock) {
cyg_drv_dsr_unlock();
#ifdef _LOCK_USING_INTERRUPTS
HAL_RESTORE_INTERRUPTS(ints);
#endif
}
} // this here appears to me to be the end of the while loop
#endif // _LOCK_WITH_ROM_MONITOR
#undef _LOCK_WITH_ROM_MONITOR
Trenton D. Adams
Extreme Engineering
#17, 6025 - 12 St. SE
Calgary, Alberta, Canada
T2H 2K1
Phone: 403 640 9494 ext-208
Fax: 403 640 9599
http://www.extremeeng.com
^ permalink raw reply [flat|nested] 7+ messages in thread* RE: [ECOS] Confirmed error in eth_drv.c
2001-08-20 9:47 [ECOS] Confirmed error in eth_drv.c Trenton D. Adams
@ 2001-08-20 9:56 ` Gary Thomas
2001-08-20 10:05 ` Trenton D. Adams
2001-08-20 9:59 ` Jonathan Larmour
1 sibling, 1 reply; 7+ messages in thread
From: Gary Thomas @ 2001-08-20 9:56 UTC (permalink / raw)
To: Trenton D. Adams; +Cc: eCos Discussion
Note: this error would only occur if you turn _LOCK_WITH_ROM_MONITOR off,
which obviously we don't think is a good idea.
I'll change the source to build in this case anyway.
On 20-Aug-2001 Trenton D. Adams wrote:
> I get the following output from the config tool v2.04
>
> /cygdrive/C/MyDocuments/eCosRepository/ecos/packages/io/eth/current/src/
> net/eth_drv.c
> /cygdrive/C/MyDocuments/eCosRepository/ecos/packages/io/eth/current/src/
> net/eth_drv.c: In function `eth_drv_send':
> /cygdrive/C/MyDocuments/eCosRepository/ecos/packages/io/eth/current/src/
> net/eth_drv.c:617: parse error before `static'
> make[1]: Leaving directory
> `/c/MyDocuments/eCosBuilds/RAMSupport_build/io/eth/current'
> /cygdrive/C/MyDocuments/eCosRepository/ecos/packages/io/eth/current/src/
> net/eth_drv.c:629: `mbuf_key' undeclared (first use in this function)
> make: Leaving directory `/c/MyDocuments/eCosBuilds/RAMSupport_build'
> /cygdrive/C/MyDocuments/eCosRepository/ecos/packages/io/eth/current/src/
> net/eth_drv.c:629: (Each undeclared identifier is reported only once
> /cygdrive/C/MyDocuments/eCosRepository/ecos/packages/io/eth/current/src/
> net/eth_drv.c:629: for each function it appears in.)
> /cygdrive/C/MyDocuments/eCosRepository/ecos/packages/io/eth/current/src/
> net/eth_drv.c:504: warning: `m0' might be used uninitialized in this
> function
> /cygdrive/C/MyDocuments/eCosRepository/ecos/packages/io/eth/current/src/
> net/eth_drv.c: At top level:
> /cygdrive/C/MyDocuments/eCosRepository/ecos/packages/io/eth/current/src/
> net/eth_drv.c:284: warning: `eth_drv_tx_done' used but never defined
> make[1]: *** [src/net/eth_drv.o.d] Error 1
>
>
> It would appear that the #ifdef _LOCK_WITH_ROM_MONITOR begins before the
> end of the while loop and ends after the while loop. So, this would
> naturally cause a parse error!
>
> It appears to have been done on 2001-08-14 which is probably why I never
> seen it before.
>
> So, just move the "#endif // _LOCK_WITH_ROM_MONITOR" and "#undef
> _LOCK_WITH_ROM_MONITOR" up above the end of the while loop.
>
> Works for me now! :)
>
>
>#ifdef _LOCK_WITH_ROM_MONITOR
> // Unlock the driver & hardware. It can once again be safely
> shared.
> if (need_lock) {
> cyg_drv_dsr_unlock();
>#ifdef _LOCK_USING_INTERRUPTS
> HAL_RESTORE_INTERRUPTS(ints);
>#endif
> }
> } // this here appears to me to be the end of the while loop
>#endif // _LOCK_WITH_ROM_MONITOR
>#undef _LOCK_WITH_ROM_MONITOR
>
>
>
> Trenton D. Adams
> Extreme Engineering
>#17, 6025 - 12 St. SE
> Calgary, Alberta, Canada
> T2H 2K1
>
> Phone: 403 640 9494 ext-208
> Fax: 403 640 9599
>
> http://www.extremeeng.com
^ permalink raw reply [flat|nested] 7+ messages in thread* RE: [ECOS] Confirmed error in eth_drv.c
2001-08-20 9:56 ` Gary Thomas
@ 2001-08-20 10:05 ` Trenton D. Adams
2001-08-20 10:12 ` Gary Thomas
0 siblings, 1 reply; 7+ messages in thread
From: Trenton D. Adams @ 2001-08-20 10:05 UTC (permalink / raw)
To: 'Gary Thomas'; +Cc: 'eCos Discussion'
I just used default settings when creating a project using Config Tool
2.04.
-----Original Message-----
From: ecos-discuss-owner@sources.redhat.com
[ mailto:ecos-discuss-owner@sources.redhat.com ] On Behalf Of Gary Thomas
Sent: Monday, August 20, 2001 11:00 AM
To: Trenton D. Adams
Cc: eCos Discussion
Subject: RE: [ECOS] Confirmed error in eth_drv.c
Note: this error would only occur if you turn _LOCK_WITH_ROM_MONITOR
off,
which obviously we don't think is a good idea.
I'll change the source to build in this case anyway.
On 20-Aug-2001 Trenton D. Adams wrote:
> I get the following output from the config tool v2.04
>
>
/cygdrive/C/MyDocuments/eCosRepository/ecos/packages/io/eth/current/src/
> net/eth_drv.c
>
/cygdrive/C/MyDocuments/eCosRepository/ecos/packages/io/eth/current/src/
> net/eth_drv.c: In function `eth_drv_send':
>
/cygdrive/C/MyDocuments/eCosRepository/ecos/packages/io/eth/current/src/
> net/eth_drv.c:617: parse error before `static'
> make[1]: Leaving directory
> `/c/MyDocuments/eCosBuilds/RAMSupport_build/io/eth/current'
>
/cygdrive/C/MyDocuments/eCosRepository/ecos/packages/io/eth/current/src/
> net/eth_drv.c:629: `mbuf_key' undeclared (first use in this function)
> make: Leaving directory `/c/MyDocuments/eCosBuilds/RAMSupport_build'
>
/cygdrive/C/MyDocuments/eCosRepository/ecos/packages/io/eth/current/src/
> net/eth_drv.c:629: (Each undeclared identifier is reported only once
>
/cygdrive/C/MyDocuments/eCosRepository/ecos/packages/io/eth/current/src/
> net/eth_drv.c:629: for each function it appears in.)
>
/cygdrive/C/MyDocuments/eCosRepository/ecos/packages/io/eth/current/src/
> net/eth_drv.c:504: warning: `m0' might be used uninitialized in this
> function
>
/cygdrive/C/MyDocuments/eCosRepository/ecos/packages/io/eth/current/src/
> net/eth_drv.c: At top level:
>
/cygdrive/C/MyDocuments/eCosRepository/ecos/packages/io/eth/current/src/
> net/eth_drv.c:284: warning: `eth_drv_tx_done' used but never defined
> make[1]: *** [src/net/eth_drv.o.d] Error 1
>
>
> It would appear that the #ifdef _LOCK_WITH_ROM_MONITOR begins before
the
> end of the while loop and ends after the while loop. So, this would
> naturally cause a parse error!
>
> It appears to have been done on 2001-08-14 which is probably why I
never
> seen it before.
>
> So, just move the "#endif // _LOCK_WITH_ROM_MONITOR" and "#undef
> _LOCK_WITH_ROM_MONITOR" up above the end of the while loop.
>
> Works for me now! :)
>
>
>#ifdef _LOCK_WITH_ROM_MONITOR
> // Unlock the driver & hardware. It can once again be safely
> shared.
> if (need_lock) {
> cyg_drv_dsr_unlock();
>#ifdef _LOCK_USING_INTERRUPTS
> HAL_RESTORE_INTERRUPTS(ints);
>#endif
> }
> } // this here appears to me to be the end of the while loop
>#endif // _LOCK_WITH_ROM_MONITOR
>#undef _LOCK_WITH_ROM_MONITOR
>
>
>
> Trenton D. Adams
> Extreme Engineering
>#17, 6025 - 12 St. SE
> Calgary, Alberta, Canada
> T2H 2K1
>
> Phone: 403 640 9494 ext-208
> Fax: 403 640 9599
>
> http://www.extremeeng.com
^ permalink raw reply [flat|nested] 7+ messages in thread* RE: [ECOS] Confirmed error in eth_drv.c
2001-08-20 10:05 ` Trenton D. Adams
@ 2001-08-20 10:12 ` Gary Thomas
2001-08-20 10:14 ` Trenton D. Adams
0 siblings, 1 reply; 7+ messages in thread
From: Gary Thomas @ 2001-08-20 10:12 UTC (permalink / raw)
To: Trenton D. Adams; +Cc: eCos Discussion
On 20-Aug-2001 Trenton D. Adams wrote:
> I just used default settings when creating a project using Config Tool
> 2.04.
>
You changed nothing? E.g. turning on GDB stubs in your code, or taking
over the virtual vector communications channel.
>
>
> -----Original Message-----
> From: ecos-discuss-owner@sources.redhat.com
> [ mailto:ecos-discuss-owner@sources.redhat.com ] On Behalf Of Gary Thomas
> Sent: Monday, August 20, 2001 11:00 AM
> To: Trenton D. Adams
> Cc: eCos Discussion
> Subject: RE: [ECOS] Confirmed error in eth_drv.c
>
>
> Note: this error would only occur if you turn _LOCK_WITH_ROM_MONITOR
> off,
> which obviously we don't think is a good idea.
>
> I'll change the source to build in this case anyway.
>
> On 20-Aug-2001 Trenton D. Adams wrote:
>> I get the following output from the config tool v2.04
>>
>>
> /cygdrive/C/MyDocuments/eCosRepository/ecos/packages/io/eth/current/src/
>> net/eth_drv.c
>>
> /cygdrive/C/MyDocuments/eCosRepository/ecos/packages/io/eth/current/src/
>> net/eth_drv.c: In function `eth_drv_send':
>>
> /cygdrive/C/MyDocuments/eCosRepository/ecos/packages/io/eth/current/src/
>> net/eth_drv.c:617: parse error before `static'
>> make[1]: Leaving directory
>> `/c/MyDocuments/eCosBuilds/RAMSupport_build/io/eth/current'
>>
> /cygdrive/C/MyDocuments/eCosRepository/ecos/packages/io/eth/current/src/
>> net/eth_drv.c:629: `mbuf_key' undeclared (first use in this function)
>> make: Leaving directory `/c/MyDocuments/eCosBuilds/RAMSupport_build'
>>
> /cygdrive/C/MyDocuments/eCosRepository/ecos/packages/io/eth/current/src/
>> net/eth_drv.c:629: (Each undeclared identifier is reported only once
>>
> /cygdrive/C/MyDocuments/eCosRepository/ecos/packages/io/eth/current/src/
>> net/eth_drv.c:629: for each function it appears in.)
>>
> /cygdrive/C/MyDocuments/eCosRepository/ecos/packages/io/eth/current/src/
>> net/eth_drv.c:504: warning: `m0' might be used uninitialized in this
>> function
>>
> /cygdrive/C/MyDocuments/eCosRepository/ecos/packages/io/eth/current/src/
>> net/eth_drv.c: At top level:
>>
> /cygdrive/C/MyDocuments/eCosRepository/ecos/packages/io/eth/current/src/
>> net/eth_drv.c:284: warning: `eth_drv_tx_done' used but never defined
>> make[1]: *** [src/net/eth_drv.o.d] Error 1
>>
>>
>> It would appear that the #ifdef _LOCK_WITH_ROM_MONITOR begins before
> the
>> end of the while loop and ends after the while loop. So, this would
>> naturally cause a parse error!
>>
>> It appears to have been done on 2001-08-14 which is probably why I
> never
>> seen it before.
>>
>> So, just move the "#endif // _LOCK_WITH_ROM_MONITOR" and "#undef
>> _LOCK_WITH_ROM_MONITOR" up above the end of the while loop.
>>
>> Works for me now! :)
>>
>>
>>#ifdef _LOCK_WITH_ROM_MONITOR
>> // Unlock the driver & hardware. It can once again be safely
>> shared.
>> if (need_lock) {
>> cyg_drv_dsr_unlock();
>>#ifdef _LOCK_USING_INTERRUPTS
>> HAL_RESTORE_INTERRUPTS(ints);
>>#endif
>> }
>> } // this here appears to me to be the end of the while loop
>>#endif // _LOCK_WITH_ROM_MONITOR
>>#undef _LOCK_WITH_ROM_MONITOR
>>
>>
>>
>> Trenton D. Adams
>> Extreme Engineering
>>#17, 6025 - 12 St. SE
>> Calgary, Alberta, Canada
>> T2H 2K1
>>
>> Phone: 403 640 9494 ext-208
>> Fax: 403 640 9599
>>
>> http://www.extremeeng.com
^ permalink raw reply [flat|nested] 7+ messages in thread* RE: [ECOS] Confirmed error in eth_drv.c
2001-08-20 10:12 ` Gary Thomas
@ 2001-08-20 10:14 ` Trenton D. Adams
2001-08-20 10:18 ` Gary Thomas
0 siblings, 1 reply; 7+ messages in thread
From: Trenton D. Adams @ 2001-08-20 10:14 UTC (permalink / raw)
To: 'Gary Thomas'; +Cc: 'eCos Discussion'
I added things, but never removed anything. So if anything was disabled
it was due to a conflict. If you want, I can do it again to see what
happens!
-----Original Message-----
From: gary@chez-thomas.org [ mailto:gary@chez-thomas.org ] On Behalf Of
Gary Thomas
Sent: Monday, August 20, 2001 11:16 AM
To: Trenton D. Adams
Cc: eCos Discussion
Subject: RE: [ECOS] Confirmed error in eth_drv.c
On 20-Aug-2001 Trenton D. Adams wrote:
> I just used default settings when creating a project using Config Tool
> 2.04.
>
You changed nothing? E.g. turning on GDB stubs in your code, or taking
over the virtual vector communications channel.
>
>
> -----Original Message-----
> From: ecos-discuss-owner@sources.redhat.com
> [ mailto:ecos-discuss-owner@sources.redhat.com ] On Behalf Of Gary
Thomas
> Sent: Monday, August 20, 2001 11:00 AM
> To: Trenton D. Adams
> Cc: eCos Discussion
> Subject: RE: [ECOS] Confirmed error in eth_drv.c
>
>
> Note: this error would only occur if you turn _LOCK_WITH_ROM_MONITOR
> off,
> which obviously we don't think is a good idea.
>
> I'll change the source to build in this case anyway.
>
> On 20-Aug-2001 Trenton D. Adams wrote:
>> I get the following output from the config tool v2.04
>>
>>
>
/cygdrive/C/MyDocuments/eCosRepository/ecos/packages/io/eth/current/src/
>> net/eth_drv.c
>>
>
/cygdrive/C/MyDocuments/eCosRepository/ecos/packages/io/eth/current/src/
>> net/eth_drv.c: In function `eth_drv_send':
>>
>
/cygdrive/C/MyDocuments/eCosRepository/ecos/packages/io/eth/current/src/
>> net/eth_drv.c:617: parse error before `static'
>> make[1]: Leaving directory
>> `/c/MyDocuments/eCosBuilds/RAMSupport_build/io/eth/current'
>>
>
/cygdrive/C/MyDocuments/eCosRepository/ecos/packages/io/eth/current/src/
>> net/eth_drv.c:629: `mbuf_key' undeclared (first use in this function)
>> make: Leaving directory `/c/MyDocuments/eCosBuilds/RAMSupport_build'
>>
>
/cygdrive/C/MyDocuments/eCosRepository/ecos/packages/io/eth/current/src/
>> net/eth_drv.c:629: (Each undeclared identifier is reported only once
>>
>
/cygdrive/C/MyDocuments/eCosRepository/ecos/packages/io/eth/current/src/
>> net/eth_drv.c:629: for each function it appears in.)
>>
>
/cygdrive/C/MyDocuments/eCosRepository/ecos/packages/io/eth/current/src/
>> net/eth_drv.c:504: warning: `m0' might be used uninitialized in this
>> function
>>
>
/cygdrive/C/MyDocuments/eCosRepository/ecos/packages/io/eth/current/src/
>> net/eth_drv.c: At top level:
>>
>
/cygdrive/C/MyDocuments/eCosRepository/ecos/packages/io/eth/current/src/
>> net/eth_drv.c:284: warning: `eth_drv_tx_done' used but never defined
>> make[1]: *** [src/net/eth_drv.o.d] Error 1
>>
>>
>> It would appear that the #ifdef _LOCK_WITH_ROM_MONITOR begins before
> the
>> end of the while loop and ends after the while loop. So, this would
>> naturally cause a parse error!
>>
>> It appears to have been done on 2001-08-14 which is probably why I
> never
>> seen it before.
>>
>> So, just move the "#endif // _LOCK_WITH_ROM_MONITOR" and "#undef
>> _LOCK_WITH_ROM_MONITOR" up above the end of the while loop.
>>
>> Works for me now! :)
>>
>>
>>#ifdef _LOCK_WITH_ROM_MONITOR
>> // Unlock the driver & hardware. It can once again be safely
>> shared.
>> if (need_lock) {
>> cyg_drv_dsr_unlock();
>>#ifdef _LOCK_USING_INTERRUPTS
>> HAL_RESTORE_INTERRUPTS(ints);
>>#endif
>> }
>> } // this here appears to me to be the end of the while loop
>>#endif // _LOCK_WITH_ROM_MONITOR
>>#undef _LOCK_WITH_ROM_MONITOR
>>
>>
>>
>> Trenton D. Adams
>> Extreme Engineering
>>#17, 6025 - 12 St. SE
>> Calgary, Alberta, Canada
>> T2H 2K1
>>
>> Phone: 403 640 9494 ext-208
>> Fax: 403 640 9599
>>
>> http://www.extremeeng.com
^ permalink raw reply [flat|nested] 7+ messages in thread* RE: [ECOS] Confirmed error in eth_drv.c
2001-08-20 10:14 ` Trenton D. Adams
@ 2001-08-20 10:18 ` Gary Thomas
0 siblings, 0 replies; 7+ messages in thread
From: Gary Thomas @ 2001-08-20 10:18 UTC (permalink / raw)
To: Trenton D. Adams; +Cc: eCos Discussion
On 20-Aug-2001 Trenton D. Adams wrote:
> I added things, but never removed anything. So if anything was disabled
> it was due to a conflict. If you want, I can do it again to see what
> happens!
>
No, but I'd like to see your 'ecos.ecc' file. You can send it to me
privately.
> -----Original Message-----
> From: gary@chez-thomas.org [ mailto:gary@chez-thomas.org ] On Behalf Of
> Gary Thomas
> Sent: Monday, August 20, 2001 11:16 AM
> To: Trenton D. Adams
> Cc: eCos Discussion
> Subject: RE: [ECOS] Confirmed error in eth_drv.c
>
>
>
> On 20-Aug-2001 Trenton D. Adams wrote:
>> I just used default settings when creating a project using Config Tool
>> 2.04.
>>
>
> You changed nothing? E.g. turning on GDB stubs in your code, or taking
> over the virtual vector communications channel.
>
>>
>>
>> -----Original Message-----
>> From: ecos-discuss-owner@sources.redhat.com
>> [ mailto:ecos-discuss-owner@sources.redhat.com ] On Behalf Of Gary
> Thomas
>> Sent: Monday, August 20, 2001 11:00 AM
>> To: Trenton D. Adams
>> Cc: eCos Discussion
>> Subject: RE: [ECOS] Confirmed error in eth_drv.c
>>
>>
>> Note: this error would only occur if you turn _LOCK_WITH_ROM_MONITOR
>> off,
>> which obviously we don't think is a good idea.
>>
>> I'll change the source to build in this case anyway.
>>
>> On 20-Aug-2001 Trenton D. Adams wrote:
>>> I get the following output from the config tool v2.04
>>>
>>>
>>
> /cygdrive/C/MyDocuments/eCosRepository/ecos/packages/io/eth/current/src/
>>> net/eth_drv.c
>>>
>>
> /cygdrive/C/MyDocuments/eCosRepository/ecos/packages/io/eth/current/src/
>>> net/eth_drv.c: In function `eth_drv_send':
>>>
>>
> /cygdrive/C/MyDocuments/eCosRepository/ecos/packages/io/eth/current/src/
>>> net/eth_drv.c:617: parse error before `static'
>>> make[1]: Leaving directory
>>> `/c/MyDocuments/eCosBuilds/RAMSupport_build/io/eth/current'
>>>
>>
> /cygdrive/C/MyDocuments/eCosRepository/ecos/packages/io/eth/current/src/
>>> net/eth_drv.c:629: `mbuf_key' undeclared (first use in this function)
>>> make: Leaving directory `/c/MyDocuments/eCosBuilds/RAMSupport_build'
>>>
>>
> /cygdrive/C/MyDocuments/eCosRepository/ecos/packages/io/eth/current/src/
>>> net/eth_drv.c:629: (Each undeclared identifier is reported only once
>>>
>>
> /cygdrive/C/MyDocuments/eCosRepository/ecos/packages/io/eth/current/src/
>>> net/eth_drv.c:629: for each function it appears in.)
>>>
>>
> /cygdrive/C/MyDocuments/eCosRepository/ecos/packages/io/eth/current/src/
>>> net/eth_drv.c:504: warning: `m0' might be used uninitialized in this
>>> function
>>>
>>
> /cygdrive/C/MyDocuments/eCosRepository/ecos/packages/io/eth/current/src/
>>> net/eth_drv.c: At top level:
>>>
>>
> /cygdrive/C/MyDocuments/eCosRepository/ecos/packages/io/eth/current/src/
>>> net/eth_drv.c:284: warning: `eth_drv_tx_done' used but never defined
>>> make[1]: *** [src/net/eth_drv.o.d] Error 1
>>>
>>>
>>> It would appear that the #ifdef _LOCK_WITH_ROM_MONITOR begins before
>> the
>>> end of the while loop and ends after the while loop. So, this would
>>> naturally cause a parse error!
>>>
>>> It appears to have been done on 2001-08-14 which is probably why I
>> never
>>> seen it before.
>>>
>>> So, just move the "#endif // _LOCK_WITH_ROM_MONITOR" and "#undef
>>> _LOCK_WITH_ROM_MONITOR" up above the end of the while loop.
>>>
>>> Works for me now! :)
>>>
>>>
>>>#ifdef _LOCK_WITH_ROM_MONITOR
>>> // Unlock the driver & hardware. It can once again be safely
>>> shared.
>>> if (need_lock) {
>>> cyg_drv_dsr_unlock();
>>>#ifdef _LOCK_USING_INTERRUPTS
>>> HAL_RESTORE_INTERRUPTS(ints);
>>>#endif
>>> }
>>> } // this here appears to me to be the end of the while loop
>>>#endif // _LOCK_WITH_ROM_MONITOR
>>>#undef _LOCK_WITH_ROM_MONITOR
>>>
>>>
>>>
>>> Trenton D. Adams
>>> Extreme Engineering
>>>#17, 6025 - 12 St. SE
>>> Calgary, Alberta, Canada
>>> T2H 2K1
>>>
>>> Phone: 403 640 9494 ext-208
>>> Fax: 403 640 9599
>>>
>>> http://www.extremeeng.com
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [ECOS] Confirmed error in eth_drv.c
2001-08-20 9:47 [ECOS] Confirmed error in eth_drv.c Trenton D. Adams
2001-08-20 9:56 ` Gary Thomas
@ 2001-08-20 9:59 ` Jonathan Larmour
1 sibling, 0 replies; 7+ messages in thread
From: Jonathan Larmour @ 2001-08-20 9:59 UTC (permalink / raw)
To: Trenton D. Adams; +Cc: 'eCos Discussion'
"Trenton D. Adams" wrote:
>
> So, just move the "#endif // _LOCK_WITH_ROM_MONITOR" and "#undef
> _LOCK_WITH_ROM_MONITOR" up above the end of the while loop.
>
> Works for me now! :)
Yep. I've fixed this in anoncvs by hand too.
Jifl
--
Red Hat, Rustat House, Clifton Road, Cambridge, UK. Tel: +44 (1223) 271062
Maybe this world is another planet's Hell -Aldous Huxley || Opinions==mine
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2001-08-20 10:18 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2001-08-20 9:47 [ECOS] Confirmed error in eth_drv.c Trenton D. Adams
2001-08-20 9:56 ` Gary Thomas
2001-08-20 10:05 ` Trenton D. Adams
2001-08-20 10:12 ` Gary Thomas
2001-08-20 10:14 ` Trenton D. Adams
2001-08-20 10:18 ` Gary Thomas
2001-08-20 9:59 ` Jonathan Larmour
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).