Re: [APPROVE] __cxa_pure_virtual()

[John Dallaway <jld@ecoscentric.com>]

I have no objection to this patch for the eCos 2.0 branch.

John Dallaway

-----Original Message-----
From: Jonathan Larmour
Date: Thursday 27 Mar 2003 18:07
Subject: Re: [APPROVE] __cxa_pure_virtual()

> Bart Veer wrote:
> > I have just committed a patch to CYGPKG_INFRA to provide an
> > implementation of __cxa_pure_virtual() that is appropriate for eCos,
> > overriding the one in libsupc++.
> >
> >   http://sources.redhat.com/ml/ecos-patches/2003-03/msg00209.html
>
> No objection in principle, although I think you could add a diag_printf
> after the CYG_FAIL saying the same thing so there is some potential
> diagnostic if people don't have asserts enabled.
>
> Perhaps even
> #ifdef CYGDBG_USE_ASSERTS
> CYG_FAIL
> #else
> diag_printf
> #endif
>
> Whatever the specific implementation, the patch is worth including in
> 2.0.
>
> Jifl