From: Andrew Lunn <andrew.lunn@ascom.ch>
To: Nick Garnett <nickg@ecoscentric.com>
Cc: Andrew Lunn <andrew.lunn@ascom.ch>,
John Dallaway <john@dallaway.org.uk>,
ecos-maintainers@ecos.sourceware.org
Subject: Re: AT91EB55 and DataFlash
Date: Thu, 12 Feb 2009 14:32:00 -0000 [thread overview]
Message-ID: <20090212143209.GO24614@donkey.ma.tech.ascom.ch> (raw)
In-Reply-To: <m3skmjspby.fsf@xl5.calivar.com>
On Thu, Feb 12, 2009 at 02:27:13PM +0000, Nick Garnett wrote:
> Andrew Lunn <andrew.lunn@ascom.ch> writes:
>
> > On Thu, Feb 12, 2009 at 01:56:02PM +0100, Andrew Lunn wrote:
> > > On Thu, Feb 12, 2009 at 12:08:26PM +0000, John Dallaway wrote:
> > > > eCos maintainers
> > > >
> > > > Building RedBoot for the AT91EB55 target (eb55) is currently failing due to:
> > > >
> > > > a) CYGPKG_ERROR missing in the RedBoot .ecm files. It is required by
> > > > CYGPKG_DEVS_FLASH_ATMEL_DATAFLASH.
> > >
> > > I think this is because of the inclusion of IO_SPI in all targets
> > > which have SPI. The dataflash CDL contains:
> > >
> > > cdl_package CYGPKG_DEVS_FLASH_ATMEL_DATAFLASH {
> > > display "Atmel DataFlash parts support"
> > > description "Support for Atmel DataFlash"
> > > active_if CYGPKG_IO_SPI
> > > requires CYGPKG_ERROR
> > >
> > > I think just adding
> > >
> > > active_if CYGPKG_IO_FLASH
> >
> > Ah, not so easy afterall. From the Changelog:
> >
> > 2005-06-29 Jani Monoses <ani@iv.ro>
> >
> > * include/dataflash.h: Allow the package to be compiled without
> > io/flash. Return correct value from cyg_dataflash_get_page_count()
> >
> > It looks like the requires statement is wrong, CYGPKG_ERROR is not
> > needed by dataflash. This fixes this problem, but it then explodes
> > later.
> >
> > I think somebody from eCosCentric needs to look at this and compare
> > with there working code in their private branch.
>
> All of the redboot ECM files for our boards with dataflash contain
> CYGPKG_ERROR. CYGPKG_DEVS_FLASH_ATMEL_DATAFLASH does not, but the AT91
> SPI driver needs it.
Yep, that was were it exploded. However, it should of been at
ecosconfig time it complained. The AT91 SPI driver is missing a
requires statement for CYGPKG_ERROR. I guess the error package should
be added to all targets which use the AT91 SPI driver.
Andrew
next prev parent reply other threads:[~2009-02-12 14:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-12 12:08 John Dallaway
2009-02-12 12:56 ` Andrew Lunn
2009-02-12 13:50 ` Andrew Lunn
2009-02-12 14:23 ` John Dallaway
2009-02-12 14:31 ` Nick Garnett
2009-02-12 14:38 ` John Dallaway
2009-02-12 14:27 ` Nick Garnett
2009-02-12 14:32 ` Andrew Lunn [this message]
2009-02-12 14:43 ` Nick Garnett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090212143209.GO24614@donkey.ma.tech.ascom.ch \
--to=andrew.lunn@ascom.ch \
--cc=ecos-maintainers@ecos.sourceware.org \
--cc=john@dallaway.org.uk \
--cc=nickg@ecoscentric.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).