public inbox for
 help / color / mirror / Atom feed
Subject: [Bug 1001070] BSP for Olimex LPC-L2294-8M
Date: Tue, 09 Nov 2010 09:53:00 -0000	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Please do not reply to this email. Use the web interface provided at:

Sergei Gavrikov <> changed:

           What    |Removed                     |Added
                 CC|                            |

--- Comment #1 from Sergei Gavrikov <> 2010-11-09 09:53:26 GMT ---
Hi Jean-Francois,

I plan to work on your patch as I have similar hardware. I have only one
comment on the patch. My concern is about using new CDL option:


This CDL option (=name) is used 1) to fix the memory layout files, 2) to set
new bus timings both for RAM and NVRAM components, and 3) to select proper
FLASH parts for the hardware variant. As I said I would prefer to see in HAL
just one eCos CDL component which wraps one or more CDL options, something like
this (draft, not tested)

    display        "OLPCL2294 variant used"
    flavor         data
    default_value  { "OLPCL2294_1M" }
    legal_values   { "OLPCL2294_1M" "OLPCL2294_8M" }
    define -file system.h CYGHWR_BOARD
    description    "
        Blah, blah, blah."

        display       "External RAM size"
        flavor        data
        calculated    {
           is_substr(CYGHWR_HAL_ARM_LPC2XXX_OLPCL2294_VARIANT, "1M") ?
                 0x100000 : 0x800000
        description   "
            Blah, blah, blah."

    # More CDL options?

So, your code would use CYGHWR_BOARD_OLPCL2294_xM checks anywhere and CDL
option CYGHWR_HAL_ARM_LPC2XXX_OLPCL2294_RAMSIZE can be used in MLT only.

If you want you would add more CDL options in this component to implement your
TODOs (like overwriting  those config values for LPC BANKx registers in HAL
startup code, but, IMO, it is excessively).

Also, it will be nice to manage HAL_PLATFORM_EXTRA definition, to set its value
in either "1M" or "8M", that would show a proper hint in RedBoot (however, it
is beyond the scope your patch).

If you are familiar with CDL, can you, please, fix the patch (at least to wrap
RAMSIZE option in CDL component)? Otherwise, I would help to make some changes.


Configure bugmail:
------- You are receiving this mail because: -------
You are on the CC list for the bug.

  reply	other threads:[~2010-11-09  9:53 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-08 15:36 [Bug 1001070] New: " bugzilla-daemon
2010-11-09  9:53 ` bugzilla-daemon [this message]
2010-11-09 11:34 ` [Bug 1001070] " bugzilla-daemon
2010-11-09 11:43 ` bugzilla-daemon
2010-11-09 12:31 ` bugzilla-daemon
2010-11-22  9:02 ` bugzilla-daemon
2010-11-22  9:43 ` bugzilla-daemon
2010-11-22  9:46 ` bugzilla-daemon
2010-11-22 11:12 ` bugzilla-daemon
2010-11-22 11:33 ` bugzilla-daemon
2010-11-25 13:34 ` bugzilla-daemon
2010-11-25 13:38 ` bugzilla-daemon
2010-12-15  4:41 ` bugzilla-daemon
2010-12-15  6:43 ` bugzilla-daemon
2010-12-16 12:29 ` bugzilla-daemon
2010-12-16 12:34 ` bugzilla-daemon
2011-03-14 19:46 ` bugzilla-daemon
2011-11-08  1:15 ` bugzilla-daemon
2011-11-08  1:17 ` bugzilla-daemon
2011-11-08  1:17 ` bugzilla-daemon
2011-11-08 10:41 ` bugzilla-daemon
2011-11-08 17:08 ` bugzilla-daemon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).