From: bugzilla-daemon@bugs.ecos.sourceware.org
To: ecos-patches@ecos.sourceware.org
Subject: [Bug 1001116] Instruct lwIP to use special section for buffers and heap.
Date: Sat, 29 Jan 2011 19:49:00 -0000 [thread overview]
Message-ID: <20110129194855.12DB72F80002@mail.ecoscentric.com> (raw)
In-Reply-To: <bug-1001116-104@http.bugs.ecos.sourceware.org/>
Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001116
--- Comment #15 from Ilija Kocho <ilijak@siva.com.mk> 2011-01-29 19:48:52 GMT ---
(In reply to comment #13)
> Hi
> So far it is about the below,
> > - Concatenation or plain strings?
>
> I prefer the plain strings.
If we do not keep the other macros that depend on CYGDAT_LWIP_MEM_SECTION_NAME
then I'll be happy with plain strings. If we keep them then the concatenation
is a convenience.
Note: (my error in last CDL proposal) If we keep the macros,
CYGDAT_LWIP_MEM_SECTION_NAME can't have no_define flag.
> > IMO it would depend on resolution for section related macros proposed in
> > http://bugs.ecos.sourceware.org/attachment.cgi?id=1088 to Bug 1001114 .
> >
> > For reference, here is a digest of all code snippets as are in my current
> > build:
>
> > -----------------
> > cdl_package CYGPKG_NET_LWIP {
> > ...
> > cdl_option CYGDAT_LWIP_MEM_SECTION {
> > display "Special memory section for lwIP buffers."
> > active_if CYGDAT_LWIP_MEM_SECTION_NAME
> > requires CYGDAT_LWIP_MEM_SECTION_NAME
> > flavor data
> > calculated { "\"." . CYGDAT_LWIP_MEM_SECTION_NAME . "\"" }
> > description "..."
> > }
> > ...
> > }
>
> I dislike the above as the most users will be to see in CT a strange grayed
> data box like below:
>
> - |__) Momory options
> [ab] "Special memory section for lwIP buffers." | ".0"
>
> What's that ".0"? That's concatenation with an absent data.
Thanks for remarks, you're right, this is ugly and looks awkward.
A way to improve:
calculated { CYGDAT_LWIP_MEM_SECTION_NAME ?
"\"." . CYGDAT_LWIP_MEM_SECTION_NAME . "\"" : "none" }
or equivalent with plain strings:
calculated { CYGDAT_LWIP_MEM_SECTION_NAME ?
CYGDAT_LWIP_MEM_SECTION_NAME : "none" }
Note: Even if we end up with plain strings I would rather keep
CYGDAT_LWIP_MEM_SECTION data than bool. IMO "none" is rather descriptive.
Comments?
--
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
next prev parent reply other threads:[~2011-01-29 19:49 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bug-1001116-104@http.bugs.ecos.sourceware.org/>
2011-01-16 8:53 ` bugzilla-daemon
2011-01-16 19:53 ` bugzilla-daemon
2011-01-16 21:11 ` bugzilla-daemon
2011-01-17 9:47 ` bugzilla-daemon
2011-01-18 1:43 ` bugzilla-daemon
2011-01-18 2:00 ` bugzilla-daemon
2011-01-22 18:15 ` bugzilla-daemon
2011-01-22 18:21 ` bugzilla-daemon
2011-01-22 22:06 ` bugzilla-daemon
2011-01-24 12:46 ` bugzilla-daemon
2011-01-26 20:15 ` bugzilla-daemon
2011-01-27 18:54 ` bugzilla-daemon
2011-01-28 12:26 ` bugzilla-daemon
2011-01-28 17:52 ` bugzilla-daemon
2011-01-29 12:51 ` bugzilla-daemon
2011-01-29 14:54 ` bugzilla-daemon
2011-01-29 19:32 ` bugzilla-daemon
2011-01-29 19:49 ` bugzilla-daemon [this message]
2011-01-29 20:15 ` bugzilla-daemon
2011-01-30 10:37 ` bugzilla-daemon
2011-01-30 11:50 ` bugzilla-daemon
2011-01-30 13:00 ` bugzilla-daemon
2011-01-30 13:53 ` bugzilla-daemon
2011-01-30 14:57 ` bugzilla-daemon
2011-01-30 16:01 ` bugzilla-daemon
2011-01-30 17:15 ` bugzilla-daemon
2011-01-30 17:39 ` bugzilla-daemon
2011-01-30 18:43 ` bugzilla-daemon
2011-01-30 19:22 ` bugzilla-daemon
2011-01-30 20:12 ` bugzilla-daemon
2011-01-30 20:54 ` bugzilla-daemon
2011-01-30 21:37 ` bugzilla-daemon
2011-01-30 21:38 ` bugzilla-daemon
2011-01-30 21:42 ` bugzilla-daemon
2011-01-30 21:53 ` bugzilla-daemon
2011-01-30 22:12 ` bugzilla-daemon
2011-01-30 22:26 ` bugzilla-daemon
2011-01-30 22:37 ` bugzilla-daemon
2011-01-31 8:52 ` bugzilla-daemon
2011-01-31 9:11 ` bugzilla-daemon
2011-01-31 9:56 ` bugzilla-daemon
2011-01-31 10:00 ` bugzilla-daemon
2011-01-31 11:07 ` bugzilla-daemon
2011-01-31 12:00 ` bugzilla-daemon
2011-01-31 17:06 ` bugzilla-daemon
2011-01-31 17:39 ` bugzilla-daemon
2011-01-31 18:16 ` bugzilla-daemon
2011-01-31 18:32 ` bugzilla-daemon
2011-01-31 18:34 ` bugzilla-daemon
2011-01-31 18:34 ` bugzilla-daemon
2011-01-31 18:59 ` bugzilla-daemon
2011-01-31 20:14 ` bugzilla-daemon
2011-01-31 21:55 ` bugzilla-daemon
2011-01-31 21:57 ` bugzilla-daemon
2011-01-31 22:02 ` bugzilla-daemon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110129194855.12DB72F80002@mail.ecoscentric.com \
--to=bugzilla-daemon@bugs.ecos.sourceware.org \
--cc=ecos-patches@ecos.sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).