[Bug 1001116] Instruct lwIP to use special section for buffers and heap.

[bugzilla-daemon@bugs.ecos.sourceware.org]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001116

--- Comment #32 from Ilija Kocho <ilijak@siva.com.mk> 2011-01-30 21:53:11 GMT ---
(In reply to comment #28)
> (In reply to comment #27)
> > (In reply to comment #26)
> > > Well, let's stop on this point of survey. What do you think?
> > 
[snip]
> > Something like this?
> > 
> > --- lwip_net.tcl ---
> > 
> >     cdl_component CYGOPT_LWIP_MEM_PLF_SPEC {
> >         display         "Platform specific memory setting"
> >         flavor          none
> >         no_define  
> >         cdl_option CYGSEM_LWIP_MEM_SECTION {
> >             display "Place lwIP buffers and heap in special memory section."
> >             flavor bool
> >             default_value 1
> >             active_if CYGDAT_LWIP_MEM_SECTION_NAME
> >             description "..."
> >        }
> >    }
> 
> Ups, as I could understand your latest thing was
> 
>     default_value is_active(CYGDAT_LWIP_MEM_SECTION_NAME)
>     active_if     CYGDAT_LWIP_MEM_SECTION_NAME

Yes this is it. Sorry :( I pasted wrong snippet.

> I'm starting to hate patch-review througout $BROWSER, I am again in a mess. Do
> you *tested* this
> 
>     cdl_option CYGOPT_LWIP_MEM_SECTION {
>         default_value 1
>         active_if CYGDAT_LWIP_MEM_SECTION_NAME
> 
> or this one
> 
>     cdl_option CYGOPT_LWIP_MEM_SECTION {
>         default_value is_active(CYGDAT_LWIP_MEM_SECTION_NAME)
>         active_if     CYGDAT_LWIP_MEM_SECTION_NAME

I tested both, both work but the second one looks more appropriate in
configtool.

> Ilija, please, attach your latest and *tested* patch for review.
> 

Here it is, this time from editor. I deleted description from
CYGSEM_LWIP_MEM_SECTION since in your patch you have better.

--- lwip_net.cdl ---

    cdl_component CYGOPT_LWIP_MEM_PLF_SPEC {
        flavor none
        display "Platform/application specific memory settings"
        description "Platform or application specific settings such as
                     special memory section and memory constrains."

        cdl_option CYGSEM_LWIP_MEM_SECTION {
            display "Place lwIP buffers and heap in special memory section."
            flavor bool
            default_value is_active(CYGDAT_LWIP_MEM_SECTION_NAME)
            active_if  CYGDAT_LWIP_MEM_SECTION_NAME
            description "..."
        }                
    }

--- hal...cdl example (this was correct in previous post) ---

     cdl_option CYGDAT_LWIP_MEM_SECTION_NAME {
         flavor data
         active_if CYGPKG_NET_LWIP
         parent CYGOPT_LWIP_MEM_PLF_SPEC
         default_value { "\".ahb_bss\"" }
         legal_values { "\".ahb_bss\"" "\".ahb_0\"" }
         display "Memory section for lwIP buffers."
         description " ... Sections are provided by LPC17xx platform HAL." 
     }

--- lwipopts.h (just for completness) ----

#if defined(CYGSEM_LWIP_MEM_SECTION) && CYGSEM_LWIP_MEM_SECTION
#include <cyg/infra/cyg_type.h>
#define MEM_SECTION CYGBLD_ATTRIB_SECTION(CYGDAT_LWIP_MEM_SECTION_NAME)
#else
#define MEM_SECTION
#endif

-----------------------

> I see you prefer "one step" assigned, this is your choice and this for
> Bugzilla 1001114.

Yes. If we do not need concatenation, let's keep it simple.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.