From: bugzilla-daemon@bugs.ecos.sourceware.org
To: ecos-patches@sourceware.org
Subject: Patch_or_Contribution granted: [Bug 1001125] New HAL for the Stellaris EK-LM3S811 board
Date: Wed, 09 Feb 2011 01:25:00 -0000 [thread overview]
Message-ID: <20110209012544.83C082F78004@mail.ecoscentric.com> (raw)
In-Reply-To: <bug-1001125-0@http.bugs.ecos.sourceware.org/>
Jonathan Larmour <jifl@ecoscentric.com> has granted Patch_or_Contribution:
Bug 1001125: New HAL for the Stellaris EK-LM3S811 board
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001125
------- Additional Comments from Jonathan Larmour <jifl@ecoscentric.com>
I've scanned through the patches and nothing major has leapt out at me.
My only comments are essentially cosmetic:
You don't need the memory segments if there's only one of them, and indeed you
have (correctly) not defined CYGBLD_REDBOOT_MAX_MEM_SEGMENTS. And RedBoot
probably will never be supported anyway. So that function can just go away.
The HAL_VAR_INTERRUPT_* macros should go - if they're not defined, the code in
the arch HAL which uses them should do the right thing.
And utterly trivial: the default_ROM.ecm has "template default" in it. Your
documentation uses the minimal template, not default, so by rights the .ecm
should have "template minimal". I don't know about anyone else, but I look at
the template line of .ecm files to see what template this .ecm should be
applied to.
All in all, it's a very good quality patch. Thanks!
Jifl
parent reply other threads:[~2011-02-09 1:25 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <bug-1001125-0@http.bugs.ecos.sourceware.org/>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110209012544.83C082F78004@mail.ecoscentric.com \
--to=bugzilla-daemon@bugs.ecos.sourceware.org \
--cc=ecos-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).