[Bug 1001125] New HAL for the Stellaris EK-LM3S811 board

[Bug 1001125] New HAL for the Stellaris EK-LM3S811 board

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001125

Christophe Coutand <ecos@hotmail.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ecos-patches@ecos.sourcewar
                   |                            |e.org

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001125] New HAL for the Stellaris EK-LM3S811 board

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001125

--- Comment #4 from Christophe Coutand <ecos@hotmail.co.uk> 2011-01-23 09:07:04 GMT ---
Created an attachment (id=1100)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1100)
ADC device driver

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001125] New HAL for the Stellaris EK-LM3S811 board

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001125

Sergei Gavrikov <sergei.gavrikov@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sergei.gavrikov@gmail.com

--- Comment #5 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2011-01-23 18:46:12 GMT ---
(In reply to comment #0)
> Created an attachment (id=1096)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1096) [details]
> updated HAL
> 
> If someone wants to play around with the tiny EK-LM3S811 kit.

Hi Cristophe,

This is nice news. Now, anyone can play with cortex-m3 architecture (having no
real hardware) as QEMU supports this hardware out the box. Today I managed run
all eCos tests for the target on QEMU which were available for the 8Kb device.
ASAP, I will dive in the HAL. Thank you for this distribution.

Sergei

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001125] New HAL for the Stellaris EK-LM3S811 board

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001125

John Dallaway <john@dallaway.org.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |john@dallaway.org.uk
          Component|HAL                         |Patches and contributions

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001125] New HAL for the Stellaris EK-LM3S811 board

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001125

--- Comment #6 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2011-01-27 18:23:29 GMT ---
Hi Cristophe,

Your code looks fine. Also, thanks for the documantation. I tested a build
process and ran some tests on QEMU.  Minors (no need to repost the patch):

tabulate "arsterisks" in ChangeLogs (we use GNU ChangeLog format)

a typo (or what ?) in mlt files:

mlt.h:
#define CYGMEM_REGION_flash_SIZE (0x00008000)

mlt.ldi
flash : ORIGIN = 0x00000000, LENGTH = 0x00010000

And that's all from me. Thank you!

Sergei

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001125] New HAL for the Stellaris EK-LM3S811 board

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001125

--- Comment #7 from Christophe Coutand <ecos@hotmail.co.uk> 2011-01-27 18:53:31 GMT ---
Hi Sergei,

You are correct, the mlt.h should have:

#define CYGMEM_REGION_flash_SIZE (0x00010000)

also in i2c_lm3s.c the external definition of hal_cortexm_systick_clock is not
required and shall be removed.

__externC cyg_uint32 hal_cortexm_systick_clock;

Christophe

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001125] New HAL for the Stellaris EK-LM3S811 board

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001125

--- Comment #8 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2011-01-31 10:48:33 GMT ---
(In reply to comment #7)
> You are correct, the mlt.h should have:
> 
> #define CYGMEM_REGION_flash_SIZE (0x00010000)
> 
> also in i2c_lm3s.c the external definition of hal_cortexm_systick_clock is
> not required and shall be removed.
> 
> __externC cyg_uint32 hal_cortexm_systick_clock;

I'm sorry for the delay in response. The above has been done.

Christophe, yet more minor notes about HAL sources, but

hal/cortexm/lm3s/var/current/include/hal_cache.h:
----
The header contains many commented lines with the definitions. Do you really
need those memos? If you need it, no issue.

hal/cortexm/lm3s/lm3s8xx/current/tests/timers.c:
----

I would remove that rudiment '#if 0' from the source. Ok?

hal/cortexm/lm3s/var/current/src/lm3s_misc.c:hal_variant_init():
----

Commented #if !defined(CYG_HAL_STARTUP_RAM) looks good for me, I would
revert it back. What's wrong with it?

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001125] New HAL for the Stellaris EK-LM3S811 board

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001125

Ilija Kocho <ilijak@siva.com.mk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ilijak@siva.com.mk

--- Comment #9 from Ilija Kocho <ilijak@siva.com.mk> 2011-01-31 11:38:43 GMT ---
(In reply to comment #0)
> Created an attachment (id=1096)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1096) [details]
> updated HAL
> 
> If someone wants to play around with the tiny EK-LM3S811 kit.

Nice thing Christophe, Small is beautiful.
This port may open door to a big number of devices as nearly every manufacturer
has Cortex-M devices with 32KiB flash / 8KiB RAM (and below).

[ To decision makers ]

What about "lite" or "tiny" template?
"minimal" + kernel + some memory tuning, (like in default_ROM.ecm)

BR
Ilija

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001125] New HAL for the Stellaris EK-LM3S811 board

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001125

--- Comment #10 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2011-01-31 12:32:39 GMT ---
(In reply to comment #9)
> (In reply to comment #0)
> > Created an attachment (id=1096)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1096) [details]
> > updated HAL
> > 
> > If someone wants to play around with the tiny EK-LM3S811 kit.

Ilija Kocho wrote:

> Nice thing Christophe, Small is beautiful.  This port may open door to
> a big number of devices as nearly every manufacturer has Cortex-M
> devices with 32KiB flash / 8KiB RAM (and below).
> 
> [ To decision makers ]
> 
> What about "lite" or "tiny" template?
> "minimal" + kernel + some memory tuning, (like in default_ROM.ecm)

AFAIK, it cannot be managed only with a template. I agreed that if n00b
cannot compile "hello, world!" via diag_printf() using minimal template,
it is our pain (that is famous 32K stack size issue), also I have doubts
about ~1/2 eCos kernel tests which use stacks like STACK_SIZE_TYPICAL x
N. Ilija, it does not seem to me that all decision makers and experts on
CC list of the Bug 1001125, so, I would raise the discussion on the same
subject on ecos-devel list.

Sergei

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001125] New HAL for the Stellaris EK-LM3S811 board

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001125

--- Comment #11 from Ilija Kocho <ilijak@siva.com.mk> 2011-01-31 12:37:32 GMT ---
(In reply to comment #10)
> (In reply to comment #9)
> > (In reply to comment #0)
> > > Created an attachment (id=1096)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1096) [details]
[details]
> > > updated HAL
> > > 
> > > If someone wants to play around with the tiny EK-LM3S811 kit.
> 
> Ilija Kocho wrote:
> 
> > Nice thing Christophe, Small is beautiful.  This port may open door to
> > a big number of devices as nearly every manufacturer has Cortex-M
> > devices with 32KiB flash / 8KiB RAM (and below).
> > 
> > [ To decision makers ]
> > 
> > What about "lite" or "tiny" template?
> > "minimal" + kernel + some memory tuning, (like in default_ROM.ecm)
> 
> AFAIK, it cannot be managed only with a template. I agreed that if n00b
> cannot compile "hello, world!" via diag_printf() using minimal template,
> it is our pain (that is famous 32K stack size issue), also I have doubts
> about ~1/2 eCos kernel tests which use stacks like STACK_SIZE_TYPICAL x
> N. Ilija, it does not seem to me that all decision makers and experts on
> CC list of the Bug 1001125, so, I would raise the discussion on the same
> subject on ecos-devel list.

Yea, that's the right forum.

Ilija

> 
> Sergei

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001125] New HAL for the Stellaris EK-LM3S811 board

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001125

--- Comment #12 from Christophe Coutand <ecos@hotmail.co.uk> 2011-01-31 12:48:44 GMT ---
Hi Sergei,

All issues left are due to copy/paste from stm32 variant HAL. I can clean
hal_cache.h and fix all other small issues.

I managed to test GDB stub (useless with 8K RAM) and found a small error in
hal_lm3s_serial_getc_nonblock.

I can re-submit a complete patch if you have no further comments.

Christophe

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001125] New HAL for the Stellaris EK-LM3S811 board

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001125

--- Comment #13 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2011-01-31 13:08:47 GMT ---
(In reply to comment #12)
> Hi Sergei,
> 
> All issues left are due to copy/paste from stm32 variant HAL. I can clean
> hal_cache.h and fix all other small issues.
> 
> I managed to test GDB stub (useless with 8K RAM) and found a small error in
> hal_lm3s_serial_getc_nonblock.
> 
> I can re-submit a complete patch if you have no further comments.

I would be nice, if you can. And Christophe, could you review some multi-line
macros (there are "jumping" lines-continunation in the code). To avoid
duplication of efforts I will send you (or attach here?) fixed ChangeLogs.

Thank you,
Sergei

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001125] New HAL for the Stellaris EK-LM3S811 board

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001125

--- Comment #14 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2011-01-31 13:15:48 GMT ---
Created an attachment (id=1111)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1111)
ChangeLog.diff

lm3s: ChangeLog fixes

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001125] New HAL for the Stellaris EK-LM3S811 board

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001125

--- Comment #15 from Christophe Coutand <ecos@hotmail.co.uk> 2011-01-31 13:17:54 GMT ---
Do you have an example of the multi-line macros that are giving problems?

Thanks,
Christophe

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001125] New HAL for the Stellaris EK-LM3S811 board

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001125

--- Comment #16 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2011-01-31 13:41:14 GMT ---
(In reply to comment #15)
> Do you have an example of the multi-line macros that are giving problems?

/hal/cortexm/lm3s/var/current/include/var_io.h:
CYGHWR_HAL_LM3S_GPIO

under devs/ there are macros like

devs/i2c/cortexm/lm3s/current/include/i2c_lm3s.h:
# define CYG_LM3S_I2C_BUS(_name_, _init_fn_, _base_, _periph_, _isr_vec_,
_isr_pri_, _fdr_)       \
static lm3s_i2c_extra _name_ ## _extra = {                                     
    \

IMO, this

#define CYG_LM3S_I2C_BUS(                                       \
        _name_,                                                 \
        _init_fn_,                                              \
        _base_,                                                 \
        _periph_,                                               \
        _isr_vec_,                                              \
        _isr_pri_,                                              \
        _fdr_)                                                  \
        static lm3s_i2c_extra _name_ ## _extra = {              \

        etc.

looks better. It's good to catch such things with $PAGER, e.g.

  $ less -S super.diff
  /\\$

Christope, excuse my pedanry, please, I just thouhgt, If he will resubmit the
patch then it would be nice, if he will clean-up some issues for me :-)

Thanks!
Sergei

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001125] New HAL for the Stellaris EK-LM3S811 board

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001125

--- Comment #17 from John Dallaway <john@dallaway.org.uk> 2011-01-31 17:30:33 GMT ---
(In reply to comment #10)

> > Nice thing Christophe, Small is beautiful.  This port may open door to
> > a big number of devices as nearly every manufacturer has Cortex-M
> > devices with 32KiB flash / 8KiB RAM (and below).
> > 
> > [ To decision makers ]
> > 
> > What about "lite" or "tiny" template?
> > "minimal" + kernel + some memory tuning, (like in default_ROM.ecm)
> 
> AFAIK, it cannot be managed only with a template. I agreed that if n00b
> cannot compile "hello, world!" via diag_printf() using minimal template,
> it is our pain (that is famous 32K stack size issue), also I have doubts
> about ~1/2 eCos kernel tests which use stacks like STACK_SIZE_TYPICAL x
> N. Ilija, it does not seem to me that all decision makers and experts on
> CC list of the Bug 1001125, so, I would raise the discussion on the same
> subject on ecos-devel list.

Appropriate stack sizes become critical on small memory targets and may become
highly dependent on the application. It would be wrong to _force_ the developer
into using certain stack sizes. Nevertheless, it would be helpful for new users
to be able to build some tests easily. One possibility is a "Constrain stack
sizes" CDL option in the platform HAL or variant HAL which 'requires' certain
stack sizes. It could be enabled by default to help new users and then disabled
when users gain more experience and can make decisions for themselves.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001125] New HAL for the Stellaris EK-LM3S811 board

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001125

Christophe Coutand <ecos@hotmail.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1100|0                           |1
        is obsolete|                            |

--- Comment #18 from Christophe Coutand <ecos@hotmail.co.uk> 2011-01-31 19:43:09 GMT ---
Created an attachment (id=1112)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1112)
ADC device driver, second version

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001125] New HAL for the Stellaris EK-LM3S811 board

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001125

Christophe Coutand <ecos@hotmail.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1099|0                           |1
        is obsolete|                            |

--- Comment #19 from Christophe Coutand <ecos@hotmail.co.uk> 2011-01-31 19:45:42 GMT ---
Created an attachment (id=1113)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1113)
I2C device driver, second version

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001125] New HAL for the Stellaris EK-LM3S811 board

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001125

Christophe Coutand <ecos@hotmail.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1096|0                           |1
        is obsolete|                            |

--- Comment #20 from Christophe Coutand <ecos@hotmail.co.uk> 2011-01-31 20:01:09 GMT ---
Created an attachment (id=1114)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1114)
lm3s HAL, second version

Hi Sergei,

Please find updated patches. Test cases are re-tested OK.

Christophe

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001125] New HAL for the Stellaris EK-LM3S811 board

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001125

--- Comment #21 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2011-01-31 20:17:32 GMT ---
(In reply to comment #20)
> Created an attachment (id=1114)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1114)
> lm3s HAL, second version
> 
> Hi Sergei,
> 
> Please find updated patches. Test cases are re-tested OK.
> 
> Christophe

Hi Christope,

Thank you, I will take a look.

Sergei

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001125] New HAL for the Stellaris EK-LM3S811 board

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001125

--- Comment #22 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2011-02-04 13:37:14 GMT ---
Christophe, I've passed 3/4 of the lines (ADC, I2C and variant HAL), by the
finish I will attach a few diff files.

Sergei

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001125] New HAL for the Stellaris EK-LM3S811 board

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001125

--- Comment #23 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2011-02-06 12:14:17 GMT ---
Created an attachment (id=1119)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1119)
lm3s: cleanup diff

This is a clean-up diff against the latest sets of the patches:

Attachment 1112
Attachment 1113
Attachment 1114

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001125] New HAL for the Stellaris EK-LM3S811 board

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001125

--- Comment #24 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2011-02-06 12:23:37 GMT ---
(In reply to comment #23)
> Created an attachment (id=1119)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1119) [details]
> lm3s: cleanup diff
> 
> This is a clean-up diff against the latest sets of the patches:
> 
> Attachment 1112 [details]
> Attachment 1113 [details]
> Attachment 1114 [details]

Hi Christophe,

Please, do apply this diff file to your sources.

Could you, please, repeat your builds and tests with it? Well, I have a common
patch against the latest CVS sources, but I do not attach that one here before
than I will get your test report with this stuff.

Thank you,
Sergei

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001125] New HAL for the Stellaris EK-LM3S811 board

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001125

--- Comment #25 from Christophe Coutand <ecos@hotmail.co.uk> 2011-02-06 13:28:26 GMT ---
Hi Sergei,

All tests are building and running ok on target with your latest diff applied.

Christophe

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001125] New HAL for the Stellaris EK-LM3S811 board

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001125

--- Comment #26 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2011-02-06 14:45:48 GMT ---
(In reply to comment #24)
> Hi Sergei,
> 
> All tests are building and running ok on target with your latest diff
> applied.
> 
> Christophe

Thank you, then I attach a final patch for anoncvs.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001125] New HAL for the Stellaris EK-LM3S811 board

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001125

Sergei Gavrikov <sergei.gavrikov@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1098|0                           |1
        is obsolete|                            |
   Attachment #1111|0                           |1
        is obsolete|                            |
   Attachment #1112|0                           |1
        is obsolete|                            |
   Attachment #1113|0                           |1
        is obsolete|                            |
   Attachment #1114|0                           |1
        is obsolete|                            |
   Attachment #1119|0                           |1
        is obsolete|                            |

--- Comment #27 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2011-02-06 14:52:49 GMT ---
Created an attachment (id=1120)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1120)
lm3s: cortex lm3s packages (no ecos.db)

There are 5 new eCos packages:

CYGPKG_DEVS_I2C_CORTEXM_LM3S
CYGPKG_DEVS_ADC_CORTEXM_LM3S
CYGPKG_HAL_CORTEXM_LM3S
CYGPKG_HAL_CORTEXM_LM3S8XX
CYGPKG_HAL_CORTEXM_EK_LM3S811

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001125] New HAL for the Stellaris EK-LM3S811 board

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001125

Sergei Gavrikov <sergei.gavrikov@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1098|1                           |0
        is obsolete|                            |

--- Comment #28 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2011-02-06 15:35:22 GMT ---
(From update of attachment 1098)
Sorry, should be applied (in error it was marked as obsolete).

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001125] New HAL for the Stellaris EK-LM3S811 board

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001125

--- Comment #29 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2011-02-08 18:26:19 GMT ---
It seems that period of quarantine for reviews will be over soon.  If no
one has objections, I would be glad to add the Christophe's packages to
public repository. What do you think?

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001125] New HAL for the Stellaris EK-LM3S811 board

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001125

--- Comment #30 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2011-02-08 22:02:37 GMT ---
Well, the patch was slowly scrolled down once again. I noticed that
legal_values for CYGHWR_HAL_CORTEXM_LM3S8XX_SYSCLK_DIV are 1, 4, 5,
6, ... 15, and 16 (system clock divider values).

Christophe, what is about 2 & 3? Typo? Is there a reason to reject
these values?

comment: BUGZ: Any line beginning with 'BUGZ:' will be ignored.  BUGZ:
---------------------------------------------------

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001125] New HAL for the Stellaris EK-LM3S811 board

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001125

--- Comment #31 from Christophe Coutand <ecos@hotmail.co.uk> 2011-02-08 22:25:55 GMT ---
Hi Sergei,

This is not a typo but you are correct, 2 and 3 should be in the list. Value 2
and 3 are only allowed when the PLL is bypassed, so i did not know what to do
with it at first.

Now I see that it is fine to have it in the list, the constraint on
CYGHWR_HAL_CORTEXM_LM3S8XX_SYSCLK will prevent user from selecting 2 and 3
because this would lead to a frequency (SYSCLK) larger than the maximum allowed
frequency.

Christophe

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001125] New HAL for the Stellaris EK-LM3S811 board

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001125

Jonathan Larmour <jifl@ecoscentric.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jifl@ecoscentric.com
               Flag|                            |Patch_or_Contribution+

--- Comment #32 from Jonathan Larmour <jifl@ecoscentric.com> 2011-02-09 01:25:40 GMT ---
I've scanned through the patches and nothing major has leapt out at me.

My only comments are essentially cosmetic:

You don't need the memory segments if there's only one of them, and indeed you
have (correctly) not defined CYGBLD_REDBOOT_MAX_MEM_SEGMENTS. And RedBoot
probably will never be supported anyway. So that function can just go away.

The HAL_VAR_INTERRUPT_* macros should go - if they're not defined, the code in
the arch HAL which uses them should do the right thing.

And utterly trivial: the default_ROM.ecm has "template default" in it. Your
documentation uses the minimal template, not default, so by rights the .ecm
should have "template minimal". I don't know about anyone else, but I look at
the template line of .ecm files to see what template this .ecm should be
applied to.

All in all, it's a very good quality patch. Thanks!

Jifl

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001125] New HAL for the Stellaris EK-LM3S811 board

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001125

Jonathan Larmour <jifl@ecoscentric.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1120|                            |assignment+, review+
               Flag|                            |

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001125] New HAL for the Stellaris EK-LM3S811 board

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001125

--- Comment #33 from Christophe Coutand <ecos@hotmail.co.uk> 2011-02-09 08:24:06 GMT ---
Thanks Jonathan for reviewing the patch.

Sergei, shall I post a new patch will all the required changes?

Christophe

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001125] New HAL for the Stellaris EK-LM3S811 board

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001125

--- Comment #34 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2011-02-09 08:39:01 GMT ---
(In reply to comment #33)
> Thanks Jonathan for reviewing the patch.
> 
> Sergei, shall I post a new patch will all the required changes?
> 
> Christophe

If you can, can you sent a diff for Attachment 1120 ? If you want I will
apply those small changes (Jonathan proposals) tonight.

Sergei

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001125] New HAL for the Stellaris EK-LM3S811 board

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001125

--- Comment #35 from Christophe Coutand <ecos@hotmail.co.uk> 2011-02-09 18:29:56 GMT ---
Created an attachment (id=1124)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1124)
Additional diff to attachment 1120

Hi Sergei,

Find attached a diff file including latest updates.

Christophe

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001125] New HAL for the Stellaris EK-LM3S811 board

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001125

--- Comment #36 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2011-02-09 18:36:28 GMT ---
(In reply to comment #35)
> Created an attachment (id=1124)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1124)
> Additional diff to attachment 1120
> 
> Hi Sergei,
> 
> Find attached a diff file including latest updates.
> 
> Christophe

Hi Christophe,

We work in parallel :-) However, I started a few minutes ago, so, -
thank you!

Sergei

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001125] New HAL for the Stellaris EK-LM3S811 board

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001125

--- Comment #37 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2011-02-09 20:58:24 GMT ---
Christophe,

Now checked-in. Many thanks for your contribution to eCos!

Sergei

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001125] New HAL for the Stellaris EK-LM3S811 board

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001125

--- Comment #38 from Christophe Coutand <ecos@hotmail.co.uk> 2011-02-09 21:28:26 GMT ---
Thank you for your time Sergei.

Christophe

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001125] New HAL for the Stellaris EK-LM3S811 board

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001125

--- Comment #39 from John Dallaway <john@dallaway.org.uk> 2011-02-09 22:21:00 GMT ---
Created an attachment (id=1125)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1125)
ek_lm3s811-doc-110209.patch

Minor fix to eliminate underscores from the SGML ID strings. They cause
problems for some some openjade installations. Checked-in.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001125] New HAL for the Stellaris EK-LM3S811 board

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001125

Sergei Gavrikov <sergei.gavrikov@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |CURRENTRELEASE

--- Comment #40 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2011-02-11 16:38:09 GMT ---
Closing the Bug 1001125

Christophe, -- thanks for your distribution,
Jifl, John, -- thanks for experienced look.

Marked as RESOLVED.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001125] New HAL for the Stellaris EK-LM3S811 board

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001125

--- Comment #41 from John Dallaway <john@dallaway.org.uk> 2011-02-18 15:27:32 GMT ---
Created an attachment (id=1140)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1140)
ek-lm3s811-target-110218.patch

Tweak to remove the non-hardware package CYGPKG_IO_ADC from the ek-lm3s811
target record in ecos.db. Target records should list hardware packages only.
Checked-in.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.