[Bug 1001159] Fixes from FreeBSD IP Stack CVS

[Bug 1001159] Fixes from FreeBSD IP Stack CVS

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001159

Kelvin Lawson <kelvinl@users.sf.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ecos-patches@ecos.sourcewar
                   |                            |e.org
          Component|TCP/IP                      |Patches and contributions

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001159] Fixes from FreeBSD IP Stack CVS

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001159

Jonathan Larmour <jifl@ecoscentric.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
                 CC|                            |jifl@ecoscentric.com
         AssignedTo|unassigned@bugs.ecos.source |jifl@ecoscentric.com
                   |ware.org                    |
     Ever Confirmed|0                           |1
               Flag|                            |Patch_or_Contribution+

--- Comment #1 from Jonathan Larmour <jifl@ecoscentric.com> 2011-02-22 04:34:07 GMT ---
Hi Kelvin,

Thanks for the patch! This looks good, although I think there should be two
minor changes:
- make CYGPKG_NET_TCP_REASS_DIVISOR be of "booldata" type, which means we can
eliminate CYGPKG_NET_TCP_REASS_LIMIT.
- make all the added queue limit stuff depend on this option being set.
Otherwise we're adding code (albeit small) which can never be used.

I'll attach the patch I'm committing now.

For the record, the bulk of these patches originate from FreeBSD, so there is
no need for a copyright assignment for the trivial stuff left over.

Jifl

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001159] Fixes from FreeBSD IP Stack CVS

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001159

Jonathan Larmour <jifl@ecoscentric.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1145|0                           |1
        is obsolete|                            |
   Attachment #1146|                            |assignment+, review+
               Flag|                            |

--- Comment #2 from Jonathan Larmour <jifl@ecoscentric.com> 2011-02-22 04:35:35 GMT ---
Created an attachment (id=1146)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1146)
Updated version of patch as per my review comments

I'm checking this patch in.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001159] Fixes from FreeBSD IP Stack CVS

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001159

Jonathan Larmour <jifl@ecoscentric.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |NEXTRELEASE

--- Comment #3 from Jonathan Larmour <jifl@ecoscentric.com> 2011-02-22 04:36:53 GMT ---
Marking resolved as I've committed the patch.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.